OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

osganimationskinning


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
Cedric Pinson
Guest





PostPosted: Thu Jan 08, 2009 2:31 pm    Post subject:
osganimationskinning
Reply with quote

Hi Robert,

Here the updated osganimationskinning.cpp that works as before

Cheers,
Cedric

--
+33 (0) 6 63 20 03 56 Cedric Pinson mailto:mornifle@plopbyte.net http://www.plopbyte.net





------------------
Post generated by Mail2Forum
Back to top
Robert Osfield
Guest





PostPosted: Thu Jan 08, 2009 2:48 pm    Post subject:
osganimationskinning
Reply with quote

Thanks Cedric, fix now merged and submitted to svn.

The fact the code was crash is concerning as it could mean that user
code that doesn't set the callback will fall afoul of the same problem
without any particular clues to what the cause of the crash is. I
makes me feel that class design isn't yet hanging nicely together -
they should work with default settings, even if they can't work fully
with configuration they surely shouldn't crash.

Robert.

On Thu, Jan 8, 2009 at 2:31 PM, Cedric Pinson <> wrote:
Quote:
Hi Robert,

Here the updated osganimationskinning.cpp that works as before

Cheers,
Cedric

--
+33 (0) 6 63 20 03 56 Cedric Pinson mailto:
http://www.plopbyte.net








------------------
Post generated by Mail2Forum
Back to top
Cedric Pinson
Guest





PostPosted: Thu Jan 08, 2009 4:36 pm    Post subject:
osganimationskinning
Reply with quote

Hi Robert,

In fact i am agree with you it should not crash, but on this example the
problem was in the example

osgAnimation::AnimationUpdateCallback* cb = dynamic_cast<osgAnimation::AnimationUpdateCallback*>(right0->getUpdateCallback());
cb->setName("xxx");

So in this case it can only crash without check in the example. The
crash cames from the example not the inside osgAnimation.
Does it make more sense to you ?

Cheers,
Cedric

Robert Osfield wrote:
Quote:
Thanks Cedric, fix now merged and submitted to svn.

The fact the code was crash is concerning as it could mean that user
code that doesn't set the callback will fall afoul of the same problem
without any particular clues to what the cause of the crash is. I
makes me feel that class design isn't yet hanging nicely together -
they should work with default settings, even if they can't work fully
with configuration they surely shouldn't crash.

Robert.

On Thu, Jan 8, 2009 at 2:31 PM, Cedric Pinson <> wrote:

Quote:
Hi Robert,

Here the updated osganimationskinning.cpp that works as before

Cheers,
Cedric

--
+33 (0) 6 63 20 03 56 Cedric Pinson mailto:
http://www.plopbyte.net










--
+33 (0) 6 63 20 03 56 Cedric Pinson mailto: http://www.plopbyte.net




------------------
Post generated by Mail2Forum
Back to top
Robert Osfield
Guest





PostPosted: Thu Jan 08, 2009 7:07 pm    Post subject:
osganimationskinning
Reply with quote

HI Cedric,

Yes thank makes more sense. So the example should really do the check.

Robert.

On Thu, Jan 8, 2009 at 4:36 PM, Cedric Pinson <> wrote:
Quote:
Hi Robert,

In fact i am agree with you it should not crash, but on this example the
problem was in the example

osgAnimation::AnimationUpdateCallback* cb =
dynamic_cast<osgAnimation::AnimationUpdateCallback*>(right0->getUpdateCallback());
cb->setName("xxx");

So in this case it can only crash without check in the example. The crash
cames from the example not the inside osgAnimation.
Does it make more sense to you ?

Cheers,
Cedric

Robert Osfield wrote:
Quote:

Thanks Cedric, fix now merged and submitted to svn.

The fact the code was crash is concerning as it could mean that user
code that doesn't set the callback will fall afoul of the same problem
without any particular clues to what the cause of the crash is. I
makes me feel that class design isn't yet hanging nicely together -
they should work with default settings, even if they can't work fully
with configuration they surely shouldn't crash.

Robert.

On Thu, Jan 8, 2009 at 2:31 PM, Cedric Pinson <>
wrote:

Quote:

Hi Robert,

Here the updated osganimationskinning.cpp that works as before

Cheers,
Cedric

--
+33 (0) 6 63 20 03 56 Cedric Pinson mailto:
http://www.plopbyte.net











--
+33 (0) 6 63 20 03 56 Cedric Pinson mailto:
http://www.plopbyte.net






------------------
Post generated by Mail2Forum
Back to top
Cedric Pinson
Guest





PostPosted: Thu Jan 08, 2009 9:07 pm    Post subject:
osganimationskinning
Reply with quote

Hi Robert,
Yes this example is a bit old, i need to revisit it, and make it cleaner.

Cheers,
Cedric

Robert Osfield wrote:
Quote:
HI Cedric,

Yes thank makes more sense. So the example should really do the check.

Robert.

On Thu, Jan 8, 2009 at 4:36 PM, Cedric Pinson <> wrote:

Quote:
Hi Robert,

In fact i am agree with you it should not crash, but on this example the
problem was in the example

osgAnimation::AnimationUpdateCallback* cb =
dynamic_cast<osgAnimation::AnimationUpdateCallback*>(right0->getUpdateCallback());
cb->setName("xxx");

So in this case it can only crash without check in the example. The crash
cames from the example not the inside osgAnimation.
Does it make more sense to you ?

Cheers,
Cedric

Robert Osfield wrote:

Quote:
Thanks Cedric, fix now merged and submitted to svn.

The fact the code was crash is concerning as it could mean that user
code that doesn't set the callback will fall afoul of the same problem
without any particular clues to what the cause of the crash is. I
makes me feel that class design isn't yet hanging nicely together -
they should work with default settings, even if they can't work fully
with configuration they surely shouldn't crash.

Robert.

On Thu, Jan 8, 2009 at 2:31 PM, Cedric Pinson <>
wrote:


Quote:
Hi Robert,

Here the updated osganimationskinning.cpp that works as before

Cheers,
Cedric

--
+33 (0) 6 63 20 03 56 Cedric Pinson mailto:
http://www.plopbyte.net











--
+33 (0) 6 63 20 03 56 Cedric Pinson mailto:
http://www.plopbyte.net








--
+33 (0) 6 63 20 03 56 Cedric Pinson mailto: http://www.plopbyte.net




------------------
Post generated by Mail2Forum
Back to top
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts osganimationskinning broken? rosme General 2 Wed Jan 07, 2009 10:00 pm View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP