OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

OpenThreads/Version and osg/Version


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Build system [build]
View previous topic :: View next topic  
Author Message
Christian
Newbie


Joined: 16 Oct 2010
Posts: 13

PostPosted: Fri Nov 28, 2014 2:16 pm    Post subject:
OpenThreads/Version and osg/Version
Reply with quote

Hi,

I have a question regarding OpenThreads/Version and osg/Version files: Instead of being generated by cmake into the ${PROJECT_BINARY_DIR} they are generated into the source directory (${CMAKE_CURRENT_SOURCE_DIR}). Doesn't this break out of source build? In addition those generated files are checked into the version control system.

Compare Config and GL header being generated into the build directory and the version file into the source directory (main CMakeList.txt file):

SET(OPENSCENEGRAPH_CONFIG_HEADER "${PROJECT_BINARY_DIR}/include/osg/Config")
CONFIGURE_FILE("${CMAKE_CURRENT_SOURCE_DIR}/src/osg/Config.in"
"${OPENSCENEGRAPH_CONFIG_HEADER}")
SET(OPENSCENEGRAPH_OPENGL_HEADER "${PROJECT_BINARY_DIR}/include/osg/GL")
CONFIGURE_FILE("${CMAKE_CURRENT_SOURCE_DIR}/src/osg/GL.in"
"${OPENSCENEGRAPH_OPENGL_HEADER}")
# INSTALL_FILES(/include/osg/ FILES "${OPENSCENEGRAPH_CONFIG_HEADER}")
################################################################################
# Set Vertsion header file
SET(OPENSCENEGRAPH_VERSION_HEADER "${CMAKE_CURRENT_SOURCE_DIR}/include/osg/Version")
CONFIGURE_FILE("${CMAKE_CURRENT_SOURCE_DIR}/src/osg/Version.in"
"${OPENSCENEGRAPH_VERSION_HEADER}")

Is there a special reason or was it done by mistake?

Thank you!

Cheers,
Christian
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11311

PostPosted: Fri Nov 28, 2014 3:06 pm    Post subject:
OpenThreads/Version and osg/Version
Reply with quote

HI Christian,


I'm not the original author of this particular part of the CMake scripts so can't give an immediate answer.  Provisionally I would say that there is no reason why the Version header that is automatically generated so not be treated like the GL and Config headers.  I will amend it to be consistent and see if the in source and out of source builds work fine.

Robert.


On 28 November 2014 at 14:16, Christian Ruzicka < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi,

I have a question regarding OpenThreads/Version and osg/Version files: Instead of being generated by cmake into the ${PROJECT_BINARY_DIR} they are generated into the source directory (${CMAKE_CURRENT_SOURCE_DIR}). Doesn't this break out of source build? In addition those generated files are checked into the version control system.

Compare Config and GL header being generated into the build directory and the version file into the source directory (main CMakeList.txt file):

SET(OPENSCENEGRAPH_CONFIG_HEADER "${PROJECT_BINARY_DIR}/include/osg/Config")
CONFIGURE_FILE("${CMAKE_CURRENT_SOURCE_DIR}/src/osg/Config.in"
"${OPENSCENEGRAPH_CONFIG_HEADER}")
SET(OPENSCENEGRAPH_OPENGL_HEADER "${PROJECT_BINARY_DIR}/include/osg/GL")
CONFIGURE_FILE("${CMAKE_CURRENT_SOURCE_DIR}/src/osg/GL.in"
"${OPENSCENEGRAPH_OPENGL_HEADER}")
# INSTALL_FILES(/include/osg/ FILES "${OPENSCENEGRAPH_CONFIG_HEADER}")
################################################################################
# Set Vertsion header file
SET(OPENSCENEGRAPH_VERSION_HEADER "${CMAKE_CURRENT_SOURCE_DIR}/include/osg/Version")
CONFIGURE_FILE("${CMAKE_CURRENT_SOURCE_DIR}/src/osg/Version.in"
"${OPENSCENEGRAPH_VERSION_HEADER}")

Is there a special reason or was it done by mistake?

Thank you!

Cheers,
Christian

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=61908#61908





_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11311

PostPosted: Fri Nov 28, 2014 4:14 pm    Post subject:
OpenThreads/Version and osg/Version
Reply with quote

On 28 November 2014 at 15:01, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
HI Christian,


I'm not the original author of this particular part of the CMake scripts so can't give an immediate answer.  Provisionally I would say that there is no reason why the Version header that is automatically generated so not be treated like the GL and Config headers.  I will amend it to be consistent and see if the in source and out of source builds work fine.


This works fine so I've gone ahead and merged these changes with svn/trunk.

Robert.

 

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Christian
Newbie


Joined: 16 Oct 2010
Posts: 13

PostPosted: Sat Nov 29, 2014 3:24 pm    Post subject:
Reply with quote

Hi,

Thanks Roberts! This makes the handling of our internal OSG repository easier.

Cheers,
Christian
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Build system [build] All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts OpenThreads Doxygen documentation Montgomery, David General 2 Wed Jan 10, 2018 5:44 pm View latest post
No new posts GL3: non-GL3 version number: 1.0 pixelord General 12 Thu Oct 12, 2017 3:36 am View latest post
No new posts [EXTERNAL] Re: Is there a binary dist... Brian Davis General 8 Thu Oct 05, 2017 6:00 pm View latest post
No new posts Is there a binary distribution availa... Brian Davis General 1 Thu Oct 05, 2017 7:02 am View latest post
No new posts Specifying the GL context version to ... Sandro Mani General 17 Mon Aug 21, 2017 11:43 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP