OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

OpenThreads with Qt


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
Mathieu (Mathieu MARACHE)
Appreciator


Joined: 29 Oct 2009
Posts: 115

PostPosted: Tue Jun 07, 2016 4:09 pm    Post subject:
OpenThreads with Qt
Reply with quote

Hi Robert, 

While building OpenThreads with Qt threads support, the CMakeLists.txt had an error. This fixes the build.


This is ok for both the 3.4 release and master branches


Regards
--
nǝıɥʇɐƜ

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12264

PostPosted: Wed Jun 08, 2016 4:28 pm    Post subject:
OpenThreads with Qt
Reply with quote

Hi Mathieu,

I've just done a diff and can't spot a difference to what we already
have in the 3.4 branch and master.

Robert.

On 7 June 2016 at 17:00, Mathieu MARACHE <> wrote:
Quote:
Hi Robert,

While building OpenThreads with Qt threads support, the CMakeLists.txt had
an error. This fixes the build.

This is ok for both the 3.4 release and master branches

Regards
--
nǝıɥʇɐƜ





------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Mathieu (Mathieu MARACHE)
Appreciator


Joined: 29 Oct 2009
Posts: 115

PostPosted: Thu Jun 09, 2016 6:40 am    Post subject:
OpenThreads with Qt
Reply with quote

Hi Robert,


You are right, master branch is correct but OpenScene-Graph-3.4 isn't.


--
nǝıɥʇɐƜ



On 8 June 2016 at 18:20, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Mathieu,

I've just done a diff and can't spot a difference to what we already
have in the 3.4 branch and master.

Robert.

On 7 June 2016 at 17:00, Mathieu MARACHE < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert,

While building OpenThreads with Qt threads support, the CMakeLists.txt had
an error. This fixes the build.

This is ok for both the 3.4 release and master branches

Regards
--
nǝıɥʇɐƜ



Quote:
_______________________________________________
osg-submissions mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

_______________________________________________
osg-submissions mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12264

PostPosted: Thu Jun 09, 2016 7:22 am    Post subject:
OpenThreads with Qt
Reply with quote

On 9 June 2016 at 07:31, Mathieu MARACHE <> wrote:
Quote:
Hi Robert,

You are right, master branch is correct but OpenScene-Graph-3.4 isn't.

I have OpenSceneGraph-3.4 branch checked out and the
src/OpenThreads/CMakeLists.txt is identical to the one you provided in
your zip file and identical to the one you have in your git clone of
the OSG.

If you think there something wrong with the OSG's 3.4 branch you'll
need to be specific and also provide the correct files.

Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Mathieu (Mathieu MARACHE)
Appreciator


Joined: 29 Oct 2009
Posts: 115

PostPosted: Thu Jun 09, 2016 12:30 pm    Post subject:
OpenThreads with Qt
Reply with quote

Hi Robert, 

I'm talking about https://github.com/openscenegraph/OpenSceneGraph/blob/OpenSceneGraph-3.4/src/OpenThreads/qt/CMakeLists.txt
line 80 reads ")" it should be "endif()"

--
nǝıɥʇɐƜ



On 9 June 2016 at 09:13, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
On 9 June 2016 at 07:31, Mathieu MARACHE < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert,

You are right, master branch is correct but OpenScene-Graph-3.4 isn't.

I have OpenSceneGraph-3.4 branch checked out and the
src/OpenThreads/CMakeLists.txt is identical to the one you provided in
your zip file and identical to the one you have in your git clone of
the OSG.

If you think there something wrong with the OSG's 3.4 branch you'll
need to be specific and also provide the correct files.

Robert.
_______________________________________________
osg-submissions mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org




------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12264

PostPosted: Thu Jun 09, 2016 1:20 pm    Post subject:
OpenThreads with Qt
Reply with quote

Hi Mathieu,

OK, found it now, this is not the file you sent though, you sent
OpenThreads/CMakeLists.txt rather than OpenThreads/qt/CMakeLists.txt

I have merged your git fork version of the qt/CMakeLists.txt file with
the OpenScenGraph-3.4 branch.

Robert.

On 9 June 2016 at 13:21, Mathieu MARACHE <> wrote:
Quote:
Hi Robert,

I'm talking about
https://github.com/openscenegraph/OpenSceneGraph/blob/OpenSceneGraph-3.4/src/OpenThreads/qt/CMakeLists.txt
line 80 reads ")" it should be "endif()"

--
nǝıɥʇɐƜ

On 9 June 2016 at 09:13, Robert Osfield <> wrote:
Quote:

On 9 June 2016 at 07:31, Mathieu MARACHE <>
wrote:
Quote:
Hi Robert,

You are right, master branch is correct but OpenScene-Graph-3.4 isn't.

I have OpenSceneGraph-3.4 branch checked out and the
src/OpenThreads/CMakeLists.txt is identical to the one you provided in
your zip file and identical to the one you have in your git clone of
the OSG.

If you think there something wrong with the OSG's 3.4 branch you'll
need to be specific and also provide the correct files.

Robert.








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Mathieu (Mathieu MARACHE)
Appreciator


Joined: 29 Oct 2009
Posts: 115

PostPosted: Thu Jun 09, 2016 1:59 pm    Post subject:
OpenThreads with Qt
Reply with quote

thanks sorry for the wrong file sent...


--
nǝıɥʇɐƜ



On 9 June 2016 at 15:11, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Mathieu,

OK, found it now, this is not the file you sent though, you sent
OpenThreads/CMakeLists.txt rather than OpenThreads/qt/CMakeLists.txt

I have merged your git fork version of the qt/CMakeLists.txt file with
the OpenScenGraph-3.4 branch.

Robert.

On 9 June 2016 at 13:21, Mathieu MARACHE < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert,

I'm talking about
https://github.com/openscenegraph/OpenSceneGraph/blob/OpenSceneGraph-3.4/src/OpenThreads/qt/CMakeLists.txt
line 80 reads ")" it should be "endif()"

--
nǝıɥʇɐƜ

On 9 June 2016 at 09:13, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:

On 9 June 2016 at 07:31, Mathieu MARACHE < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)>
wrote:
Quote:
Hi Robert,

You are right, master branch is correct but OpenScene-Graph-3.4 isn't.

I have OpenSceneGraph-3.4 branch checked out and the
src/OpenThreads/CMakeLists.txt is identical to the one you provided in
your zip file and identical to the one you have in your git clone of
the OSG.

If you think there something wrong with the OSG's 3.4 branch you'll
need to be specific and also provide the correct files.

Robert.
_______________________________________________
osg-submissions mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org



_______________________________________________
osg-submissions mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

_______________________________________________
osg-submissions mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org




------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts OpenThreads Mutex::lock() crash guyv General 0 Thu Jul 12, 2018 6:50 pm View latest post
No new posts Missing OpenThreads PDB when building... guyv Build system [build] 0 Thu Jul 12, 2018 12:39 pm View latest post
No new posts OpenThreads Doxygen documentation Montgomery, David General 2 Wed Jan 10, 2018 5:44 pm View latest post
No new posts OpenThreads Pthread.cpp fails to comp... crubel@compro.net Submission 3 Tue Nov 29, 2016 9:26 pm View latest post
No new posts ot20-Openthreads.dll access violation umadevi2193 General 19 Mon Oct 17, 2016 6:08 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP