OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

OpenSceneGraph Travis + Coverity scan up and running


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General
View previous topic :: View next topic  
Author Message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11193

PostPosted: Tue Jun 21, 2016 9:12 am    Post subject:
OpenSceneGraph Travis + Coverity scan up and running
Reply with quote

With help form Ralf Habacker and Jordi Torress we now have Travis
build testing and Coverity scan up and running. If you got to the
OSG's github page :

https://github.com/openscenegraph/OpenSceneGraph

and look down to the README.md you'll see two little bullet icons:

[build | passing] [ coverity | passed 5 new defects]

You can click on the build icon and it'll take you to the Travis build
logs, and click on the Coverity one and it'll take you to our new
Coverity analysis page.

For the up coming OpenSceneGraph-3.6 stable release I would like to
improve the Coverity defect count. I have already made dozens of small
fixes to code highlight by Coverity, there is still a long way to go.
For this effort I'd appreciate help from the community :-)

My personally priority is to squash the High priority ones first, then
move on to Midium and then lower priority ones. Also defects picked
up in the core libraries like osg, osgUtil, osgDB, osgGA, osgViewer
are ones that will benefit the most users.

As well as code fixes just reviewing the defect reports and accessing
how crucial it is would be helpful. The Coverity web interface allows
you to add comments as well as adjust properties/categorization of
defects. For this you'll need to either log into via your Github
account or create a Coverity account.

As work on cleaning up defects progresses I will apply the fixes to
master as they come in and then every couple of days merge these
changes as a block to the new coverity_scan branch which will then
fire off a Coverity scan so we can get an update of how the clean up
is progressing.

When doing fixes please make sure that you fully understand the code
you are modifying and the nature of the defect. It's all too easy to
fix a warning/defect report on code that was working fine and then
have the new "improved" code introduce a bug that neither produces
warning or a Coverity scan. I say this as I have made this mistake
myself before, and also spotted such mistakes when merging changes
from others.

Thanks in advance for you help,
Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Jason Beverage
Guest





PostPosted: Tue Jun 21, 2016 9:00 pm    Post subject:
OpenSceneGraph Travis + Coverity scan up and running
Reply with quote

Really cool Robert.  I'd love to get TravisCI setup for osgEarth as well, we might pick your brain on it here soon.

On Tue, Jun 21, 2016 at 5:03 AM Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:

Quote:
With help form Ralf Habacker and Jordi Torress we now have Travis
build testing and Coverity scan up and running.  If you got to the
OSG's github page :

   https://github.com/openscenegraph/OpenSceneGraph

and look down to the README.md you'll see two little bullet icons:

  [build | passing]  [ coverity | passed 5 new defects]

You can click on the build icon and it'll take you to the Travis build
logs, and click on the Coverity one and it'll take you to our new
Coverity analysis page.

For the up coming OpenSceneGraph-3.6 stable release I would like to
improve the Coverity defect count. I have already made dozens of small
fixes to code highlight by Coverity, there is still a long way to go.
For this effort I'd appreciate help from the community Smile

My personally priority is to squash the High priority ones first, then
move on to Midium and then lower priority ones.  Also defects picked
up in the core libraries like osg, osgUtil, osgDB, osgGA, osgViewer
are ones that will benefit the most users.

As well as code fixes just reviewing the defect reports and accessing
how crucial it is would be helpful.  The Coverity web interface allows
you to add comments as well as adjust properties/categorization of
defects.  For this you'll need to either log into via your Github
account or create a Coverity account.

As work on cleaning up defects progresses I will apply the fixes to
master as they come in and then every couple of days merge these
changes as a block to the new coverity_scan branch which will then
fire off a Coverity scan so we can get an update of how the clean up
is progressing.

When doing fixes please make sure that you fully understand the code
you are modifying and the nature of the defect.  It's all too easy to
fix a warning/defect report on code that was working fine and then
have the new "improved" code introduce a bug that neither produces
warning or a Coverity scan.  I say this as I have made this mistake
myself before, and also spotted such mistakes when merging changes
from others.

Thanks in advance for you help,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11193

PostPosted: Thu Jun 23, 2016 2:41 pm    Post subject:
OpenSceneGraph Travis + Coverity scan up and running
Reply with quote

Hi Jason,

On 21 June 2016 at 21:51, Jason Beverage <> wrote:
Quote:
Really cool Robert. I'd love to get TravisCI setup for osgEarth as well, we
might pick your brain on it here soon.

I'm not the one with the skills on settings things up, Jordi and Ralf
were the main driving forces behind making it happen ;-)

For osgEarth you can look at what we've done with Travis by looking at
the .travis.yml that the OSG now has. It's not perfect but seems to
be working well now.

Cheers,
Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Jason Beverage
Guest





PostPosted: Thu Jun 23, 2016 3:02 pm    Post subject:
OpenSceneGraph Travis + Coverity scan up and running
Reply with quote

If it works, it's perfect Smile

I set something up for osgEarth and it appears to be working, at least for the travis builds.  I haven't seen coverity working yet though.  The travis build on my coverity_scan branch runs to completion and says that it's authorized with coverity and everything, but no coverity activity.  How long has it been taking you to see coverity activity on the dashboard once a travis build completes?


My travis file for osgearth and coverity is here https://github.com/gwaldron/osgearth/blob/coverity_scan/.travis.yml if any experts want to peek at it Wink


Jason


On Thu, Jun 23, 2016 at 10:33 AM Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:

Quote:
Hi Jason,

On 21 June 2016 at 21:51, Jason Beverage < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Really cool Robert.  I'd love to get TravisCI setup for osgEarth as well, we
might pick your brain on it here soon.

I'm not the one with the skills on settings things up, Jordi and Ralf
were the main driving forces behind making it happen Wink

For osgEarth you can look at what we've done with Travis by looking at
the .travis.yml that the OSG now has.  It's not perfect but seems to
be working well now.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11193

PostPosted: Thu Jun 23, 2016 3:04 pm    Post subject:
OpenSceneGraph Travis + Coverity scan up and running
Reply with quote

Hi All,

I've spent quite a few hours of the last week or so working getting
the Coverity defect count down. The latest Scan results are now up:

https://scan.coverity.com/projects/openscenegraph-openscenegraph

The average defect rates was 1.2 at the start, but now is down to
0.91. Still way above the open source average which is below 0.59.

I've cleared up the almost all of the High impact defects, the
remaining ones as they all pertain to the GLU mipmp+tesselation code
that's been integrated into the core osg library for quite a few
years. The GLU code is C code through and through and far from easy
to follow so I'm very wary about hacking in a "fix" that breaks
something. Other are welcome to test their programming skills on
these reported defects :-)

I have also begun cleaning up the header and core libraries, The
headers, osgDB, osgText, osgVolume, osgFX are now have zero reported
defects.

In terms of core libraries biggest source of outstanding defects is
now the osgAnimation NodeKit (this has a defect rate of 6.78 per
thousand lines of code), I'm not the author not a user of this Nodekit
so would appreciate osgAnimation users joining in a fixes these
defects.

Finally the biggest cause of defect reports by a long long way... our
osgPlugins. There average defect count is 1.88, but with 131 thousand
lines of code that ends up being 246! I didn't write the vast
majority of the osgPlugins, this is an area where the community have
contributed the most, so it's also an area where I'm the less
experienced with the code, so making judgements about it is less easy.
I've already fixed *many* defects in the osgPlugins, but I just don't
scale to tackling hundreds of defects on unfamiliar code.

So this is where it would be very very useful to have the community
help out. If a dozen of us put in a couple of hours a week then I'm
sure we'd have the majority dealt with within a week or two.

My own plan is to concentrate of the core OSG NodeKits. osgUtil, osgGA
and osgViewer will be my next targets. I can't dedicate fulltime this
as I have client work I need to get on with. It's something I'd like
to get done though, get the core OSG cleaned up for 3.6.

Thanks in advance for you help,
Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Jordi Torres
Guest





PostPosted: Thu Jun 23, 2016 4:49 pm    Post subject:
OpenSceneGraph Travis + Coverity scan up and running
Reply with quote

Hi Jason, 

It seems your coverity scan build is not being launched. Instead of this the "script" tag command is the one running. 
Take a look at https://github.com/openscenegraph/OpenSceneGraph/blob/master/.travis.yml#L52, the "normal" build should not be launched if you are in the coverity_branch. 
Also your project should be easier to configure as you are not running MacOSX builds, so you are not using a matrix for travis. So in a first look I cannot spot anything weird, but make sure the indentation is correct, as it seems to be important. 


I'm happy to help if I can so feel free to contact me. 


Cheers. 




2016-06-23 16:54 GMT+02:00 Jason Beverage < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)>:
Quote:
If it works, it's perfect Smile

I set something up for osgEarth and it appears to be working, at least for the travis builds.  I haven't seen coverity working yet though.  The travis build on my coverity_scan branch runs to completion and says that it's authorized with coverity and everything, but no coverity activity.  How long has it been taking you to see coverity activity on the dashboard once a travis build completes?


My travis file for osgearth and coverity is here https://github.com/gwaldron/osgearth/blob/coverity_scan/.travis.yml if any experts want to peek at it Wink


Jason


On Thu, Jun 23, 2016 at 10:33 AM Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:

Quote:
Hi Jason,

On 21 June 2016 at 21:51, Jason Beverage < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Really cool Robert.  I'd love to get TravisCI setup for osgEarth as well, we
might pick your brain on it here soon.

I'm not the one with the skills on settings things up, Jordi and Ralf
were the main driving forces behind making it happen Wink

For osgEarth you can look at what we've done with Travis by looking at
the .travis.yml that the OSG now has.  It's not perfect but seems to
be working well now.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org




_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org





--
Jordi Torres

------------------
Post generated by Mail2Forum
Back to top
Jason Beverage
Guest





PostPosted: Thu Jun 23, 2016 4:59 pm    Post subject:
OpenSceneGraph Travis + Coverity scan up and running
Reply with quote

Hey Jordi,

I saw that and I'm going to fix the script so it doesn't run the normal script, but the main issue is this:  https://github.com/travis-ci/travis-ci/issues/6142


Apparently the coverity addon is broken on travis and it can't download the coverity tools b/c of an SSL issue. Hopefully they will have that fixed soon.


Thanks!


Jason


On Thu, Jun 23, 2016 at 12:40 PM Jordi Torres < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:

Quote:
Hi Jason, 

It seems your coverity scan build is not being launched. Instead of this the "script" tag command is the one running. 
Take a look at https://github.com/openscenegraph/OpenSceneGraph/blob/master/.travis.yml#L52, the "normal" build should not be launched if you are in the coverity_branch. 
Also your project should be easier to configure as you are not running MacOSX builds, so you are not using a matrix for travis. So in a first look I cannot spot anything weird, but make sure the indentation is correct, as it seems to be important. 


I'm happy to help if I can so feel free to contact me. 


Cheers. 





2016-06-23 16:54 GMT+02:00 Jason Beverage < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)>:
Quote:
If it works, it's perfect Smile

I set something up for osgEarth and it appears to be working, at least for the travis builds.  I haven't seen coverity working yet though.  The travis build on my coverity_scan branch runs to completion and says that it's authorized with coverity and everything, but no coverity activity.  How long has it been taking you to see coverity activity on the dashboard once a travis build completes?


My travis file for osgearth and coverity is here https://github.com/gwaldron/osgearth/blob/coverity_scan/.travis.yml if any experts want to peek at it Wink


Jason


On Thu, Jun 23, 2016 at 10:33 AM Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:

Quote:
Hi Jason,

On 21 June 2016 at 21:51, Jason Beverage < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Really cool Robert.  I'd love to get TravisCI setup for osgEarth as well, we
might pick your brain on it here soon.

I'm not the one with the skills on settings things up, Jordi and Ralf
were the main driving forces behind making it happen Wink

For osgEarth you can look at what we've done with Travis by looking at
the .travis.yml that the OSG now has.  It's not perfect but seems to
be working well now.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org




_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org






--
Jordi Torres





_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


------------------
Post generated by Mail2Forum
Back to top
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts Running a per-frame task on the graph... James Turner General 2 Fri Sep 22, 2017 8:53 am View latest post
No new posts OpenSceneGraph static linking for And... tanshihaj Build system [build] 1 Thu Sep 21, 2017 12:56 pm View latest post
No new posts OpenSceneGraph-3.4.1 released! robertosfield General 3 Mon Aug 28, 2017 5:39 pm View latest post
No new posts OpenSceneGraph-3.4.1-rc3 tagged robertosfield General 2 Fri Aug 25, 2017 3:27 pm View latest post
No new posts OpenSceneGraph-3.4.1-rc2 tagged robertosfield General 3 Tue Aug 22, 2017 11:25 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP