OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

osganimation upgrade

Goto page 1, 2  Next
 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 519
Location: France

PostPosted: Thu Jun 23, 2016 3:00 pm    Post subject:
osganimation upgrade
Reply with quote

Hi,
I noticed that osganimation is not up to date in comparison with Cedric Pinson's repo (and hardware model have bug).
I copy/paste it and made implied changes in osgdbFBX
Do you have any objection to this merge?

Thank you!

Cheers,
Julien
Back to top
View user's profile Send private message Visit poster's website
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12264

PostPosted: Thu Jun 23, 2016 3:29 pm    Post subject:
osganimation upgrade
Reply with quote

Hi Julian (and Cedric),

I am happy to update but we need to make sure any bug fixes to
osgAnimation in the core OSG have also been integrated with Cedric's
version. I have recently made a number of fixes to clean up defects
reported by Coverity Scan so would rather not loose all these.

Perhaps the best way would be for Cedric to cherry pick what he feels
are appropriate changes into his osgAnimation then for us to pull this
in wholesale. I don't know if Cedric would have time look at the
Coverity Scan results but what would ideal for me would be to have
Cedric's version of osgAnimation have all the bug fixes and fixes to
the Coverity defects in then we just pull in this so the two are then
perfectly in sync.

Cheers,
Robert.

On 23 June 2016 at 16:00, Julien Valentin <> wrote:
Quote:
Hi,
I noticed that osganimation is not up to date in comparison with Cedric Pinson's repo (and hardware model have bug).
I copy/paste it and made implied changes in osgdbFBX
Do you have any objection to this merge?

Thank you!

Cheers,
Julien

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67755#67755








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 519
Location: France

PostPosted: Thu Jun 23, 2016 3:51 pm    Post subject:
Re: osganimation upgrade
Reply with quote

Hi Robert
I make a quick review of the diffs with git master and there are not drastic
https://github.com/openscenegraph/OpenSceneGraph/compare/master...mp3butcher:master
It seams your fixes have been taken into account.
I will try to see what Coverity says...
I attach the minimum file changes (my last submission was mailny copy/paste)


robertosfield wrote:
Hi Julian (and Cedric),

I am happy to update but we need to make sure any bug fixes to
osgAnimation in the core OSG have also been integrated with Cedric's
version. I have recently made a number of fixes to clean up defects
reported by Coverity Scan so would rather not loose all these.

Perhaps the best way would be for Cedric to cherry pick what he feels
are appropriate changes into his osgAnimation then for us to pull this
in wholesale. I don't know if Cedric would have time look at the
Coverity Scan results but what would ideal for me would be to have
Cedric's version of osgAnimation have all the bug fixes and fixes to
the Coverity defects in then we just pull in this so the two are then
perfectly in sync.

Cheers,
Robert.

On 23 June 2016 at 16:00, Julien Valentin <> wrote:
Quote:
Hi,
I noticed that osganimation is not up to date in comparison with Cedric Pinson's repo (and hardware model have bug).
I copy/paste it and made implied changes in osgdbFBX
Do you have any objection to this merge?

Thank you!

Cheers,
Julien

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67755#67755








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12264

PostPosted: Fri Jun 24, 2016 12:17 pm    Post subject:
osganimation upgrade
Reply with quote

Hi Julian,

I haven't done a review yet but will do after lunch. Is there any
gotcha's I should be looking out for when merging?

Thoughts on attempt to pull in the changes from your git repository
rather than zip? Are there particular commits that I'd need to pull
in to do this?

Robert.



On 23 June 2016 at 16:52, Julien Valentin <> wrote:
Quote:
Hi Robert
I make a quick review of the diffs with git master and there are not drastic
https://github.com/openscenegraph/OpenSceneGraph/compare/master...mp3butcher:master
It seams your fixes have been taken into account.
I will try to see what Coverity says...
I attach the minimum file changes (my last submission was mailny copy/paste)



robertosfield wrote:
Quote:
Hi Julian (and Cedric),

I am happy to update but we need to make sure any bug fixes to
osgAnimation in the core OSG have also been integrated with Cedric's
version. I have recently made a number of fixes to clean up defects
reported by Coverity Scan so would rather not loose all these.

Perhaps the best way would be for Cedric to cherry pick what he feels
are appropriate changes into his osgAnimation then for us to pull this
in wholesale. I don't know if Cedric would have time look at the
Coverity Scan results but what would ideal for me would be to have
Cedric's version of osgAnimation have all the bug fixes and fixes to
the Coverity defects in then we just pull in this so the two are then
perfectly in sync.

Cheers,
Robert.

On 23 June 2016 at 16:00, Julien Valentin <> wrote:

Quote:
Hi,
I noticed that osganimation is not up to date in comparison with Cedric Pinson's repo (and hardware model have bug).
I copy/paste it and made implied changes in osgdbFBX
Do you have any objection to this merge?

Thank you!

Cheers,
Julien

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67755#67755




_______________________________________________
osg-submissions mailing list

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org


_______________________________________________
osg-submissions mailing list

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

------------------
Post generated by Mail2Forum


------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67760#67760








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 519
Location: France

PostPosted: Fri Jun 24, 2016 12:44 pm    Post subject:
Re: osganimation upgrade
Reply with quote

I'm not familiar with git pull request to know if you can select only changes in osganimation
I made few changes from the original copy paste from cedric:
-I removed changes in Morph Geometry because the example doesn't work anymore (i will debug this)
-I apply fixes to cover coverage warnings
I've just updated the zip so I post it.
But If you want to try an attempt I've just make a pull request

robertosfield wrote:
Hi Julian,

I haven't done a review yet but will do after lunch. Is there any
gotcha's I should be looking out for when merging?

Thoughts on attempt to pull in the changes from your git repository
rather than zip? Are there particular commits that I'd need to pull
in to do this?

Robert.



On 23 June 2016 at 16:52, Julien Valentin <> wrote:
Quote:
Hi Robert
I make a quick review of the diffs with git master and there are not drastic
https://github.com/openscenegraph/OpenSceneGraph/compare/master...mp3butcher:master
It seams your fixes have been taken into account.
I will try to see what Coverity says...
I attach the minimum file changes (my last submission was mailny copy/paste)



robertosfield wrote:
Quote:
Hi Julian (and Cedric),

I am happy to update but we need to make sure any bug fixes to
osgAnimation in the core OSG have also been integrated with Cedric's
version. I have recently made a number of fixes to clean up defects
reported by Coverity Scan so would rather not loose all these.

Perhaps the best way would be for Cedric to cherry pick what he feels
are appropriate changes into his osgAnimation then for us to pull this
in wholesale. I don't know if Cedric would have time look at the
Coverity Scan results but what would ideal for me would be to have
Cedric's version of osgAnimation have all the bug fixes and fixes to
the Coverity defects in then we just pull in this so the two are then
perfectly in sync.

Cheers,
Robert.

On 23 June 2016 at 16:00, Julien Valentin <> wrote:

Quote:
Hi,
I noticed that osganimation is not up to date in comparison with Cedric Pinson's repo (and hardware model have bug).
I copy/paste it and made implied changes in osgdbFBX
Do you have any objection to this merge?

Thank you!

Cheers,
Julien

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67755#67755




_______________________________________________
osg-submissions mailing list

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org


_______________________________________________
osg-submissions mailing list

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

------------------
Post generated by Mail2Forum


------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67760#67760








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 519
Location: France

PostPosted: Fri Jun 24, 2016 1:24 pm    Post subject:
Re: osganimation upgrade
Reply with quote

The pull request now includes MorphGeometry changes (and its example)
I also attached updated zip (in case pull request merging is too hard)
Hope merging would not be too painfull (with all my other changes you may want to avoid)


mp3butcher wrote:
I'm not familiar with git pull request to know if you can select only changes in osganimation
I made few changes from the original copy paste from cedric:
-I removed changes in Morph Geometry because the example doesn't work anymore (i will debug this)
-I apply fixes to cover coverage warnings
I've just updated the zip so I post it.
But If you want to try an attempt I've just make a pull request

robertosfield wrote:
Hi Julian,

I haven't done a review yet but will do after lunch. Is there any
gotcha's I should be looking out for when merging?

Thoughts on attempt to pull in the changes from your git repository
rather than zip? Are there particular commits that I'd need to pull
in to do this?

Robert.



On 23 June 2016 at 16:52, Julien Valentin <> wrote:
Quote:
Hi Robert
I make a quick review of the diffs with git master and there are not drastic
https://github.com/openscenegraph/OpenSceneGraph/compare/master...mp3butcher:master
It seams your fixes have been taken into account.
I will try to see what Coverity says...
I attach the minimum file changes (my last submission was mailny copy/paste)



robertosfield wrote:
Quote:
Hi Julian (and Cedric),

I am happy to update but we need to make sure any bug fixes to
osgAnimation in the core OSG have also been integrated with Cedric's
version. I have recently made a number of fixes to clean up defects
reported by Coverity Scan so would rather not loose all these.

Perhaps the best way would be for Cedric to cherry pick what he feels
are appropriate changes into his osgAnimation then for us to pull this
in wholesale. I don't know if Cedric would have time look at the
Coverity Scan results but what would ideal for me would be to have
Cedric's version of osgAnimation have all the bug fixes and fixes to
the Coverity defects in then we just pull in this so the two are then
perfectly in sync.

Cheers,
Robert.

On 23 June 2016 at 16:00, Julien Valentin <> wrote:

Quote:
Hi,
I noticed that osganimation is not up to date in comparison with Cedric Pinson's repo (and hardware model have bug).
I copy/paste it and made implied changes in osgdbFBX
Do you have any objection to this merge?

Thank you!

Cheers,
Julien

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67755#67755




_______________________________________________
osg-submissions mailing list

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org


_______________________________________________
osg-submissions mailing list

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

------------------
Post generated by Mail2Forum


------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67760#67760








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12264

PostPosted: Fri Jun 24, 2016 1:51 pm    Post subject:
osganimation upgrade
Reply with quote

Hi Julian,

On 24 June 2016 at 14:24, Julien Valentin <> wrote:
Quote:
The pull request now includes MorphGeometry changes (and its example)
I also attached updated zip (in case pull request merging is too hard)
Hope merging would not be too painfull (with all my other changes you may want to avoid)

Just started having a look. Oh boy lots of files changed...

One of the things I've noticed is the your VAO changes are in the pull
request along with the changes to osgAnimation.

What I'd like to do is pull in the two sets of changes independently.
I need to concentrate on client work this afternoon so will dive back
in next weeks.

Cheers
Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 519
Location: France

PostPosted: Fri Jun 24, 2016 2:54 pm    Post subject:
Re: osganimation upgrade
Reply with quote

Hi Robert
Yes lot of changes indeed
It would be prefereable to stay with the good old incremental zip submission method..Smile

robertosfield wrote:
Hi Julian,

On 24 June 2016 at 14:24, Julien Valentin <> wrote:
Quote:
The pull request now includes MorphGeometry changes (and its example)
I also attached updated zip (in case pull request merging is too hard)
Hope merging would not be too painfull (with all my other changes you may want to avoid)

Just started having a look. Oh boy lots of files changed...

One of the things I've noticed is the your VAO changes are in the pull
request along with the changes to osgAnimation.

What I'd like to do is pull in the two sets of changes independently.
I need to concentrate on client work this afternoon so will dive back
in next weeks.

Cheers
Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12264

PostPosted: Sat Jun 25, 2016 7:04 am    Post subject:
osganimation upgrade
Reply with quote

Hi Julien,

I have done a merge based on the zip file you posted. I've assigned
Cedric as the author as I believe he's the author of the bulk of the
change, but added a not in the explanation that you are the one that
submitted and made fixes. Not ideal but hopefully conveys a bit of
the history of the changes.

During build I'm now see a few warnings, these are ones I probably
fixed in the previous code. There aren't many so I'll see if I can
fix them now and get the fixes checked in. Once we've got things
working cleanly we'll want to push these changes back to Cedric's
repository so we don't diverge too far again.

Robert.

[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformHardware.o
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:
In member function ‘bool
osgAnimation::RigTransformHardware::createPalette(int,
osgAnimation::BoneMap, const VertexIndexToBoneWeightMap&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:82:65:
warning: declaration of ‘it’ shadows a previous local [-Wshadow]
for (VertexInfluenceSet::BoneWeightList::const_iterator it =
boneWeightList.begin(); it != boneWeightList.end(); ++it)
^
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:77:73:
note: shadowed declaration is here
for (VertexInfluenceSet::VertexIndexToBoneWeightMap::const_iterator
it = vertexIndexToBoneWeightMap.begin(); it !=
vertexIndexToBoneWeightMap.end(); ++it)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformSoftware.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Skeleton.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedMatrixElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedQuaternionElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedRotateAxisElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedScaleElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTransform.o
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp: In
copy constructor
‘osgAnimation::StackedTransform::StackedTransform(const
osgAnimation::StackedTransform&, const osg::CopyOp&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp:21:1:
warning: base class ‘class
osg::MixinVector<osg::ref_ptr<osgAnimation::StackedTransformElement>
Quote:
’ should be explicitly initialized in the copy constructor [-Wextra]
StackedTransform::StackedTransform(const StackedTransform& rhs, const
osg::CopyOp& co)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTranslateElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsVisitor.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsHandler.o
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp: In
member function ‘void
osgAnimation::StatsGraph::changeYposition(float)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:93:19:
warning: declaration of ‘_pos’ shadows a member of
‘osgAnimation::StatsGraph’ [-Wshadow]
osg::Vec3 _pos = getMatrix().getTrans();
^
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:103:25:
note: shadowed declaration is here
osg::Vec3 _pos;
^
[ 93%] Building CXX object src/osgAnimation/CMakeFiles/osgAnimation.dir/Target.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/TimelineAnimationManager.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Timeline.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateBone.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMaterial.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMatrixTransform.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/VertexInfluence.o
[100%] Linking CXX shared library ../../lib/libosgAnimation.so
[100%] Built target osgAnimation


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 519
Location: France

PostPosted: Sat Jun 25, 2016 5:09 pm    Post subject:
Re: osganimation upgrade
Reply with quote

I just merge and it seams you don't use the last zipped sended
I haven't any warnings
As I previously wrote , I have corrected Coverity warnings and adapt examples to new MorphGeometry design
I reattach the zip

and here's the git diff to see changes with master
https://github.com/mp3butcher/OpenSceneGraph/commit/7c4218cc588c2eeb5e83afb1bda77320b26e3e20

robertosfield wrote:
Hi Julien,

I have done a merge based on the zip file you posted. I've assigned
Cedric as the author as I believe he's the author of the bulk of the
change, but added a not in the explanation that you are the one that
submitted and made fixes. Not ideal but hopefully conveys a bit of
the history of the changes.

During build I'm now see a few warnings, these are ones I probably
fixed in the previous code. There aren't many so I'll see if I can
fix them now and get the fixes checked in. Once we've got things
working cleanly we'll want to push these changes back to Cedric's
repository so we don't diverge too far again.

Robert.

[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformHardware.o
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:
In member function ‘bool
osgAnimation::RigTransformHardware::createPalette(int,
osgAnimation::BoneMap, const VertexIndexToBoneWeightMap&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:82:65:
warning: declaration of ‘it’ shadows a previous local [-Wshadow]
for (VertexInfluenceSet::BoneWeightList::const_iterator it =
boneWeightList.begin(); it != boneWeightList.end(); ++it)
^
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:77:73:
note: shadowed declaration is here
for (VertexInfluenceSet::VertexIndexToBoneWeightMap::const_iterator
it = vertexIndexToBoneWeightMap.begin(); it !=
vertexIndexToBoneWeightMap.end(); ++it)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformSoftware.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Skeleton.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedMatrixElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedQuaternionElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedRotateAxisElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedScaleElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTransform.o
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp: In
copy constructor
‘osgAnimation::StackedTransform::StackedTransform(const
osgAnimation::StackedTransform&, const osg::CopyOp&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp:21:1:
warning: base class ‘class
osg::MixinVector<osg::ref_ptr<osgAnimation::StackedTransformElement>
Quote:
’ should be explicitly initialized in the copy constructor [-Wextra]
StackedTransform::StackedTransform(const StackedTransform& rhs, const
osg::CopyOp& co)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTranslateElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsVisitor.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsHandler.o
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp: In
member function ‘void
osgAnimation::StatsGraph::changeYposition(float)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:93:19:
warning: declaration of ‘_pos’ shadows a member of
‘osgAnimation::StatsGraph’ [-Wshadow]
osg::Vec3 _pos = getMatrix().getTrans();
^
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:103:25:
note: shadowed declaration is here
osg::Vec3 _pos;
^
[ 93%] Building CXX object src/osgAnimation/CMakeFiles/osgAnimation.dir/Target.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/TimelineAnimationManager.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Timeline.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateBone.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMaterial.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMatrixTransform.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/VertexInfluence.o
[100%] Linking CXX shared library ../../lib/libosgAnimation.so
[100%] Built target osgAnimation


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 519
Location: France

PostPosted: Sat Jun 25, 2016 5:20 pm    Post subject:
Re: osganimation upgrade
Reply with quote

Excuse me
after review, you've taken the right archive but forgot MorphGeometry files as well as the associated example
so here the minimum file diff

mp3butcher wrote:
I just merge and it seams you don't use the last zipped sended
I haven't any warnings
As I previously wrote , I have corrected Coverity warnings and adapt examples to new MorphGeometry design
I reattach the zip

and here's the git diff to see changes with master
https://github.com/mp3butcher/OpenSceneGraph/commit/7c4218cc588c2eeb5e83afb1bda77320b26e3e20

robertosfield wrote:
Hi Julien,

I have done a merge based on the zip file you posted. I've assigned
Cedric as the author as I believe he's the author of the bulk of the
change, but added a not in the explanation that you are the one that
submitted and made fixes. Not ideal but hopefully conveys a bit of
the history of the changes.

During build I'm now see a few warnings, these are ones I probably
fixed in the previous code. There aren't many so I'll see if I can
fix them now and get the fixes checked in. Once we've got things
working cleanly we'll want to push these changes back to Cedric's
repository so we don't diverge too far again.

Robert.

[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformHardware.o
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:
In member function ‘bool
osgAnimation::RigTransformHardware::createPalette(int,
osgAnimation::BoneMap, const VertexIndexToBoneWeightMap&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:82:65:
warning: declaration of ‘it’ shadows a previous local [-Wshadow]
for (VertexInfluenceSet::BoneWeightList::const_iterator it =
boneWeightList.begin(); it != boneWeightList.end(); ++it)
^
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:77:73:
note: shadowed declaration is here
for (VertexInfluenceSet::VertexIndexToBoneWeightMap::const_iterator
it = vertexIndexToBoneWeightMap.begin(); it !=
vertexIndexToBoneWeightMap.end(); ++it)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformSoftware.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Skeleton.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedMatrixElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedQuaternionElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedRotateAxisElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedScaleElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTransform.o
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp: In
copy constructor
‘osgAnimation::StackedTransform::StackedTransform(const
osgAnimation::StackedTransform&, const osg::CopyOp&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp:21:1:
warning: base class ‘class
osg::MixinVector<osg::ref_ptr<osgAnimation::StackedTransformElement>
Quote:
’ should be explicitly initialized in the copy constructor [-Wextra]
StackedTransform::StackedTransform(const StackedTransform& rhs, const
osg::CopyOp& co)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTranslateElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsVisitor.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsHandler.o
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp: In
member function ‘void
osgAnimation::StatsGraph::changeYposition(float)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:93:19:
warning: declaration of ‘_pos’ shadows a member of
‘osgAnimation::StatsGraph’ [-Wshadow]
osg::Vec3 _pos = getMatrix().getTrans();
^
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:103:25:
note: shadowed declaration is here
osg::Vec3 _pos;
^
[ 93%] Building CXX object src/osgAnimation/CMakeFiles/osgAnimation.dir/Target.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/TimelineAnimationManager.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Timeline.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateBone.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMaterial.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMatrixTransform.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/VertexInfluence.o
[100%] Linking CXX shared library ../../lib/libosgAnimation.so
[100%] Built target osgAnimation


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12264

PostPosted: Sat Jun 25, 2016 5:29 pm    Post subject:
osganimation upgrade
Reply with quote

HI Julien,

I have now merged your fixes. Please note that I've made warning
fixes and coverity fixes to osgAnimation since merging your changes
earlier. There are also changes that I made a few months back to move
osgAnimation across to using the modern include/osg/Callback classes
rather than the old Drawable::*Callback classes. Now I've merged your
changes it would be appropriate to make sure that your own and
Cedric's are up to date so I don't keep having to spot missing bits
when merging.

W.r.t you not spotting warnings that I'm seeing, I'd guess that it a
compiler difference. I'm currently using:

$ c++ --version
c++ (Ubuntu 5.3.1-14ubuntu2.1) 5.3.1 20160413

I have made a couple of warning fixes in the last hour or so, now
everything is compiling cleanly. Coverity defect count for
osgAnimation should hopefully be pretty close to zero now.

Cheers,
Robert.

On 25 June 2016 at 18:20, Julien Valentin <> wrote:
Quote:
Excuse me
after review, you've taken the right archive but forgot MorphGeometry files as well as the associated example
so here the minimum file diff


mp3butcher wrote:
Quote:
I just merge and it seams you don't use the last zipped sended
I haven't any warnings
As I previously wrote , I have corrected Coverity warnings and adapt examples to new MorphGeometry design
I reattach the zip

and here's the git diff to see changes with master
https://github.com/mp3butcher/OpenSceneGraph/commit/7c4218cc588c2eeb5e83afb1bda77320b26e3e20


robertosfield wrote:
Quote:
Hi Julien,

I have done a merge based on the zip file you posted. I've assigned
Cedric as the author as I believe he's the author of the bulk of the
change, but added a not in the explanation that you are the one that
submitted and made fixes. Not ideal but hopefully conveys a bit of
the history of the changes.

During build I'm now see a few warnings, these are ones I probably
fixed in the previous code. There aren't many so I'll see if I can
fix them now and get the fixes checked in. Once we've got things
working cleanly we'll want to push these changes back to Cedric's
repository so we don't diverge too far again.

Robert.

[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformHardware.o
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:
In member function ‘bool
osgAnimation::RigTransformHardware::createPalette(int,
osgAnimation::BoneMap, const VertexIndexToBoneWeightMap&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:82:65:
warning: declaration of ‘it’ shadows a previous local [-Wshadow]
for (VertexInfluenceSet::BoneWeightList::const_iterator it =
boneWeightList.begin(); it != boneWeightList.end(); ++it)
^
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:77:73:
note: shadowed declaration is here
for (VertexInfluenceSet::VertexIndexToBoneWeightMap::const_iterator
it = vertexIndexToBoneWeightMap.begin(); it !=
vertexIndexToBoneWeightMap.end(); ++it)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformSoftware.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Skeleton.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedMatrixElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedQuaternionElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedRotateAxisElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedScaleElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTransform.o
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp: In
copy constructor
‘osgAnimation::StackedTransform::StackedTransform(const
osgAnimation::StackedTransform&, const osg::CopyOp&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp:21:1:
warning: base class ‘class
osg::MixinVector<osg::ref_ptr<osgAnimation::StackedTransformElement>

Quote:
’ should be explicitly initialized in the copy constructor [-Wextra]

StackedTransform::StackedTransform(const StackedTransform& rhs, const
osg::CopyOp& co)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTranslateElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsVisitor.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsHandler.o
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp: In
member function ‘void
osgAnimation::StatsGraph::changeYposition(float)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:93:19:
warning: declaration of ‘_pos’ shadows a member of
‘osgAnimation::StatsGraph’ [-Wshadow]
osg::Vec3 _pos = getMatrix().getTrans();
^
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:103:25:
note: shadowed declaration is here
osg::Vec3 _pos;
^
[ 93%] Building CXX object src/osgAnimation/CMakeFiles/osgAnimation.dir/Target.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/TimelineAnimationManager.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Timeline.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateBone.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMaterial.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMatrixTransform.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/VertexInfluence.o
[100%] Linking CXX shared library ../../lib/libosgAnimation.so
[100%] Built target osgAnimation
_______________________________________________
osg-submissions mailing list

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

------------------
Post generated by Mail2Forum



------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67817#67817








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 519
Location: France

PostPosted: Sat Jun 25, 2016 5:34 pm    Post subject:
Re: osganimation upgrade
Reply with quote

I noticed that
I wasn't sure wich ones was appropriate, i should have assumed master version had the correct DrawableCullCallback

robertosfield wrote:
HI Julien,

I have now merged your fixes. Please note that I've made warning
fixes and coverity fixes to osgAnimation since merging your changes
earlier. There are also changes that I made a few months back to move
osgAnimation across to using the modern include/osg/Callback classes
rather than the old Drawable::*Callback classes. Now I've merged your
changes it would be appropriate to make sure that your own and
Cedric's are up to date so I don't keep having to spot missing bits
when merging.

W.r.t you not spotting warnings that I'm seeing, I'd guess that it a
compiler difference. I'm currently using:

$ c++ --version
c++ (Ubuntu 5.3.1-14ubuntu2.1) 5.3.1 20160413

I have made a couple of warning fixes in the last hour or so, now
everything is compiling cleanly. Coverity defect count for
osgAnimation should hopefully be pretty close to zero now.

Cheers,
Robert.

On 25 June 2016 at 18:20, Julien Valentin <> wrote:
Quote:
Excuse me
after review, you've taken the right archive but forgot MorphGeometry files as well as the associated example
so here the minimum file diff


mp3butcher wrote:
Quote:
I just merge and it seams you don't use the last zipped sended
I haven't any warnings
As I previously wrote , I have corrected Coverity warnings and adapt examples to new MorphGeometry design
I reattach the zip

and here's the git diff to see changes with master
https://github.com/mp3butcher/OpenSceneGraph/commit/7c4218cc588c2eeb5e83afb1bda77320b26e3e20


robertosfield wrote:
Quote:
Hi Julien,

I have done a merge based on the zip file you posted. I've assigned
Cedric as the author as I believe he's the author of the bulk of the
change, but added a not in the explanation that you are the one that
submitted and made fixes. Not ideal but hopefully conveys a bit of
the history of the changes.

During build I'm now see a few warnings, these are ones I probably
fixed in the previous code. There aren't many so I'll see if I can
fix them now and get the fixes checked in. Once we've got things
working cleanly we'll want to push these changes back to Cedric's
repository so we don't diverge too far again.

Robert.

[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformHardware.o
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:
In member function ‘bool
osgAnimation::RigTransformHardware::createPalette(int,
osgAnimation::BoneMap, const VertexIndexToBoneWeightMap&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:82:65:
warning: declaration of ‘it’ shadows a previous local [-Wshadow]
for (VertexInfluenceSet::BoneWeightList::const_iterator it =
boneWeightList.begin(); it != boneWeightList.end(); ++it)
^
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:77:73:
note: shadowed declaration is here
for (VertexInfluenceSet::VertexIndexToBoneWeightMap::const_iterator
it = vertexIndexToBoneWeightMap.begin(); it !=
vertexIndexToBoneWeightMap.end(); ++it)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformSoftware.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Skeleton.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedMatrixElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedQuaternionElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedRotateAxisElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedScaleElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTransform.o
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp: In
copy constructor
‘osgAnimation::StackedTransform::StackedTransform(const
osgAnimation::StackedTransform&, const osg::CopyOp&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp:21:1:
warning: base class ‘class
osg::MixinVector<osg::ref_ptr<osgAnimation::StackedTransformElement>

Quote:
’ should be explicitly initialized in the copy constructor [-Wextra]

StackedTransform::StackedTransform(const StackedTransform& rhs, const
osg::CopyOp& co)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTranslateElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsVisitor.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsHandler.o
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp: In
member function ‘void
osgAnimation::StatsGraph::changeYposition(float)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:93:19:
warning: declaration of ‘_pos’ shadows a member of
‘osgAnimation::StatsGraph’ [-Wshadow]
osg::Vec3 _pos = getMatrix().getTrans();
^
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:103:25:
note: shadowed declaration is here
osg::Vec3 _pos;
^
[ 93%] Building CXX object src/osgAnimation/CMakeFiles/osgAnimation.dir/Target.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/TimelineAnimationManager.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Timeline.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateBone.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMaterial.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMatrixTransform.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/VertexInfluence.o
[100%] Linking CXX shared library ../../lib/libosgAnimation.so
[100%] Built target osgAnimation
_______________________________________________
osg-submissions mailing list

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

------------------
Post generated by Mail2Forum



------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67817#67817








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 519
Location: France

PostPosted: Sat Jun 25, 2016 6:06 pm    Post subject:
Re: osganimation upgrade
Reply with quote

Hi Robert
I made a second account on github in order to purpose a pullrequest to cedricpinson/osg
https://github.com/cedricpinson/osg/pull/67

mp3butcher wrote:
I noticed that
I wasn't sure wich ones was appropriate, i should have assumed master version had the correct DrawableCullCallback

robertosfield wrote:
HI Julien,

I have now merged your fixes. Please note that I've made warning
fixes and coverity fixes to osgAnimation since merging your changes
earlier. There are also changes that I made a few months back to move
osgAnimation across to using the modern include/osg/Callback classes
rather than the old Drawable::*Callback classes. Now I've merged your
changes it would be appropriate to make sure that your own and
Cedric's are up to date so I don't keep having to spot missing bits
when merging.

W.r.t you not spotting warnings that I'm seeing, I'd guess that it a
compiler difference. I'm currently using:

$ c++ --version
c++ (Ubuntu 5.3.1-14ubuntu2.1) 5.3.1 20160413

I have made a couple of warning fixes in the last hour or so, now
everything is compiling cleanly. Coverity defect count for
osgAnimation should hopefully be pretty close to zero now.

Cheers,
Robert.

On 25 June 2016 at 18:20, Julien Valentin <> wrote:
Quote:
Excuse me
after review, you've taken the right archive but forgot MorphGeometry files as well as the associated example
so here the minimum file diff


mp3butcher wrote:
Quote:
I just merge and it seams you don't use the last zipped sended
I haven't any warnings
As I previously wrote , I have corrected Coverity warnings and adapt examples to new MorphGeometry design
I reattach the zip

and here's the git diff to see changes with master
https://github.com/mp3butcher/OpenSceneGraph/commit/7c4218cc588c2eeb5e83afb1bda77320b26e3e20


robertosfield wrote:
Quote:
Hi Julien,

I have done a merge based on the zip file you posted. I've assigned
Cedric as the author as I believe he's the author of the bulk of the
change, but added a not in the explanation that you are the one that
submitted and made fixes. Not ideal but hopefully conveys a bit of
the history of the changes.

During build I'm now see a few warnings, these are ones I probably
fixed in the previous code. There aren't many so I'll see if I can
fix them now and get the fixes checked in. Once we've got things
working cleanly we'll want to push these changes back to Cedric's
repository so we don't diverge too far again.

Robert.

[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformHardware.o
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:
In member function ‘bool
osgAnimation::RigTransformHardware::createPalette(int,
osgAnimation::BoneMap, const VertexIndexToBoneWeightMap&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:82:65:
warning: declaration of ‘it’ shadows a previous local [-Wshadow]
for (VertexInfluenceSet::BoneWeightList::const_iterator it =
boneWeightList.begin(); it != boneWeightList.end(); ++it)
^
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:77:73:
note: shadowed declaration is here
for (VertexInfluenceSet::VertexIndexToBoneWeightMap::const_iterator
it = vertexIndexToBoneWeightMap.begin(); it !=
vertexIndexToBoneWeightMap.end(); ++it)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformSoftware.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Skeleton.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedMatrixElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedQuaternionElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedRotateAxisElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedScaleElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTransform.o
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp: In
copy constructor
‘osgAnimation::StackedTransform::StackedTransform(const
osgAnimation::StackedTransform&, const osg::CopyOp&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp:21:1:
warning: base class ‘class
osg::MixinVector<osg::ref_ptr<osgAnimation::StackedTransformElement>

Quote:
’ should be explicitly initialized in the copy constructor [-Wextra]

StackedTransform::StackedTransform(const StackedTransform& rhs, const
osg::CopyOp& co)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTranslateElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsVisitor.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsHandler.o
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp: In
member function ‘void
osgAnimation::StatsGraph::changeYposition(float)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:93:19:
warning: declaration of ‘_pos’ shadows a member of
‘osgAnimation::StatsGraph’ [-Wshadow]
osg::Vec3 _pos = getMatrix().getTrans();
^
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:103:25:
note: shadowed declaration is here
osg::Vec3 _pos;
^
[ 93%] Building CXX object src/osgAnimation/CMakeFiles/osgAnimation.dir/Target.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/TimelineAnimationManager.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Timeline.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateBone.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMaterial.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMatrixTransform.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/VertexInfluence.o
[100%] Linking CXX shared library ../../lib/libosgAnimation.so
[100%] Built target osgAnimation
_______________________________________________
osg-submissions mailing list

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

------------------
Post generated by Mail2Forum



------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67817#67817








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 519
Location: France

PostPosted: Sun Jun 26, 2016 10:14 pm    Post subject:
Re: osganimation upgrade
Reply with quote

Hi Robert,
I've made an other pull request without the hacky fix
https://github.com/cedricpinson/osg/pull/68
and close the other

mp3butcher wrote:
Hi Robert
I made a second account on github in order to purpose a pullrequest to cedricpinson/osg
https://github.com/cedricpinson/osg/pull/67

mp3butcher wrote:
I noticed that
I wasn't sure wich ones was appropriate, i should have assumed master version had the correct DrawableCullCallback

robertosfield wrote:
HI Julien,

I have now merged your fixes. Please note that I've made warning
fixes and coverity fixes to osgAnimation since merging your changes
earlier. There are also changes that I made a few months back to move
osgAnimation across to using the modern include/osg/Callback classes
rather than the old Drawable::*Callback classes. Now I've merged your
changes it would be appropriate to make sure that your own and
Cedric's are up to date so I don't keep having to spot missing bits
when merging.

W.r.t you not spotting warnings that I'm seeing, I'd guess that it a
compiler difference. I'm currently using:

$ c++ --version
c++ (Ubuntu 5.3.1-14ubuntu2.1) 5.3.1 20160413

I have made a couple of warning fixes in the last hour or so, now
everything is compiling cleanly. Coverity defect count for
osgAnimation should hopefully be pretty close to zero now.

Cheers,
Robert.

On 25 June 2016 at 18:20, Julien Valentin <> wrote:
Quote:
Excuse me
after review, you've taken the right archive but forgot MorphGeometry files as well as the associated example
so here the minimum file diff


mp3butcher wrote:
Quote:
I just merge and it seams you don't use the last zipped sended
I haven't any warnings
As I previously wrote , I have corrected Coverity warnings and adapt examples to new MorphGeometry design
I reattach the zip

and here's the git diff to see changes with master
https://github.com/mp3butcher/OpenSceneGraph/commit/7c4218cc588c2eeb5e83afb1bda77320b26e3e20


robertosfield wrote:
Quote:
Hi Julien,

I have done a merge based on the zip file you posted. I've assigned
Cedric as the author as I believe he's the author of the bulk of the
change, but added a not in the explanation that you are the one that
submitted and made fixes. Not ideal but hopefully conveys a bit of
the history of the changes.

During build I'm now see a few warnings, these are ones I probably
fixed in the previous code. There aren't many so I'll see if I can
fix them now and get the fixes checked in. Once we've got things
working cleanly we'll want to push these changes back to Cedric's
repository so we don't diverge too far again.

Robert.

[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformHardware.o
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:
In member function ‘bool
osgAnimation::RigTransformHardware::createPalette(int,
osgAnimation::BoneMap, const VertexIndexToBoneWeightMap&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:82:65:
warning: declaration of ‘it’ shadows a previous local [-Wshadow]
for (VertexInfluenceSet::BoneWeightList::const_iterator it =
boneWeightList.begin(); it != boneWeightList.end(); ++it)
^
/home/robert/OpenSceneGraph/src/osgAnimation/RigTransformHardware.cpp:77:73:
note: shadowed declaration is here
for (VertexInfluenceSet::VertexIndexToBoneWeightMap::const_iterator
it = vertexIndexToBoneWeightMap.begin(); it !=
vertexIndexToBoneWeightMap.end(); ++it)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/RigTransformSoftware.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Skeleton.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedMatrixElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedQuaternionElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedRotateAxisElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedScaleElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTransform.o
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp: In
copy constructor
‘osgAnimation::StackedTransform::StackedTransform(const
osgAnimation::StackedTransform&, const osg::CopyOp&)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StackedTransform.cpp:21:1:
warning: base class ‘class
osg::MixinVector<osg::ref_ptr<osgAnimation::StackedTransformElement>

Quote:
’ should be explicitly initialized in the copy constructor [-Wextra]

StackedTransform::StackedTransform(const StackedTransform& rhs, const
osg::CopyOp& co)
^
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StackedTranslateElement.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsVisitor.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/StatsHandler.o
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp: In
member function ‘void
osgAnimation::StatsGraph::changeYposition(float)’:
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:93:19:
warning: declaration of ‘_pos’ shadows a member of
‘osgAnimation::StatsGraph’ [-Wshadow]
osg::Vec3 _pos = getMatrix().getTrans();
^
/home/robert/OpenSceneGraph/src/osgAnimation/StatsHandler.cpp:103:25:
note: shadowed declaration is here
osg::Vec3 _pos;
^
[ 93%] Building CXX object src/osgAnimation/CMakeFiles/osgAnimation.dir/Target.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/TimelineAnimationManager.o
[ 93%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/Timeline.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateBone.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMaterial.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/UpdateMatrixTransform.o
[100%] Building CXX object
src/osgAnimation/CMakeFiles/osgAnimation.dir/VertexInfluence.o
[100%] Linking CXX shared library ../../lib/libosgAnimation.so
[100%] Built target osgAnimation
_______________________________________________
osg-submissions mailing list

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

------------------
Post generated by Mail2Forum



------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67817#67817








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Goto page 1, 2  Next
Page 1 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts osgAnimation depth of Skeleton update sbrkopac General 0 Mon Apr 08, 2019 11:13 pm View latest post
No new posts Win 10 + VS17 + OSG 3.2.3 = Failed to... Paradox Plugins [osgPlugins] 1 Mon Jan 29, 2018 9:57 am View latest post
No new posts New osgAnimation developments now mer... robertosfield General 4 Sat Nov 11, 2017 3:46 pm View latest post
No new posts osganimation branch builds fine (32 b... reedev Submission 3 Sun Oct 29, 2017 9:48 am View latest post
No new posts [osganimation branch] Review, test, c... mp3butcher General 39 Thu Aug 31, 2017 2:08 pm View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP