OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

fix for osganimation::RigGeometry bound computation


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 514
Location: France

PostPosted: Fri Jun 24, 2016 11:39 am    Post subject:
fix for osganimation::RigGeometry bound computation
Reply with quote

Hi,
fix for issue experienced by Paradox
(http://forum.openscenegraph.org/viewtopic.php?t=15933)
Bounds are computed before skeleton matrix has been computed leading to incorrect culling

https://github.com/mp3butcher/OpenSceneGraph/commit/d2304b5d251372f4113884ac177dfcd082ad3598


Thank you!

Cheers,
Julien
Back to top
View user's profile Send private message Visit poster's website
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12216

PostPosted: Fri Jun 24, 2016 12:03 pm    Post subject:
fix for osganimation::RigGeometry bound computation
Reply with quote

Hi Julian,

Thanks for the fix. Should I apply this before merging the general
pull from Cedric's version of osgAnimation?

Also do you know if the callback is called continuously or just on
initialization of the bounding volume? If it's called continuously
then there is a danger that there will be performance overhead.

Robert.


On 24 June 2016 at 12:39, Julien Valentin <> wrote:
Quote:
Hi,
fix for issue experienced by Paradox
(http://forum.openscenegraph.org/viewtopic.php?t=15933)
Bounds are computed before skeleton matrix has been computed leading to incorrect culling

https://github.com/mp3butcher/OpenSceneGraph/commit/d2304b5d251372f4113884ac177dfcd082ad3598


Thank you!

Cheers,
Julien

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67781#67781








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 514
Location: France

PostPosted: Fri Jun 24, 2016 12:16 pm    Post subject:
Re: fix for osganimation::RigGeometry bound computation
Reply with quote

Yes,
Can you wait a bit for the merging of the Cedric version?
I have made fixex for Coverity warning and osgMorphAnimation don't work for example osgmorphaniamtion
...I clean and will post later today..


robertosfield wrote:
Hi Julian,

Thanks for the fix. Should I apply this before merging the general
pull from Cedric's version of osgAnimation?

Also do you know if the callback is called continuously or just on
initialization of the bounding volume? If it's called continuously
then there is a danger that there will be performance overhead.

Robert.


On 24 June 2016 at 12:39, Julien Valentin <> wrote:
Quote:
Hi,
fix for issue experienced by Paradox
(http://forum.openscenegraph.org/viewtopic.php?t=15933)
Bounds are computed before skeleton matrix has been computed leading to incorrect culling

https://github.com/mp3butcher/OpenSceneGraph/commit/d2304b5d251372f4113884ac177dfcd082ad3598


Thank you!

Cheers,
Julien

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67781#67781








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12216

PostPosted: Fri Jun 24, 2016 12:18 pm    Post subject:
fix for osganimation::RigGeometry bound computation
Reply with quote

On 24 June 2016 at 13:16, Julien Valentin <> wrote:
Quote:
Yes,
Can you wait a bit for the merging of the Cedric version?
I have made fixex for Coverity warning and osgMorphAnimation don't work for example osgmorphaniamtion
...I clean and will post later today..

OK. no problem, happy to wait as I have lots of work to get on with.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12216

PostPosted: Sat Jun 25, 2016 5:34 pm    Post subject:
fix for osganimation::RigGeometry bound computation
Reply with quote

Hi Julien,

Just to double check, are the fixes to RigGeometry now checked into OSG master?

Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 514
Location: France

PostPosted: Sat Jun 25, 2016 6:13 pm    Post subject:
Re: fix for osganimation::RigGeometry bound computation
Reply with quote

Yes it is.
I would be great cedric valid them in the pull request...I add a comment on it...

robertosfield wrote:
Hi Julien,

Just to double check, are the fixes to RigGeometry now checked into OSG master?

Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 514
Location: France

PostPosted: Sun Jun 26, 2016 8:46 pm    Post subject:
Re: fix for osganimation::RigGeometry bound computation
Reply with quote

Hi Robert
After few though
The fix is too hacky and should be rollback to the original code
Further the setInitialBound is there in order to take care of such a case


mp3butcher wrote:
Yes it is.
I would be great cedric valid them in the pull request...I add a comment on it...

robertosfield wrote:
Hi Julien,

Just to double check, are the fixes to RigGeometry now checked into OSG master?

Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts render to a texure bound to an FBO an... Julius Ziegler General 4 Tue Apr 10, 2018 6:49 pm View latest post
No new posts Win 10 + VS17 + OSG 3.2.3 = Failed to... Paradox Plugins [osgPlugins] 1 Mon Jan 29, 2018 9:57 am View latest post
No new posts New osgAnimation developments now mer... robertosfield General 4 Sat Nov 11, 2017 3:46 pm View latest post
No new posts osganimation branch builds fine (32 b... reedev Submission 3 Sun Oct 29, 2017 9:48 am View latest post
No new posts [osganimation branch] Review, test, c... mp3butcher General 39 Thu Aug 31, 2017 2:08 pm View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP