OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

OpenThreads Pthread.cpp fails to compile if ALLOW_PRIORITY_SCHEDULING is defined


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
crubel@compro.net
User


Joined: 12 Aug 2010
Posts: 74
Location: Melbourne, FL USA

PostPosted: Tue Nov 29, 2016 9:26 pm    Post subject:
OpenThreads Pthread.cpp fails to compile if ALLOW_PRIORITY_SCHEDULING is defined
Reply with quote

Hi Robert,

Seems there are a couple of compile time issues in
the PThread.cpp file if ALLOW_PRIORITY_SCHEDULING
is defined... I have not actually checked this in some
time and was adding the define again today to check
some of our application code changes.

Plus a few warning messages for some printf statements
in the code that needed a few casts to get no warnings
on compile.

I have attached a corrected file that now compiles cleanly
on 64bit Linux for me. The attached file was modified after
updating from the master branch...

Feel free to modify it as you see fit for the official fix.

...


Thank you!

Cheers,
Curtis
Back to top
View user's profile Send private message
crubel@compro.net
User


Joined: 12 Aug 2010
Posts: 74
Location: Melbourne, FL USA

PostPosted: Thu Dec 01, 2016 7:22 pm    Post subject:
Convert this fix to a PULL request??
Reply with quote

Hi Robert,

Just curious if you would like this converted to a pull request?

I have created a new local branch called PThreadPullRequest
and committed the one file with the fixes.

Just want to be sure its OK to commit this new branch up to the master
branch and then generate the pull request? At least that is
how I think its supposed to be done as I have not done
one yet..

Thank you!

Cheers,
Curtis
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11278

PostPosted: Thu Dec 01, 2016 7:53 pm    Post subject:
OpenThreads Pthread.cpp fails to compile if ALLOW_PRIORITY_SCHEDULING is defined
Reply with quote

Hi Curtis,

It would be worth just trying out a pull request from your commit, I
can see if the use of local branch will have any effect, hopefully
github will sort it out.

I can of course simply use the file you posted. I haven't had time to
review it, there isn't much difference in time for me to use a
straight file or pull request. For trivial changes a PR is probably
the quickest.

Cheers,
Robert.

On 1 December 2016 at 19:22, Curtis Rubel <> wrote:
Quote:
Hi Robert,

Just curious if you would like this converted to a pull request?

I have created a new local branch called PThreadPullRequest
and committed the one file with the fixes.

Just want to be sure its OK to commit this new branch up to the master
branch and then generate the pull request? At least that is
how I think its supposed to be done as I have not done
one yet..

Thank you!

Cheers,
Curtis

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=69572#69572








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
crubel@compro.net
User


Joined: 12 Aug 2010
Posts: 74
Location: Melbourne, FL USA

PostPosted: Thu Dec 01, 2016 9:48 pm    Post subject:
Reply with quote

Hi Robert,

The fist method I am used to do the push of my branch up
to Github is requesting a password, so I guess I am not
doing something correctly.

Next I forked off a copy of the master branch, made my changes
and then created the push request, this seems to have worked OK.
If something is not quite correct let me know and I will do some
more research on this subject as its not something I do much. I
think I have only done this once before a few years back..
...

Thank you!

Cheers,
Curtis
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts Fine grained GL error checking during... robertosfield General 0 Wed Dec 06, 2017 10:33 am View latest post
No new posts OsgText compile issue with the newer ... crubel@compro.net General 6 Wed Nov 15, 2017 7:29 pm View latest post
No new posts Osg 3.4.1 - Tutorial 12 Fails on Mac ... digitorus General 1 Sat Nov 04, 2017 12:32 pm View latest post
No new posts How to pre-compile shaders before act... kornerr General 1 Thu Sep 28, 2017 8:42 pm View latest post
No new posts Compile error with Visual Studio 2017 draccagni General 2 Sat Aug 19, 2017 1:52 pm View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP