OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

WG: CMake Updates for DicomTK


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
zonk
Appreciator


Joined: 23 May 2009
Posts: 621

PostPosted: Fri May 12, 2017 10:46 am    Post subject:
WG: CMake Updates for DicomTK
Reply with quote

Hi Robert,

I did not get feedback on this submission. Will it be in the next release?

Thanks,
Torben


Von: osg-submissions [mailto:] Im Auftrag von Torben Dannhauer
Gesendet: Freitag, 7. April 2017 14:16
An: 'OpenSceneGraph Submissions' <>
Betreff: CMake Updates for DicomTK



Dear Robert,

we had a discussion abbout DCMTK related changes in the CMake system some month ago. I wrote I will come back to it as soon as possbible. Today is „soon“ Wink

For the new 3rdParty package, I modified the DCMTK plugin and the (CMake side) to differentiate between release and debug libraries because VS2017 prohibits linking mixed runtimes.

The appended CmakeLists.txt belongs to the dicom plugin.
Additionally a minor correction in the 3rdParty Script.

Thanks for reviewing and merging,
Torben

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11278

PostPosted: Fri May 12, 2017 10:59 am    Post subject:
WG: CMake Updates for DicomTK
Reply with quote

Hi Torben,

I have been busy with other work through April/May so far so haven't
had time for catching up with submissions. In general I find it
quicker to merge uncontroversial submission from github PR's, I can
still handle them via osg-submissions if required though. I am
currently looking through the osg-submissions back log as the github
PR backlog has been cleared so I should get to this submission today.

Robert.

On 12 May 2017 at 11:41, Torben Dannhauer <> wrote:
Quote:
Hi Robert,



I did not get feedback on this submission. Will it be in the next release?



Thanks,

Torben





Von: osg-submissions
[mailto:] Im Auftrag von
Torben Dannhauer
Gesendet: Freitag, 7. April 2017 14:16
An: 'OpenSceneGraph Submissions' <>
Betreff: CMake Updates for DicomTK



Dear Robert,



we had a discussion abbout DCMTK related changes in the CMake system some
month ago. I wrote I will come back to it as soon as possbible. Today is
„soon“ ;)



For the new 3rdParty package, I modified the DCMTK plugin and the (CMake
side) to differentiate between release and debug libraries because VS2017
prohibits linking mixed runtimes.



The appended CmakeLists.txt belongs to the dicom plugin.

Additionally a minor correction in the 3rdParty Script.



Thanks for reviewing and merging,

Torben












------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
zonk
Appreciator


Joined: 23 May 2009
Posts: 621

PostPosted: Fri May 12, 2017 11:00 am    Post subject:
WG: CMake Updates for DicomTK
Reply with quote

Hi Robert,

thanks for the information, Then I'll sent PRs in the future.

Thanks,
Torben

-----Ursprüngliche Nachricht-----
Von: osg-submissions [mailto:] Im Auftrag von Robert Osfield
Gesendet: Freitag, 12. Mai 2017 12:55
An: OpenSceneGraph Submissions <>
Betreff: Re: WG: CMake Updates for DicomTK

Hi Torben,

I have been busy with other work through April/May so far so haven't had time for catching up with submissions. In general I find it quicker to merge uncontroversial submission from github PR's, I can still handle them via osg-submissions if required though. I am currently looking through the osg-submissions back log as the github PR backlog has been cleared so I should get to this submission today.

Robert.

On 12 May 2017 at 11:41, Torben Dannhauer <> wrote:
Quote:
Hi Robert,



I did not get feedback on this submission. Will it be in the next release?



Thanks,

Torben





Von: osg-submissions
[mailto:] Im Auftrag
von Torben Dannhauer
Gesendet: Freitag, 7. April 2017 14:16
An: 'OpenSceneGraph Submissions'
<>
Betreff: CMake Updates for DicomTK



Dear Robert,



we had a discussion abbout DCMTK related changes in the CMake system
some month ago. I wrote I will come back to it as soon as possbible.
Today is „soon“ ;)



For the new 3rdParty package, I modified the DCMTK plugin and the
(CMake
side) to differentiate between release and debug libraries because
VS2017 prohibits linking mixed runtimes.



The appended CmakeLists.txt belongs to the dicom plugin.

Additionally a minor correction in the 3rdParty Script.



Thanks for reviewing and merging,

Torben









graph.org





------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
zonk
Appreciator


Joined: 23 May 2009
Posts: 621

PostPosted: Mon May 22, 2017 11:30 am    Post subject:
WG: CMake Updates for DicomTK
Reply with quote

Hi Robert,

I sent you a PR in Github for the below changes, so I hope it is easy to merge for you.

Thanks,
Torben

Von: osg-submissions [mailto:] Im Auftrag von Torben Dannhauer
Gesendet: Freitag, 7. April 2017 14:16
An: 'OpenSceneGraph Submissions' <>
Betreff: CMake Updates for DicomTK



Dear Robert,

we had a discussion abbout DCMTK related changes in the CMake system some month ago. I wrote I will come back to it as soon as possbible. Today is „soon“ Wink

For the new 3rdParty package, I modified the DCMTK plugin and the (CMake side) to differentiate between release and debug libraries because VS2017 prohibits linking mixed runtimes.

The appended CmakeLists.txt belongs to the dicom plugin.
Additionally a minor correction in the 3rdParty Script.

Thanks for reviewing and merging,
Torben

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts Fix for cmake modules for plugin exr robertosfield Submission 1 Tue Nov 14, 2017 10:17 am View latest post
No new posts OSG 3.4 and Qt 5 cmake problem. Found... Elias Tarasov General 1 Mon Apr 10, 2017 12:26 pm View latest post
No new posts missed submission? 3rdParty Package -... zonk Submission 6 Fri Apr 07, 2017 10:13 pm View latest post
No new posts CMake Updates for DicomTK zonk Submission 0 Fri Apr 07, 2017 12:19 pm View latest post
No new posts Update to FindCollada.cmake zonk Submission 12 Tue Apr 04, 2017 8:54 pm View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP