OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

Error with InputStream reading osgb files

Goto page 1, 2  Next
 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General
View previous topic :: View next topic  
Author Message
Riccardo Corsi
Guest





PostPosted: Thu Jun 08, 2017 11:20 am    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi all,


I'm getting an error when reading some (pretty big) osgb files and having hard time in finding what's causing the issue. 


I'm creating the files myself with osgDB::writeNodeFile, without any error message when writing them.
The files' contents are only Groups and Geometries with basic data (vertices, normals, stateset).
The files are created and read with the same osg libraries, version 3.5.3.
The error message I receive on the console (even at DEBUG level) is only:


Error reading file sample.osgb: read error (InputStream: Failed to read from stream. At osg::Group )



with no additional details, as it normally happens when file is not well formatted.


Additional info:
- I've spotted the issue for big file (2GB or more), but not always from a given size up. I have some 4GB files working and some 3GB causing the error.
- in some cases, if I create foo.osgb and bar.osgb they are both loaded correctly, but if I create foo+bar.osgb (writing works ok) I get the error when reading it.


Unfortunately I cannot share example files.
I'm looking for some pointers on how to investigate further to find the culprit.


My configuration is:
- osg 3.5.3
- windows 10
- visual studio 2013


Thank you,
Riccardo

------------------
Post generated by Mail2Forum
Back to top
Riccardo Corsi
Guest





PostPosted: Fri Jun 09, 2017 4:27 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi again,


I think I've found what's going on.
Basically the BinaryStreamOperator used to read the osgb format saves the block size currently read with an int - see here - which is not large enough to express very large blocks.


I've patched the code with unsigned int (both when writing and reading block size, always on 4 bytes) and I can now write and read correctly the files that showed the problem.
Of course unsigned int is not large enough for arbitrarily huge blocks, but at least it doubles the current max size.
I'll post a pull request with the patch.


Using a type bigger than 4 bytes would make the current files unreadable, so I don't think it's something that can be changed.
Riccardo




On Thu, Jun 8, 2017 at 1:15 PM, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi all,


I'm getting an error when reading some (pretty big) osgb files and having hard time in finding what's causing the issue. 


I'm creating the files myself with osgDB::writeNodeFile, without any error message when writing them.
The files' contents are only Groups and Geometries with basic data (vertices, normals, stateset).
The files are created and read with the same osg libraries, version 3.5.3.
The error message I receive on the console (even at DEBUG level) is only:


Error reading file sample.osgb: read error (InputStream: Failed to read from stream. At osg::Group )



with no additional details, as it normally happens when file is not well formatted.


Additional info:
- I've spotted the issue for big file (2GB or more), but not always from a given size up. I have some 4GB files working and some 3GB causing the error.
- in some cases, if I create foo.osgb and bar.osgb they are both loaded correctly, but if I create foo+bar.osgb (writing works ok) I get the error when reading it.


Unfortunately I cannot share example files.
I'm looking for some pointers on how to investigate further to find the culprit.


My configuration is:
- osg 3.5.3
- windows 10
- visual studio 2013


Thank you,
Riccardo







------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 10990

PostPosted: Sun Jun 11, 2017 12:10 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Good to hear you've tracked down the problem. We might be able to
version to use of long uints for future rev's of the OSG.

On 9 June 2017 at 17:22, Riccardo Corsi <> wrote:
Quote:
Hi again,

I think I've found what's going on.
Basically the BinaryStreamOperator used to read the osgb format saves the
block size currently read with an int - see here - which is not large enough
to express very large blocks.

I've patched the code with unsigned int (both when writing and reading block
size, always on 4 bytes) and I can now write and read correctly the files
that showed the problem.
Of course unsigned int is not large enough for arbitrarily huge blocks, but
at least it doubles the current max size.
I'll post a pull request with the patch.

Using a type bigger than 4 bytes would make the current files unreadable, so
I don't think it's something that can be changed.
Riccardo


On Thu, Jun 8, 2017 at 1:15 PM, Riccardo Corsi <>
wrote:
Quote:

Hi all,

I'm getting an error when reading some (pretty big) osgb files and having
hard time in finding what's causing the issue.

I'm creating the files myself with osgDB::writeNodeFile, without any error
message when writing them.
The files' contents are only Groups and Geometries with basic data
(vertices, normals, stateset).
The files are created and read with the same osg libraries, version 3.5.3.
The error message I receive on the console (even at DEBUG level) is only:

Error reading file sample.osgb: read error (InputStream: Failed to read
from stream. At osg::Group )

with no additional details, as it normally happens when file is not well
formatted.

Additional info:
- I've spotted the issue for big file (2GB or more), but not always from a
given size up. I have some 4GB files working and some 3GB causing the error.
- in some cases, if I create foo.osgb and bar.osgb they are both loaded
correctly, but if I create foo+bar.osgb (writing works ok) I get the error
when reading it.

Unfortunately I cannot share example files.
I'm looking for some pointers on how to investigate further to find the
culprit.

My configuration is:
- osg 3.5.3
- windows 10
- visual studio 2013

Thank you,
Riccardo








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Riccardo Corsi
Guest





PostPosted: Mon Jun 12, 2017 11:40 am    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi Robert,


from within the BinaryStreamOperator we can get the file version with getInputStream()->getFileVersion()

and decide to read/write the block size on 4 or 8 bytes accordingly. 


For the file version check would you use > 148 (i.e. osg 3.5.6) ?
Riccardo






On Sun, Jun 11, 2017 at 2:05 PM, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Good to hear you've tracked down the problem.  We might be able to
version to use of long uints for future rev's of the OSG.

On 9 June 2017 at 17:22, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi again,

I think I've found what's going on.
Basically the BinaryStreamOperator used to read the osgb format saves the
block size currently read with an int - see here - which is not large enough
to express very large blocks.

I've patched the code with unsigned int (both when writing and reading block
size, always on 4 bytes) and I can now write and read correctly the files
that showed the problem.
Of course unsigned int is not large enough for arbitrarily huge blocks, but
at least it doubles the current max size.
I'll post a pull request with the patch.

Using a type bigger than 4 bytes would make the current files unreadable, so
I don't think it's something that can be changed.
Riccardo


On Thu, Jun 8, 2017 at 1:15 PM, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)>
wrote:
Quote:

Hi all,

I'm getting an error when reading some (pretty big) osgb files and having
hard time in finding what's causing the issue.

I'm creating the files myself with osgDB::writeNodeFile, without any error
message when writing them.
The files' contents are only Groups and Geometries with basic data
(vertices, normals, stateset).
The files are created and read with the same osg libraries, version 3.5.3.
The error message I receive on the console (even at DEBUG level) is only:

Error reading file sample.osgb: read error (InputStream: Failed to read
from stream. At osg::Group )

with no additional details, as it normally happens when file is not well
formatted.

Additional info:
- I've spotted the issue for big file (2GB or more), but not always from a
given size up. I have some 4GB files working and some 3GB causing the error.
- in some cases, if I create foo.osgb and bar.osgb they are both loaded
correctly, but if I create foo+bar.osgb (writing works ok) I get the error
when reading it.

Unfortunately I cannot share example files.
I'm looking for some pointers on how to investigate further to find the
culprit.

My configuration is:
- osg 3.5.3
- windows 10
- visual studio 2013

Thank you,
Riccardo






Quote:
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 10990

PostPosted: Mon Jun 12, 2017 3:54 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi Riccardo,

On 12 June 2017 at 12:35, Riccardo Corsi <> wrote:
Quote:
from within the BinaryStreamOperator we can get the file version with
getInputStream()->getFileVersion()
and decide to read/write the block size on 4 or 8 bytes accordingly.

For the file version check would you use > 148 (i.e. osg 3.5.6) ?

I would bump the SO version number specifically for this addtion, so
bump it to 149 at the same time as merging the change this way we
avoid any chance that there might be problem .osgb's created.

Robert


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Riccardo Corsi
Guest





PostPosted: Wed Jun 14, 2017 4:29 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi Robert,


I've created a pull request.
You can modify the SO version number on the PR branch to make it consistent before merging back to the main repo,
I've allowed contributions from maintainers.
Thanks,
Riccardo




On Mon, Jun 12, 2017 at 5:49 PM, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Riccardo,

On 12 June 2017 at 12:35, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
from within the BinaryStreamOperator we can get the file version with
getInputStream()->getFileVersion()
and decide to read/write the block size on 4 or 8 bytes accordingly.

For the file version check would you use > 148 (i.e. osg 3.5.6) ?

I would bump the SO version number specifically for this addtion, so
bump it to 149 at the same time as merging the change this way we
avoid any chance that there might be problem .osgb's created.

Robert
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org




------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 10990

PostPosted: Wed Jun 14, 2017 6:37 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Thanks Riccardo. I'm just heading offline for the evening so will
have a look tomorrow.

On 14 June 2017 at 17:23, Riccardo Corsi <> wrote:
Quote:
Hi Robert,

I've created a pull request.
You can modify the SO version number on the PR branch to make it consistent
before merging back to the main repo,
I've allowed contributions from maintainers.
Thanks,
Riccardo


On Mon, Jun 12, 2017 at 5:49 PM, Robert Osfield <>
wrote:
Quote:

Hi Riccardo,

On 12 June 2017 at 12:35, Riccardo Corsi <>
wrote:
Quote:
from within the BinaryStreamOperator we can get the file version with
getInputStream()->getFileVersion()
and decide to read/write the block size on 4 or 8 bytes accordingly.

For the file version check would you use > 148 (i.e. osg 3.5.6) ?

I would bump the SO version number specifically for this addtion, so
bump it to 149 at the same time as merging the change this way we
avoid any chance that there might be problem .osgb's created.

Robert








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Riccardo Corsi
Guest





PostPosted: Wed Jul 12, 2017 9:30 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi Robert,


I've eventually tested the submission on my project and everything works as expected.
Big files are now written and read correctly. 
Thank you,
Riccardo.


On Mon, Jun 19, 2017 at 6:44 PM, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert, 
this week I'm out of office, I'll give it a test as soon as I come back. 
Cheers, 
Riccardo



On Jun 19, 2017 6:03 PM, "Robert Osfield" < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
HI Riccardo,

On 14 June 2017 at 19:32, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Thanks Riccardo.  I'm just heading offline for the evening so will
have a look tomorrow.

I finally got the chance to do a review and merge your PR.  I made a
couple of further commits, first changing the long long to uint64,
then added an if (version) check to the writing to mirror what you
added to the reading, to leave the door open to eventually allowing us
to write files that are compatible with older OSG versions, finally I
bumped the version number up to 149 to enable the feature.  All these
changes are now checked into git master.

I have tested by writing a .osgb file prior to bumping the version
number, then the same model after bumping the version number.  Both
versions load just fine with the recent file just a little larger
indicating the 64bit sizes are being written and read correctly Smile

Could you test things out to confirm everything works at your end.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org






------------------
Post generated by Mail2Forum
Back to top
Riccardo Corsi
Guest





PostPosted: Wed Jul 12, 2017 9:30 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi Robert,


I've eventually tested the submission on my project and everything works as expected.
Big files are now written and read correctly. 
Thank you,
Riccardo.


On Mon, Jun 19, 2017 at 6:44 PM, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert, 
this week I'm out of office, I'll give it a test as soon as I come back. 
Cheers, 
Riccardo



On Jun 19, 2017 6:03 PM, "Robert Osfield" < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
HI Riccardo,

On 14 June 2017 at 19:32, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Thanks Riccardo.  I'm just heading offline for the evening so will
have a look tomorrow.

I finally got the chance to do a review and merge your PR.  I made a
couple of further commits, first changing the long long to uint64,
then added an if (version) check to the writing to mirror what you
added to the reading, to leave the door open to eventually allowing us
to write files that are compatible with older OSG versions, finally I
bumped the version number up to 149 to enable the feature.  All these
changes are now checked into git master.

I have tested by writing a .osgb file prior to bumping the version
number, then the same model after bumping the version number.  Both
versions load just fine with the recent file just a little larger
indicating the 64bit sizes are being written and read correctly Smile

Could you test things out to confirm everything works at your end.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org






------------------
Post generated by Mail2Forum
Back to top
Riccardo Corsi
Guest





PostPosted: Wed Jul 12, 2017 9:30 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi Robert,


I've eventually tested the submission on my project and everything works as expected.
Big files are now written and read correctly. 
Thank you,
Riccardo.


On Mon, Jun 19, 2017 at 6:44 PM, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert, 
this week I'm out of office, I'll give it a test as soon as I come back. 
Cheers, 
Riccardo



On Jun 19, 2017 6:03 PM, "Robert Osfield" < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
HI Riccardo,

On 14 June 2017 at 19:32, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Thanks Riccardo.  I'm just heading offline for the evening so will
have a look tomorrow.

I finally got the chance to do a review and merge your PR.  I made a
couple of further commits, first changing the long long to uint64,
then added an if (version) check to the writing to mirror what you
added to the reading, to leave the door open to eventually allowing us
to write files that are compatible with older OSG versions, finally I
bumped the version number up to 149 to enable the feature.  All these
changes are now checked into git master.

I have tested by writing a .osgb file prior to bumping the version
number, then the same model after bumping the version number.  Both
versions load just fine with the recent file just a little larger
indicating the 64bit sizes are being written and read correctly Smile

Could you test things out to confirm everything works at your end.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org






------------------
Post generated by Mail2Forum
Back to top
Riccardo Corsi
Guest





PostPosted: Wed Jul 12, 2017 9:30 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi Robert,


I've eventually tested the submission on my project and everything works as expected.
Big files are now written and read correctly. 
Thank you,
Riccardo.


On Mon, Jun 19, 2017 at 6:44 PM, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert, 
this week I'm out of office, I'll give it a test as soon as I come back. 
Cheers, 
Riccardo



On Jun 19, 2017 6:03 PM, "Robert Osfield" < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
HI Riccardo,

On 14 June 2017 at 19:32, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Thanks Riccardo.  I'm just heading offline for the evening so will
have a look tomorrow.

I finally got the chance to do a review and merge your PR.  I made a
couple of further commits, first changing the long long to uint64,
then added an if (version) check to the writing to mirror what you
added to the reading, to leave the door open to eventually allowing us
to write files that are compatible with older OSG versions, finally I
bumped the version number up to 149 to enable the feature.  All these
changes are now checked into git master.

I have tested by writing a .osgb file prior to bumping the version
number, then the same model after bumping the version number.  Both
versions load just fine with the recent file just a little larger
indicating the 64bit sizes are being written and read correctly Smile

Could you test things out to confirm everything works at your end.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org






------------------
Post generated by Mail2Forum
Back to top
Riccardo Corsi
Guest





PostPosted: Wed Jul 12, 2017 9:30 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi Robert,


I've eventually tested the submission on my project and everything works as expected.
Big files are now written and read correctly. 
Thank you,
Riccardo.


On Mon, Jun 19, 2017 at 6:44 PM, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert, 
this week I'm out of office, I'll give it a test as soon as I come back. 
Cheers, 
Riccardo



On Jun 19, 2017 6:03 PM, "Robert Osfield" < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
HI Riccardo,

On 14 June 2017 at 19:32, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Thanks Riccardo.  I'm just heading offline for the evening so will
have a look tomorrow.

I finally got the chance to do a review and merge your PR.  I made a
couple of further commits, first changing the long long to uint64,
then added an if (version) check to the writing to mirror what you
added to the reading, to leave the door open to eventually allowing us
to write files that are compatible with older OSG versions, finally I
bumped the version number up to 149 to enable the feature.  All these
changes are now checked into git master.

I have tested by writing a .osgb file prior to bumping the version
number, then the same model after bumping the version number.  Both
versions load just fine with the recent file just a little larger
indicating the 64bit sizes are being written and read correctly Smile

Could you test things out to confirm everything works at your end.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org






------------------
Post generated by Mail2Forum
Back to top
Riccardo Corsi
Guest





PostPosted: Wed Jul 12, 2017 9:30 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi Robert,


I've eventually tested the submission on my project and everything works as expected.
Big files are now written and read correctly. 
Thank you,
Riccardo.


On Mon, Jun 19, 2017 at 6:44 PM, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert, 
this week I'm out of office, I'll give it a test as soon as I come back. 
Cheers, 
Riccardo



On Jun 19, 2017 6:03 PM, "Robert Osfield" < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
HI Riccardo,

On 14 June 2017 at 19:32, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Thanks Riccardo.  I'm just heading offline for the evening so will
have a look tomorrow.

I finally got the chance to do a review and merge your PR.  I made a
couple of further commits, first changing the long long to uint64,
then added an if (version) check to the writing to mirror what you
added to the reading, to leave the door open to eventually allowing us
to write files that are compatible with older OSG versions, finally I
bumped the version number up to 149 to enable the feature.  All these
changes are now checked into git master.

I have tested by writing a .osgb file prior to bumping the version
number, then the same model after bumping the version number.  Both
versions load just fine with the recent file just a little larger
indicating the 64bit sizes are being written and read correctly Smile

Could you test things out to confirm everything works at your end.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org






------------------
Post generated by Mail2Forum
Back to top
Riccardo Corsi
Guest





PostPosted: Wed Jul 12, 2017 9:30 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi Robert,


I've eventually tested the submission on my project and everything works as expected.
Big files are now written and read correctly. 
Thank you,
Riccardo.


On Mon, Jun 19, 2017 at 6:44 PM, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert, 
this week I'm out of office, I'll give it a test as soon as I come back. 
Cheers, 
Riccardo



On Jun 19, 2017 6:03 PM, "Robert Osfield" < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
HI Riccardo,

On 14 June 2017 at 19:32, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Thanks Riccardo.  I'm just heading offline for the evening so will
have a look tomorrow.

I finally got the chance to do a review and merge your PR.  I made a
couple of further commits, first changing the long long to uint64,
then added an if (version) check to the writing to mirror what you
added to the reading, to leave the door open to eventually allowing us
to write files that are compatible with older OSG versions, finally I
bumped the version number up to 149 to enable the feature.  All these
changes are now checked into git master.

I have tested by writing a .osgb file prior to bumping the version
number, then the same model after bumping the version number.  Both
versions load just fine with the recent file just a little larger
indicating the 64bit sizes are being written and read correctly Smile

Could you test things out to confirm everything works at your end.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org






------------------
Post generated by Mail2Forum
Back to top
Riccardo Corsi
Guest





PostPosted: Wed Jul 12, 2017 9:30 pm    Post subject:
Error with InputStream reading osgb files
Reply with quote

Hi Robert,


I've eventually tested the submission on my project and everything works as expected.
Big files are now written and read correctly. 
Thank you,
Riccardo.


On Mon, Jun 19, 2017 at 6:44 PM, Riccardo Corsi < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert, 
this week I'm out of office, I'll give it a test as soon as I come back. 
Cheers, 
Riccardo



On Jun 19, 2017 6:03 PM, "Robert Osfield" < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
HI Riccardo,

On 14 June 2017 at 19:32, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Thanks Riccardo.  I'm just heading offline for the evening so will
have a look tomorrow.

I finally got the chance to do a review and merge your PR.  I made a
couple of further commits, first changing the long long to uint64,
then added an if (version) check to the writing to mirror what you
added to the reading, to leave the door open to eventually allowing us
to write files that are compatible with older OSG versions, finally I
bumped the version number up to 149 to enable the feature.  All these
changes are now checked into git master.

I have tested by writing a .osgb file prior to bumping the version
number, then the same model after bumping the version number.  Both
versions load just fine with the recent file just a little larger
indicating the 64bit sizes are being written and read correctly Smile

Could you test things out to confirm everything works at your end.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org






------------------
Post generated by Mail2Forum
Back to top
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General All times are GMT
Goto page 1, 2  Next
Page 1 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts Problems with view .FBX files arfaa General 0 Thu Jul 27, 2017 2:48 pm View latest post
No new posts PHPBB ERROR: A Closer Look, and Why Steal General 0 Mon Jul 10, 2017 11:03 am View latest post
No new posts PBuffer causing error when profiling ... jsmitq General 1 Thu Jun 08, 2017 4:24 pm View latest post
No new posts Does osgb file has compatible issues ... saedrna1 General 3 Tue Jun 06, 2017 12:01 pm View latest post
No new posts how to convert osgb files to old version Haojia General 1 Fri Jun 02, 2017 4:35 pm View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP