OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

osg::Program::isFixedFunction() shouldn't return true if fixed function unavailable


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
Mathieu (Mathieu MARACHE)
Appreciator


Joined: 29 Oct 2009
Posts: 104

PostPosted: Mon Aug 28, 2017 8:49 am    Post subject:
osg::Program::isFixedFunction() shouldn't return true if fixed function unavailable
Reply with quote

Hi Robert, 

I ran into an issue where osg::Program::isFixedFunction() was called with openGL CoreProfile used and without fixed function available. I believe that this method shouldn't return true if fixed function is unavailable, even if _shaderList.empty() is true.

I fired a Pull Request showing the modification needed : https://github.com/openscenegraph/OpenSceneGraph/pull/330


HTH--
nǝıɥʇɐƜ

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11152

PostPosted: Mon Aug 28, 2017 9:04 am    Post subject:
osg::Program::isFixedFunction() shouldn't return true if fixed function unavailable
Reply with quote

Thanks Mathieu, PR now merged Smile


On 28 August 2017 at 09:48, Mathieu MARACHE < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert, 

I ran into an issue where osg::Program::isFixedFunction() was called with openGL CoreProfile used and without fixed function available. I believe that this method shouldn't return true if fixed function is unavailable, even if _shaderList.empty() is true.

I fired a Pull Request showing the modification needed : https://github.com/openscenegraph/OpenSceneGraph/pull/330


HTH--
nǝıɥʇɐƜ






_______________________________________________
osg-submissions mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org



------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts CompositeViewer:: checkNeedToDoFrame(... makulis General 0 Sun Sep 24, 2017 9:26 pm View latest post
No new posts Fix for osg::Program crash Colin McDonald Submission 0 Mon Sep 11, 2017 4:43 pm View latest post
No new posts OpenSceneGraph static linking for And... tanshihaj Build system [build] 1 Sun Aug 13, 2017 10:09 pm View latest post
No new posts PHYSFS / VFS - How to make a custom o... Steal General 4 Mon Jul 10, 2017 1:28 pm View latest post
No new posts PHYSFS / VFS - How to make a custom o... Steal General 0 Mon Jul 10, 2017 1:18 pm View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP