OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

[osganimation branch] Review, test, critics

Goto page 1, 2, 3  Next
 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General
View previous topic :: View next topic  
Author Message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 337

PostPosted: Thu Aug 31, 2017 2:08 pm    Post subject:
[osganimation branch] Review, test, critics
Reply with quote

Hi,
A new development branch on refactoring of osgAnimation has been open.
https://github.com/openscenegraph/OpenSceneGraph/tree/osganimation
.
Main features
-Rewriting of animation datapreparation and RigTransforms (have observed few perf enhancement for both loading and software animation)
-Delegates animation data preparation to RigTransform instead of RigGeometry (and so remove the utility of Influence Set)
-add a MorphTargetHardware implementation
-add a bunch of utility functions to deal with VertexInfluenceMap
-various cleanup and bug fixes

I invite you all to test, review and critic new design and features.
I would like to know if some of you experience problem with their model...(I'm not perfect:/ so perhaps I miss something)
Feel free to give your feedback here

Things to know:
-using RigTransformHW, the skinning.vert from OpenSceneGraphData.git must be modified changing
Code:
uniform int nbBonesPerVertex;

to
Code:
uniform uint nbBonesPerVertex;

Perhaps it breaks backward compatibility, please tell me

PS:Further, from a personal point of view I would push refactoring toward backward miscompatibilities with few renaming so tell here if anyone manipulate VertexInfluence in their work.



Thank you!

Cheers,
Julien


Last edited by mp3butcher (Julien Valentin) on Tue Sep 05, 2017 6:55 pm; edited 6 times in total
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 337

PostPosted: Sat Sep 02, 2017 6:36 pm    Post subject:
Re: [osganimation branch] Review, test, critics
Reply with quote

mp3butcher wrote:
Hi,
A new development branch on refactoring of osgAnimation has been open.
https://github.com/openscenegraph/OpenSceneGraph/tree/osganimation
It provides also some new features and bug fixes.
I invite you all to test, review and critic new design and features.
Feel free to give your feedback here

Things to know:
-using RigTransformHW, the skinning.vert in $OSG_FILE_PATH must bemodified changing
Code:
uniform int nbBonesPerVertex;

to
Code:
uniform uint nbBonesPerVertex;

Perhaps it breaks backward compatibility, please tell me

PS:Further, from a personal point of view I would push refactoring toward backward miscompatibilities with few renaming so tell here if anyone manipulate VertexInfluence in their work.



Thank you!

Cheers,
Julien
Back to top
View user's profile Send private message
kornerr
Appreciator


Joined: 01 Oct 2013
Posts: 240

PostPosted: Sat Sep 02, 2017 6:57 pm    Post subject:
[osganimation branch] Review, test, critics
Reply with quote

Hi. It would be nice to know WHAT changed and WHY.
Otherwise the news is kinda funny. Something has been changed and
everyone is welcome to test it. Sounds like a github project just went
live! But so did thousands of others.


On 3 September 2017 at 01:36, Julien Valentin
<> wrote:
Quote:

mp3butcher wrote:
Quote:
Hi,
A new development branch on refactoring of osgAnimation has been open.
https://github.com/openscenegraph/OpenSceneGraph/tree/osganimation
It provides also some new features and bug fixes.
I invite you all to test, review and critic new design and features.
Feel free to give your feedback here

Things to know:
-using RigTransformHW, the skinning.vert in $OSG_FILE_PATH must bemodified changing

Code:
uniform int nbBonesPerVertex;


to

Code:
uniform uint nbBonesPerVertex;


Perhaps it breaks backward compatibility, please tell me

PS:Further, from a personal point of view I would push refactoring toward backward miscompatibilities with few renaming so tell here if anyone manipulate VertexInfluence in their work.



Thank you!

Cheers,
Julien


------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=71611#71611








------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 337

PostPosted: Tue Sep 05, 2017 6:57 pm    Post subject:
Re: [osganimation branch] Review, test, critics
Reply with quote

Up for the ML:
Hi,
A new development branch on refactoring of osgAnimation has been open.
https://github.com/openscenegraph/OpenSceneGraph/tree/osganimation
.
Main features
-Rewriting of animation datapreparation and RigTransforms (have observed few perf enhancement for both loading and software animation)
-Delegates animation data preparation to RigTransform instead of RigGeometry (and so remove the utility of Influence Set)
-add a MorphTargetHardware implementation
-add a bunch of utility functions to deal with VertexInfluenceMap
-various cleanup and bug fixes

I invite you all to test, review and critic new design and features.
I would like to know if some of you experience problem with their model...(I'm not perfect:/ so perhaps I miss something)
Feel free to give your feedback here

Things to know:
-using RigTransformHW, the skinning.vert from OpenSceneGraphData.git must be modified changing
Code:
uniform int nbBonesPerVertex;

to
Code:
uniform uint nbBonesPerVertex;

Perhaps it breaks backward compatibility, please tell me

PS:Further, from a personal point of view I would push refactoring toward backward miscompatibilities with few renaming so tell here if anyone manipulate VertexInfluence in their work.



Thank you!

Cheers,
Julien
Back to top
View user's profile Send private message
reedev
Appreciator


Joined: 25 Feb 2009
Posts: 105

PostPosted: Tue Sep 05, 2017 8:17 pm    Post subject:
[osganimation branch] Review, test, critics
Reply with quote

Hi Julien,

This sounds promising and I will try it out. For my/our understanding: should we be able to use our models from for instance fbx files as-is?

Is there a relation, or will there be, with your MDI work?

Cheers,
Raymond


Verstuurd vanaf mijn iPad

Quote:
Op 5 sep. 2017 om 20:57 heeft Julien Valentin <> het volgende geschreven:

Up for the ML:
Hi,
A new development branch on refactoring of osgAnimation has been open.
https://github.com/openscenegraph/OpenSceneGraph/tree/osganimation
.
Main features
-Rewriting of animation datapreparation and RigTransforms (have observed few perf enhancement for both loading and software animation)
-Delegates animation data preparation to RigTransform instead of RigGeometry (and so remove the utility of Influence Set)
-add a MorphTargetHardware implementation
-add a bunch of utility functions to deal with VertexInfluenceMap
-various cleanup and bug fixes

I invite you all to test, review and critic new design and features.
I would like to know if some of you experience problem with their model...(I'm not perfect:/ so perhaps I miss something)
Feel free to give your feedback here

Things to know:
-using RigTransformHW, the skinning.vert from OpenSceneGraphData.git must be modified changing

Code:
uniform int nbBonesPerVertex;


to

Code:
uniform uint nbBonesPerVertex;


Perhaps it breaks backward compatibility, please tell me

PS:Further, from a personal point of view I would push refactoring toward backward miscompatibilities with few renaming so tell here if anyone manipulate VertexInfluence in their work.



Thank you!

Cheers,
Julien

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=71631#71631









------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 337

PostPosted: Wed Sep 06, 2017 11:24 am    Post subject:
Re: [osganimation branch] Review, test, critics
Reply with quote

Hi Raymond
It's not a revolution:)
There's no real changes in the API so all is expect to run as usual.
so fbx models should work...
And no it's not directly related to MDI: I decided to rewrite it because of a bug I encountered during the dev of a rigeometry simplification tool..

Cheers
reedev wrote:
Hi Julien,

This sounds promising and I will try it out. For my/our understanding: should we be able to use our models from for instance fbx files as-is?

Is there a relation, or will there be, with your MDI work?

Cheers,
Raymond


Verstuurd vanaf mijn iPad

Quote:
Op 5 sep. 2017 om 20:57 heeft Julien Valentin <> het volgende geschreven:

Up for the ML:
Hi,
A new development branch on refactoring of osgAnimation has been open.
https://github.com/openscenegraph/OpenSceneGraph/tree/osganimation
.
Main features
-Rewriting of animation datapreparation and RigTransforms (have observed few perf enhancement for both loading and software animation)
-Delegates animation data preparation to RigTransform instead of RigGeometry (and so remove the utility of Influence Set)
-add a MorphTargetHardware implementation
-add a bunch of utility functions to deal with VertexInfluenceMap
-various cleanup and bug fixes

I invite you all to test, review and critic new design and features.
I would like to know if some of you experience problem with their model...(I'm not perfect:/ so perhaps I miss something)
Feel free to give your feedback here

Things to know:
-using RigTransformHW, the skinning.vert from OpenSceneGraphData.git must be modified changing

Code:
uniform int nbBonesPerVertex;


to

Code:
uniform uint nbBonesPerVertex;


Perhaps it breaks backward compatibility, please tell me

PS:Further, from a personal point of view I would push refactoring toward backward miscompatibilities with few renaming so tell here if anyone manipulate VertexInfluence in their work.



Thank you!

Cheers,
Julien

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=71631#71631









------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Paradox
Appreciator


Joined: 19 Apr 2010
Posts: 129

PostPosted: Thu Sep 14, 2017 9:17 am    Post subject:
Reply with quote

Hi,

I post my request here because osgAnimation related.

There is some examples/possibility to blend two animations? So, make the transition from an animation to another in a smooth way?

Thank you!

Cheers,
Dario
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 337

PostPosted: Thu Sep 14, 2017 11:11 am    Post subject:
Reply with quote

Hi
You should open a new topic for this question...
see
Code:
        void BasicAnimationManager::playAnimation (Animation* pAnimation, int priority = 0, float weight = 1.0);

and test different parameters for priority and weight

Paradox wrote:
Hi,

I post my request here because osgAnimation related.

There is some examples/possibility to blend two animations? So, make the transition from an animation to another in a smooth way?

Thank you!

Cheers,
Dario
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11245

PostPosted: Fri Oct 27, 2017 9:31 am    Post subject:
[osganimation branch] Review, test, critics
Reply with quote

Hi Julien,


What is the status of the osganimation branch?  How close do you feel we are to merging it with master?


I haven't done recent testing on osganimation so don't have any personal observations to chip in, but plan to start looking it with a view to merging with master.


I will also tag a dev release early next week so could possibly merge osganimation for that.


Let me know what the status is so I can start planning my review time.



Cheers,

Robert.

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 337

PostPosted: Fri Oct 27, 2017 1:26 pm    Post subject:
Re: [osganimation branch] Review, test, critics
Reply with quote

Hi Robert
I just did a commit of my experimental useless bone removal method.
So long so far I didn't have any issue with my Blender test models (which represent a "outnumbered sample" of 2 models...one with ik the other with morphtarget)
However, I didn't have any feedback from the community or original maintainer so I can't certificate it 100% bugfree.

From my point of view, I achieve to do whadIwannado with it (MDI crowd) so I'm quite satisfied with the current version and would vote for merging, but it's just one perspective among other ...

Cheers

robertosfield wrote:
Hi Julien,


What is the status of the osganimation branch?  How close do you feel we are to merging it with master?


I haven't done recent testing on osganimation so don't have any personal observations to chip in, but plan to start looking it with a view to merging with master.


I will also tag a dev release early next week so could possibly merge osganimation for that.


Let me know what the status is so I can start planning my review time.



Cheers,

Robert.

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
reedev
Appreciator


Joined: 25 Feb 2009
Posts: 105

PostPosted: Fri Oct 27, 2017 1:44 pm    Post subject:
[osganimation branch] Review, test, critics
Reply with quote

Hi,

FWIW, I tried to build the osganimation branch last week or so with
Visual Studio 2015 and it did not build. I did not have time to look
into the issues but plan to do so asap.

Fyi, I will test with fbx models that I have used successfully with
previous versions of the OSG.

Cheers,
Raymond



On 10/27/2017 3:27 PM, Julien Valentin wrote:
Quote:
Hi Robert
I just did a commit of my experimental useless bone removal method.
So long so far I didn't have any issue with my Blender test models (which represent a "outnumbered sample" of 2 models...one with ik the other with morphtarget)
However, I didn't have any feedback from the community or original maintainer so I can't certificate it 100% bugfree.

From my point of view, I achieve to do whadIwannado with it (MDI crowd) so I'm quite satisfied with the current version and would vote for merging, but it's just one perspective among other ...

Cheers


robertosfield wrote:
Quote:
Hi Julien,


What is the status of the osganimation branch?  How close do you feel we are to merging it with master?


I haven't done recent testing on osganimation so don't have any personal observations to chip in, but plan to start looking it with a view to merging with master.


I will also tag a dev release early next week so could possibly merge osganimation for that.


Let me know what the status is so I can start planning my review time.



Cheers,

Robert.

------------------
Post generated by Mail2Forum

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=72254#72254








---
This email has been checked for viruses by AVG.
http://www.avg.com



------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11245

PostPosted: Fri Oct 27, 2017 1:58 pm    Post subject:
[osganimation branch] Review, test, critics
Reply with quote

Hi Julien,


I have begun my old build tests and have merged master into osganimation branch and checked this in, and then fixed the build problems when compiling with OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION set to OFF.  These changes are all checked into the osganimation branch.


I have begun looking at source code and find the style used a bit awkward and rather different from the rest of the OSG.  I know this will have been partly been down to what it's been like prior to your changes.  I don't find the style used for spacing and indentation helps readability - there are some very odd choices where therearenowspacesbetweenstuff and then      bits     that have     an        odd     segments of     code       where the spacing     is        very      spacious for     no apparent      reason.


I don't know how practical it is for me to go through all osg osgAnimation and headers to fix things.  In the past I have used code beutifiers with varying success.  Perhaps there are modern tools now that can do a better job and worth trying out.  I welcome suggestions on what tools there might be.  What I'd like to arrive at is an osgAnimation headers and source that look like the rest of the OSG.





On 27 October 2017 at 14:27, Julien Valentin < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert
I just did a commit of my experimental useless bone removal method.


There is a conflict on this change that github is reporting:


   https://github.com/openscenegraph/OpenSceneGraph/pull/374


Thoughts?

 
Quote:
So long so far I didn't have any issue with my Blender test models (which represent a "outnumbered sample" of 2 models...one with ik the other with morphtarget)
However, I didn't have any feedback from the community or original maintainer so I can't certificate it 100% bugfree.

Quote:
From my point of view, I achieve to do whadIwannado with it (MDI crowd) so I'm quite satisfied with the current version and would vote for merging, but it's just one perspective among other ...


OK.  So we are now at a point where we need wider testing.



Personally I have not been a serious user of osgAnimation so haven't got much experience or test cases to draw from so need yourself and the rest of the community to hammer it hard.


Robert.

 

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11245

PostPosted: Fri Oct 27, 2017 4:33 pm    Post subject:
[osganimation branch] Review, test, critics
Reply with quote

Hi Julien,

On 27 October 2017 at 14:57, Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
There is a conflict on this change that github is reporting:

   https://github.com/openscenegraph/OpenSceneGraph/pull/374





I have done another review of the changes and in particular the conflict, I've worked out the cause of the conflict and how to merge.  The PR is now merged with the osganimation branch.



Robert.







 

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11245

PostPosted: Fri Oct 27, 2017 4:34 pm    Post subject:
[osganimation branch] Review, test, critics
Reply with quote

Hi Raymond,

On 27 October 2017 at 14:41, Raymond de Vries < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
FWIW, I tried to build the osganimation branch last week or so with Visual Studio 2015 and it did not build. I did not have time to look into the issues but plan to do so asap.


Do you recall what the issues were?  I might be able resolve them before you next check it out.

 
Quote:

Fyi, I will test with fbx models that I have used successfully with previous versions of the OSG.


Thanks that will be really helpful.


Cheers,

Robert.

 


 

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Jordi Torres
Guest





PostPosted: Fri Oct 27, 2017 5:43 pm    Post subject:
[osganimation branch] Review, test, critics
Reply with quote

Hi Julien, Robert et al. 
I'll be out next week, but my plan is to start testing as soon as I get to my computer. 
We have a wide variety of animation models to test, so I hope we can help in this topic. 


Sorry for not being able to add any feedback these days. 


Cheers.




El 27 oct. 2017 6:33 p. m., "Robert Osfield" < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> escribió:
Quote:
Hi Raymond,

On 27 October 2017 at 14:41, Raymond de Vries < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
FWIW, I tried to build the osganimation branch last week or so with Visual Studio 2015 and it did not build. I did not have time to look into the issues but plan to do so asap.



Do you recall what the issues were?  I might be able resolve them before you next check it out.

 
Quote:

Fyi, I will test with fbx models that I have used successfully with previous versions of the OSG.



Thanks that will be really helpful.


Cheers,

Robert.

 


 




_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org



------------------
Post generated by Mail2Forum
Back to top
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General All times are GMT
Goto page 1, 2, 3  Next
Page 1 of 3

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts New osgAnimation developments now mer... robertosfield General 4 Sat Nov 11, 2017 3:46 pm View latest post
No new posts osganimation branch builds fine (32 b... reedev Submission 3 Sun Oct 29, 2017 9:48 am View latest post
No new posts [MDI branch] AZDO SandBox robertosfield General 1 Thu Oct 19, 2017 12:03 pm View latest post
No new posts [osgAnimation::TransformHardware]bug ... mp3butcher General 5 Tue Aug 22, 2017 10:37 pm View latest post
No new posts [MDI branch] AZDO SandBox mp3butcher General 0 Fri Jul 28, 2017 4:53 pm View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP