OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

osganimation branch builds fine (32 bit) with Visual Studio 2015 with a few changes


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
reedev
Appreciator


Joined: 25 Feb 2009
Posts: 110

PostPosted: Sun Oct 29, 2017 9:48 am    Post subject:
osganimation branch builds fine (32 bit) with Visual Studio 2015 with a few changes
Reply with quote

Hi Robert,

I used the osganimation branch and made 1 code change and a few change
to the cmake find module. Please find them attached. I tried out fbx sdk
versions 2016.1.2 and 2018.1.1 and the osg builds fine with both.

I will try out our application later.

Cheers
Raymond




------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
mp3butcher (Julien Valentin)
Appreciator


Joined: 17 Feb 2010
Posts: 372
Location: France

PostPosted: Mon Oct 30, 2017 2:26 pm    Post subject:
Re: osganimation branch builds fine (32 bit) with Visual Studio 2015 with a few changes
Reply with quote

Hi Raymond
The only file we can see is the VertexInfluence.cpp
However all other files have been filtered...
Nevertheless I received (as a private message) your findfbx.cmake (I just did a PR)
In the future, could you try to make a PR for these, it would be easier to review..Thanks

Cheers

reedev wrote:
Hi Robert,

I used the osganimation branch and made 1 code change and a few change
to the cmake find module. Please find them attached. I tried out fbx sdk
versions 2016.1.2 and 2018.1.1 and the osg builds fine with both.

I will try out our application later.

Cheers
Raymond




------------------
Post generated by Mail2Forum


Last edited by mp3butcher (Julien Valentin) on Mon Oct 30, 2017 2:34 pm; edited 1 time in total
Back to top
View user's profile Send private message Visit poster's website
reedev
Appreciator


Joined: 25 Feb 2009
Posts: 110

PostPosted: Mon Oct 30, 2017 2:31 pm    Post subject:
osganimation branch builds fine (32 bit) with Visual Studio 2015 with a few changes
Reply with quote

Hi Julien,

Yes, indeed, that 'const' in VertexInfluence.cpp is indeed the only
change that was needed for building with VS (last time I checked was
before Robert's latest merge changes).

I you want/need I can report the VS error message. Please let me know.

Sure, I can try to make a PR but it takes some extra time from my side,
time that I don't have at the moment (did not learn about git PR yet).
But I do plan to do so.

Cheers
Raymond



On 10/30/2017 3:26 PM, Julien Valentin wrote:
Quote:
Hi Raymond
The only file we can see is the VertexInfluence.cpp (I just did a PR for your little fix)
However all other files have been filtered...
Could you try to make a PR for these, it would be easier to reviewe
Cheers


reedev wrote:
Quote:
Hi Robert,

I used the osganimation branch and made 1 code change and a few change
to the cmake find module. Please find them attached. I tried out fbx sdk
versions 2016.1.2 and 2018.1.1 and the osg builds fine with both.

I will try out our application later.

Cheers
Raymond


_______________________________________________
osg-submissions mailing list

http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

------------------
Post generated by Mail2Forum

------------------
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=72268#72268







---
This email has been checked for viruses by AVG.
http://www.avg.com




------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11311

PostPosted: Mon Oct 30, 2017 2:43 pm    Post subject:
osganimation branch builds fine (32 bit) with Visual Studio 2015 with a few changes
Reply with quote

Hi Guys,

On 30 October 2017 at 14:30, Raymond de Vries < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Julien,

Yes, indeed, that 'const' in VertexInfluence.cpp is indeed the only change that was needed for building with VS (last time I checked was before Robert's latest merge changes).

I you want/need I can report the VS error message. Please let me know.

Sure, I can try to make a PR but it takes some extra time from my side, time that I don't have at the moment (did not learn about git PR yet). But I do plan to do so.http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org



I have merged Raymond's changes already, the VertexInfluence.cpp is checked into osganimation branch.  The FindFBX.cmake change I have merged with master and cherry-picked into the osganimation branch.


Robert.

 

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts Exporting to 3D studio? bbjorn General 2 Fri Dec 08, 2017 9:49 am View latest post
No new posts Fine grained GL error checking during... robertosfield General 0 Wed Dec 06, 2017 10:33 am View latest post
No new posts New osgAnimation developments now mer... robertosfield General 4 Sat Nov 11, 2017 3:46 pm View latest post
No new posts [MDI branch] AZDO SandBox robertosfield General 1 Thu Oct 19, 2017 12:03 pm View latest post
No new posts Automated builds of 3rdParty libraries bbjorn General 67 Thu Sep 14, 2017 8:35 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP