OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

Fix for cmake modules for plugin exr


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12131

PostPosted: Tue Nov 14, 2017 10:17 am    Post subject:
Fix for cmake modules for plugin exr
Reply with quote

Hi Raymond.


I'm just doing a review, one little change I'm a bit surprised by is the following addition to OpenSceneGraph/src/osgPlugins/exr/CMakeLists.txt:


INCLUDE_DIRECTORIES( ${ILMBASE_INCLUDE_DIR}/OpenEXR )


I get idea that you need to provide another include for a separate ilmbase include, but surprised bu the OpenEXR suffix.  I'm not yet familiar with ilmbase headers, is that they contain OpenEXR subdirectories?



Thanks for any clarification,

Robert.






On 14 November 2017 at 06:54, Raymond de Vries | Orphiction BV < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert,

Please find attached fixes for configuring and building the osgPlugin exr with Visual Studio and using out-of-the-box builds of ilmbase and openexr, i.e. without manual/extra config for using these 2 libs with the OSG.

Previously, the assumption was made that ilmbase and openexr were installed in a common directory and hence the header files and libs were both found in that common directory. That is not consistent with other libs and this submission makes it consistent and therefore the OSG configures out of the box. I made this work for ilmbase-2.1.0.tar.gz / openexr-2.1.0.tar.gz and ilmbase-2.2.0.tar.gz / openexr-2.2.0.tar.gz

Btw1 Findilmbase.cmake is new
Btw2 I tested only with Visual Studio and I guess you can quickly test it on Linux Wink

Cheers, thanks,
Raymond


--




------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12131

PostPosted: Tue Nov 14, 2017 11:14 am    Post subject:
Fix for cmake modules for plugin exr
Reply with quote

Thanks Raymond, changes merged and submitted to OSG master.


On 14 November 2017 at 06:54, Raymond de Vries | Orphiction BV < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert,

Please find attached fixes for configuring and building the osgPlugin exr with Visual Studio and using out-of-the-box builds of ilmbase and openexr, i.e. without manual/extra config for using these 2 libs with the OSG.

Previously, the assumption was made that ilmbase and openexr were installed in a common directory and hence the header files and libs were both found in that common directory. That is not consistent with other libs and this submission makes it consistent and therefore the OSG configures out of the box. I made this work for ilmbase-2.1.0.tar.gz / openexr-2.1.0.tar.gz and ilmbase-2.2.0.tar.gz / openexr-2.2.0.tar.gz

Btw1 Findilmbase.cmake is new
Btw2 I tested only with Visual Studio and I guess you can quickly test it on Linux Wink

Cheers, thanks,
Raymond


--




------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts osg3.6.3 plugin issues jaisingla Plugins [osgPlugins] 1 Thu Oct 18, 2018 6:35 am View latest post
No new posts building the fbx plugin Tare Plugins [osgPlugins] 2 Wed Oct 10, 2018 3:04 pm View latest post
No new posts TIFF plugin reader does not handle im... Eric Sokolowsky Submission 0 Sat Sep 29, 2018 2:30 am View latest post
No new posts Enable Qt5Widgets_DIR into cmake (GUI) Andrea74 General 2 Wed Sep 05, 2018 7:40 am View latest post
No new posts decent font without free type plugin OmegaDoom General 0 Mon Jun 25, 2018 12:12 pm View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP