OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

OSG-3.6 breaking changes to GLES2 buffered objects


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General
View previous topic :: View next topic  
Author Message
kornerr
Appreciator


Joined: 01 Oct 2013
Posts: 273

PostPosted: Fri Mar 23, 2018 8:48 am    Post subject:
OSG-3.6 breaking changes to GLES2 buffered objects
Reply with quote

Hi.
This is to continue the discussion of PR that broke web (Emscripten)
builds: https://github.com/openscenegraph/OpenSceneGraph/pull/501

The mentioned changes break rendering of the osgemscripten example
(found in OpenSceneGraph/examples/osgemscripten).
I've prepared two builds to depict the difference.
1. Build with the breaking fix:
https://kornerr.github.io/osg-pbo-gles2-fix-builds/versions/fix/osgemscripten.html
2. Build with the breaking fix reverted:
https://kornerr.github.io/osg-pbo-gles2-fix-builds/versions/reverted-fix/osgemscripten.html

The second build simply has the following GLExtension.cpp line:
isBufferObjectSupported = isVBOSupported && isPBOSupported;
replaced with:
isBufferObjectSupported = isVBOSupported;

So the problem is not really in PBO support, but in the fact that
possibly missing PBO support removes buffer object support. This is
wrong. The osgemscripten example uses VBO and this is what WebGL1
requires.

You can build osgemscripten example yourself (README explains how to
do it, it's easy on Linux) and see the errors.
Make sure to use the updated CMakeLists.txt I've attached to this email.



------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12024

PostPosted: Fri Mar 23, 2018 11:58 am    Post subject:
OSG-3.6 breaking changes to GLES2 buffered objects
Reply with quote

Hi Michael,

Thanks for the details. I've started looking into the GLES2 specs,
and buffer object support is there, just one mention of vertex buffer
object and no mentions of pixel buffer objects.

Is sounds like GLExtensions.cpp just needs to be tweaked a bit to
properly enable/disable the correct features.

Robert.

On 23 March 2018 at 08:43, michael kapelko <> wrote:
Quote:
Hi.
This is to continue the discussion of PR that broke web (Emscripten)
builds: https://github.com/openscenegraph/OpenSceneGraph/pull/501

The mentioned changes break rendering of the osgemscripten example
(found in OpenSceneGraph/examples/osgemscripten).
I've prepared two builds to depict the difference.
1. Build with the breaking fix:
https://kornerr.github.io/osg-pbo-gles2-fix-builds/versions/fix/osgemscripten.html
2. Build with the breaking fix reverted:
https://kornerr.github.io/osg-pbo-gles2-fix-builds/versions/reverted-fix/osgemscripten.html

The second build simply has the following GLExtension.cpp line:
isBufferObjectSupported = isVBOSupported && isPBOSupported;
replaced with:
isBufferObjectSupported = isVBOSupported;

So the problem is not really in PBO support, but in the fact that
possibly missing PBO support removes buffer object support. This is
wrong. The osgemscripten example uses VBO and this is what WebGL1
requires.

You can build osgemscripten example yourself (README explains how to
do it, it's easy on Linux) and see the errors.
Make sure to use the updated CMakeLists.txt I've attached to this email.





------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12024

PostPosted: Fri Mar 23, 2018 1:05 pm    Post subject:
OSG-3.6 breaking changes to GLES2 buffered objects
Reply with quote

Hi Michael,

On 23 March 2018 at 11:53, Robert Osfield <> wrote:
Quote:
Is sounds like GLExtensions.cpp just needs to be tweaked a bit to
properly enable/disable the correct features.

I have checked in the follow change to master and the 3.6 branch,
could you let me know if this works fine.

https://github.com/openscenegraph/OpenSceneGraph/commit/b48db74fa3a08143cc9461f585937e1c580d1947

Cheers,
Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
kornerr
Appreciator


Joined: 01 Oct 2013
Posts: 273

PostPosted: Fri Mar 23, 2018 3:22 pm    Post subject:
OSG-3.6 breaking changes to GLES2 buffered objects
Reply with quote

Hi, Robert.
It works fine, thanks!
I've also created a PR to update osgemscripten example's CMakeLists
file to fix build error:
https://github.com/openscenegraph/OpenSceneGraph/pull/503
Web builds should be safe after that :)

On 23 March 2018 at 16:00, Robert Osfield <> wrote:
Quote:
Hi Michael,

On 23 March 2018 at 11:53, Robert Osfield <> wrote:
Quote:
Is sounds like GLExtensions.cpp just needs to be tweaked a bit to
properly enable/disable the correct features.

I have checked in the follow change to master and the 3.6 branch,
could you let me know if this works fine.

https://github.com/openscenegraph/OpenSceneGraph/commit/b48db74fa3a08143cc9461f585937e1c580d1947

Cheers,
Robert.



------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts Draping polygons on existing objects ... hartwigw General 0 Thu Apr 05, 2018 10:35 pm View latest post
No new posts export to wavefront (obj) of line obj... MNicke General 0 Tue Dec 05, 2017 4:18 pm View latest post
No new posts Objects sub-selections arennuit General 2 Mon Sep 04, 2017 10:16 am View latest post
No new posts Travis builds breaking due to timeouts robertosfield General 1 Wed Mar 29, 2017 10:04 am View latest post
No new posts Shadows on "invisible" objects Trajce Nikolov NICK General 2 Tue Mar 28, 2017 7:09 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP