OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

Geometries disappearing at optimization


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General
View previous topic :: View next topic  
Author Message
Andreas Ekstrand
Guest





PostPosted: Mon Apr 02, 2018 12:08 am    Post subject:
Geometries disappearing at optimization
Reply with quote

I'm sending this message again with an attached .osgb file instead of debug-friendly .osg, because of the attachment size:

Hi Robert,

Happy Easter! Smile

Sorry for the late feedback on the performance changes in the MergeGeometryVisitor that I was involved in a while ago. But I discovered a rather serious issue - in the attached example mesh the last geometry (lower-left quadrant) disappears in MergeGeometryVisitor::mergeGroup and I think it's due to it reaching the 10000 vertices maximum. It works in old 3.4 and it's easily reproducible in the 3.6 branch by just running osgviewer with default optimizations, while turning off optimizations will keep the geometry intact.

I haven't dug deep enough to find the detailed cause but the last "left-over" geometry obviously isn't added back. Hopefully you will find the cause quickly since it wasn't too long ago you rewrote parts of this code. If not, please let me know if I can help with further debugging!

Also, I wonder if there shouldn't be a way to control the 10000 maximum from outside Optimizer somehow?

Regards,
Andreas

------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12094

PostPosted: Mon Apr 02, 2018 9:34 am    Post subject:
Geometries disappearing at optimization
Reply with quote

HI Andreas,

Thanks for test model with this I'm able to reproduce the bug. I'm
now investigating this issue and have a workaround that prevent the
4th geometry from going missing but I'm really not happy with is it
doesn't actually fix the root cause of the problem.

Ideally we want geometries sets that when combined exceed the target
number of vertices to be regrouped into batches, each batch under the
limit. We don't want to remove this limit as from my own testing
geometries with too many vertices tend to perform worse than sets of
geometries with a moderate number of vertices.

Robert.

On 2 April 2018 at 01:03, Andreas Ekstrand
<> wrote:
Quote:
I'm sending this message again with an attached .osgb file instead of
debug-friendly .osg, because of the attachment size:

Hi Robert,

Happy Easter! :-)

Sorry for the late feedback on the performance changes in the
MergeGeometryVisitor that I was involved in a while ago. But I discovered a
rather serious issue - in the attached example mesh the last geometry
(lower-left quadrant) disappears in MergeGeometryVisitor::mergeGroup and I
think it's due to it reaching the 10000 vertices maximum. It works in old
3.4 and it's easily reproducible in the 3.6 branch by just running osgviewer
with default optimizations, while turning off optimizations will keep the
geometry intact.

I haven't dug deep enough to find the detailed cause but the last
"left-over" geometry obviously isn't added back. Hopefully you will find the
cause quickly since it wasn't too long ago you rewrote parts of this code.
If not, please let me know if I can help with further debugging!

Also, I wonder if there shouldn't be a way to control the 10000 maximum from
outside Optimizer somehow?

Regards,
Andreas






------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12094

PostPosted: Mon Apr 02, 2018 1:23 pm    Post subject:
Geometries disappearing at optimization
Reply with quote

Hi Andreas,

I have checked in a fix to master and 3.6 branch.

Could you test with your models to make sure we are working fine.

Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Andreas Ekstrand
Guest





PostPosted: Mon Apr 02, 2018 5:01 pm    Post subject:
Geometries disappearing at optimization
Reply with quote

Hi Robert,

Excellent, works like a charm here - thanks for fixing this so quickly.

Regards,
Andreas

On 2018-04-02 15:18, Robert Osfield wrote:

Quote:
Quote:
Hi Andreas,

I have checked in a fix to master and 3.6 branch.

Could you test with your models to make sure we are working fine.

Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org



------------------
Post generated by Mail2Forum
Back to top
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts osgDB::OutputStream write array optim... Farshid Lashkari Submission 0 Thu Sep 20, 2018 11:17 pm View latest post
No new posts Draw two translucent geometries in sp... krikr42 General 8 Fri May 18, 2018 1:42 pm View latest post
No new posts Slow optimization and OpenFlight Andreas Ekstrand General 14 Fri Nov 17, 2017 4:16 pm View latest post
No new posts Polygon offset for line geometries, Z... raymon General 1 Thu Jul 14, 2016 11:05 am View latest post
No new posts optimization to serializers robertosfield Submission 0 Tue May 31, 2016 10:37 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP