OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

CompositeViewer Bug with Scroll Events


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General
View previous topic :: View next topic  
Author Message
Daniel Emminizer, Code...
Guest





PostPosted: Tue Apr 03, 2018 3:21 pm    Post subject:
CompositeViewer Bug with Scroll Events
Reply with quote

Hello,

I've been working on testing the 3.6.0-rc3 OpenSceneGraph in an application that was previously using 3.4.1. I found what I think is a bug with the GUIEventAdapter::SCROLL handling when using a CompositeViewer. I also come with a potential fix.

The symptom I'm seeing is that when I use CompositeViewer, I'm getting a SCROLL event in my GUIEventHandler, one for each view. In 3.4.1 I was only getting it for the view under the mouse, same as clicks and other mouse operations.

Looking at old 3.4.1 CompositeViewer, the SCROLL event is being sent by default to only the focus view.

In the 3.6 CompositeViewer, the SCROLL event defaults to EVENT_FOR_ALL_VIEWS. I think the focused view for SCROLL seems more correct.


I am submitting a PR on the 3.6 branch for this. I'm happy to redo the PR if I messed something up. The PR is at:

https://github.com/openscenegraph/OpenSceneGraph/pull/518


Thanks,

- Dan



------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12094

PostPosted: Wed Apr 04, 2018 8:08 am    Post subject:
CompositeViewer Bug with Scroll Events
Reply with quote

Thanks Daniel, fix merged and will be part of 3.6.0 :-)

On 3 April 2018 at 16:16, Daniel Emminizer, Code 5773
<> wrote:
Quote:
Hello,

I've been working on testing the 3.6.0-rc3 OpenSceneGraph in an application that was previously using 3.4.1. I found what I think is a bug with the GUIEventAdapter::SCROLL handling when using a CompositeViewer. I also come with a potential fix.

The symptom I'm seeing is that when I use CompositeViewer, I'm getting a SCROLL event in my GUIEventHandler, one for each view. In 3.4.1 I was only getting it for the view under the mouse, same as clicks and other mouse operations.

Looking at old 3.4.1 CompositeViewer, the SCROLL event is being sent by default to only the focus view.

In the 3.6 CompositeViewer, the SCROLL event defaults to EVENT_FOR_ALL_VIEWS. I think the focused view for SCROLL seems more correct.


I am submitting a PR on the 3.6 branch for this. I'm happy to redo the PR if I messed something up. The PR is at:

https://github.com/openscenegraph/OpenSceneGraph/pull/518


Thanks,

- Dan




------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts CompositeViewer with multiple view, a... Angel General 3 Tue Aug 28, 2018 1:15 pm View latest post
No new posts raise windows in compositeviewer Meldryt General 0 Mon Jan 08, 2018 2:56 pm View latest post
No new posts viewer events synchronization xdfanfan General 1 Tue Dec 12, 2017 4:00 pm View latest post
No new posts CompositeViewer:: checkNeedToDoFrame(... makulis General 3 Sun Sep 24, 2017 9:26 pm View latest post
No new posts Win32 touch events fix robertosfield Submission 2 Mon Aug 07, 2017 10:43 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP