OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

fix for polar points in EllipsoidModel::convertXYZToLatLongHeight


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12148

PostPosted: Wed Apr 04, 2018 7:59 am    Post subject:
fix for polar points in EllipsoidModel::convertXYZToLatLongHeight
Reply with quote

Hi Frank,

Change look good, now merged with OSG master the the 3.6 branch. For
submissions github based PR's a little more convenient, but either way
works fine for me.

Cheers,
Robert.

On 3 April 2018 at 19:53, Frank Bausch, Code 5773
<> wrote:
Quote:
Hi!



I’ve been working on testing conversions from ECEF to LLA, as implemented by
EllipsoidModel::convertXYZToLatLongHeight in
./include/osg/CoordinateSystemNode.



When testing XYZ/ECEF coordinate values that convert to LLA points with
latitude = 90.0 or latitude = -90.0, the heights calculated by
EllipsoidModel::convertXYZToLatLongHeight have substantial errors. With the
provided change, points at the pole are handled more correctly. This has
been tested against US NGA GoldData.



Attached is a patched version of the file from master, though the code in
question appears unchanged as far back as 3.4.1.



I’m attempting to follow closely your submission guidelines. If you’d prefer
a PR, I’d be happy to submit one.



Thanks,

Frank














------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts Invisible light points Andreas Ekstrand General 10 Fri Aug 04, 2017 11:12 am View latest post
No new posts How to get points lying on a plane cu... srappose General 0 Sat Oct 08, 2016 10:18 am View latest post
No new posts Create animation of growing line betw... Frankenstein General 0 Fri Nov 20, 2015 1:07 pm View latest post
No new posts Change picked points' color ---why c... Yexin General 2 Wed Sep 02, 2015 10:27 am View latest post
No new posts Geometry of Generic 3D Surface from C... ehensens General 9 Mon Aug 17, 2015 1:21 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP