OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

OpenSceneGraph-3.6.0 release candidate 6


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General
View previous topic :: View next topic  
Author Message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11971

PostPosted: Fri Apr 06, 2018 2:06 pm    Post subject:
OpenSceneGraph-3.6.0 release candidate 6
Reply with quote

Hi All,

I have just tagged release candidate 6:

https://github.com/openscenegraph/OpenSceneGraph/tree/OpenSceneGraph-3.6.0-rc6

I'm really hoping this is now and we are good to go. If things are
building and running OK I'll tag 3.6.0 tomorrow. So yet another big
PLEASE test :-)

Let us know about success or failures so we know where we are at for
the release.

Thankyou!
Robert.

--Changes since rc5

Fri, 6 Apr 2018 14:47:54 +0100
Author : Robert Osfield
Updated for rc6

Fri, 6 Apr 2018 14:17:35 +0100
Author : Robert Osfield
Fixed warning

Fri, 6 Apr 2018 14:07:58 +0100
Author : Robert Osfield
Changed TextBase::setAlignment() to use computeGlyphRepresentation();
rather than computePositions(); to address issues seen with calling
Text::setAlignment() after calls to Text::setText()

Fri, 6 Apr 2018 14:06:50 +0100
Author : Robert Osfield
Added osgtext --alignment test to look the effect of calling
Text::setAlignent() before and after the Text::setText().

Thu, 5 Apr 2018 18:00:30 +0100
Author : OpenSceneGraph git repository
Merge pull request #525 from emminizer/fix-windows-exportosgDB: Added
missing extern OSGDB_EXPORT.

Thu, 5 Apr 2018 10:51:24 -0400
Author : Daniel Emminizer
osgDB: Added missing extern OSGDB_EXPORT.

Thu, 5 Apr 2018 14:14:49 +0100
Author : Robert Osfield
Quietened down debug message output for osgText shader setup and
Drawable::createVertexArrayStateImplementation

Thu, 5 Apr 2018 12:35:36 +0100
Author : Robert Osfield
Changed DisplaySettings::setShaderHint(..) messages to INFO

Thu, 5 Apr 2018 12:19:56 +0100
Author : Robert Osfield
Updated ChangeLOG and news

Thu, 5 Apr 2018 11:21:55 +0200
Author : Philippe Renon
mingw: fix compile error in GraphicsWindowWin32.cppcompilation error
was introduced by msvc specific change
see https://github.com/openscenegraph/OpenSceneGraph/commit/bb169979a1054e2fa63a7ea82c9c8bec87e90494


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Daniel Emminizer, Code...
Guest





PostPosted: Fri Apr 06, 2018 4:13 pm    Post subject:
OpenSceneGraph-3.6.0 release candidate 6
Reply with quote

Hi Robert,

I've been testing the RC5 and I have a problem with text. I saw PR # 523 and thought it might be the same problem. It looks quite similar to the issue I'm seeing. I updated to RC6 (includes PR 523) and things look a lot better, but not completely fixed.

I have finally been able to reproduce this in native OSG without any extra libraries. Attached is a .cpp modification of the osgtext example that demonstrates the problem. This is tested on RC6.


The text "Left" is on the left side, and (correctly) shifts position each frame (up and down). This is important, because the position changes every frame. But the bounding box on the Left text (incorrectly) keeps getting bigger and bigger.

The text "Right" is on the right side, and its position is set to the right side of "Left" text, based on Left's bounding box. You'll see it float to the right as the frames redraw. I would expect "Right" to stay in the same place horizontally, but it does not.


The problem seems to be related to:
1) Changing the position of the text to a new position
2) Having a drop shadow


Unfortunately I do not know how to fix this. I can work on it if you want/need, but perhaps you see the problem right away? Please let me know if the attachment osgtext.cpp doesn't come through for some reason.

- Dan


-----Original Message-----
From: osg-users [mailto:] On Behalf Of Robert Osfield
Sent: Friday, April 06, 2018 10:02 AM
To: OpenSceneGraph Users
Subject: OpenSceneGraph-3.6.0 release candidate 6

Hi All,

I have just tagged release candidate 6:

https://github.com/openscenegraph/OpenSceneGraph/tree/OpenSceneGraph-3.6.0-rc6

I'm really hoping this is now and we are good to go. If things are
building and running OK I'll tag 3.6.0 tomorrow. So yet another big
PLEASE test :-)

Let us know about success or failures so we know where we are at for the release.

Thankyou!
Robert.

--Changes since rc5

Fri, 6 Apr 2018 14:47:54 +0100
Author : Robert Osfield
Updated for rc6

Fri, 6 Apr 2018 14:17:35 +0100
Author : Robert Osfield
Fixed warning

Fri, 6 Apr 2018 14:07:58 +0100
Author : Robert Osfield
Changed TextBase::setAlignment() to use computeGlyphRepresentation(); rather than computePositions(); to address issues seen with calling
Text::setAlignment() after calls to Text::setText()

Fri, 6 Apr 2018 14:06:50 +0100
Author : Robert Osfield
Added osgtext --alignment test to look the effect of calling
Text::setAlignent() before and after the Text::setText().

Thu, 5 Apr 2018 18:00:30 +0100
Author : OpenSceneGraph git repository
Merge pull request #525 from emminizer/fix-windows-exportosgDB: Added missing extern OSGDB_EXPORT.

Thu, 5 Apr 2018 10:51:24 -0400
Author : Daniel Emminizer
osgDB: Added missing extern OSGDB_EXPORT.

Thu, 5 Apr 2018 14:14:49 +0100
Author : Robert Osfield
Quietened down debug message output for osgText shader setup and Drawable::createVertexArrayStateImplementation

Thu, 5 Apr 2018 12:35:36 +0100
Author : Robert Osfield
Changed DisplaySettings::setShaderHint(..) messages to INFO

Thu, 5 Apr 2018 12:19:56 +0100
Author : Robert Osfield
Updated ChangeLOG and news

Thu, 5 Apr 2018 11:21:55 +0200
Author : Philippe Renon
mingw: fix compile error in GraphicsWindowWin32.cppcompilation error was introduced by msvc specific change see https://github.com/openscenegraph/OpenSceneGraph/commit/bb169979a1054e2fa63a7ea82c9c8bec87e90494




------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11971

PostPosted: Fri Apr 06, 2018 7:20 pm    Post subject:
OpenSceneGraph-3.6.0 release candidate 6
Reply with quote

Hi Dan,

I was soooo hoping that all would be OK and I could take the whole
evening off... However, It's far better to catch stuff before a
release than after though, so I appreciate your efforts on testing.

I have reproduce the ever expanding bounding box thanks to the you
test program, and a bit of debugging revealed that it's the increase
in _textBB size due to apply margin and the shadow offsets on each
setPosition() call. The only proper fix I could come up with was to
introduce a _textBBWithMargin so that the margin+shadows don't affect
the main _textBB. This change required far more lines of code to be
changed than I'd like to do this close to a release, but I feel it's
worth the risk to solve the problem. Fingers crossed I don't
introduce any regressions with this change.

I have checked in the changes to OSG master the and the
OpenSceneGraph-3.6 branch.

https://github.com/openscenegraph/OpenSceneGraph/commit/6bfca1582efae9606e18883971c95eb734d70058

If this works OK then I'll tag a rc7.

Cheers,
Robert.



On 6 April 2018 at 17:08, Daniel Emminizer, Code 5773
<> wrote:
Quote:
Hi Robert,

I've been testing the RC5 and I have a problem with text. I saw PR # 523 and thought it might be the same problem. It looks quite similar to the issue I'm seeing. I updated to RC6 (includes PR 523) and things look a lot better, but not completely fixed.

I have finally been able to reproduce this in native OSG without any extra libraries. Attached is a .cpp modification of the osgtext example that demonstrates the problem. This is tested on RC6.


The text "Left" is on the left side, and (correctly) shifts position each frame (up and down). This is important, because the position changes every frame. But the bounding box on the Left text (incorrectly) keeps getting bigger and bigger.

The text "Right" is on the right side, and its position is set to the right side of "Left" text, based on Left's bounding box. You'll see it float to the right as the frames redraw. I would expect "Right" to stay in the same place horizontally, but it does not.


The problem seems to be related to:
1) Changing the position of the text to a new position
2) Having a drop shadow


Unfortunately I do not know how to fix this. I can work on it if you want/need, but perhaps you see the problem right away? Please let me know if the attachment osgtext.cpp doesn't come through for some reason.

- Dan


-----Original Message-----
From: osg-users [mailto:] On Behalf Of Robert Osfield
Sent: Friday, April 06, 2018 10:02 AM
To: OpenSceneGraph Users
Subject: OpenSceneGraph-3.6.0 release candidate 6

Hi All,

I have just tagged release candidate 6:

https://github.com/openscenegraph/OpenSceneGraph/tree/OpenSceneGraph-3.6.0-rc6

I'm really hoping this is now and we are good to go. If things are
building and running OK I'll tag 3.6.0 tomorrow. So yet another big
PLEASE test :-)

Let us know about success or failures so we know where we are at for the release.

Thankyou!
Robert.

--Changes since rc5

Fri, 6 Apr 2018 14:47:54 +0100
Author : Robert Osfield
Updated for rc6

Fri, 6 Apr 2018 14:17:35 +0100
Author : Robert Osfield
Fixed warning

Fri, 6 Apr 2018 14:07:58 +0100
Author : Robert Osfield
Changed TextBase::setAlignment() to use computeGlyphRepresentation(); rather than computePositions(); to address issues seen with calling
Text::setAlignment() after calls to Text::setText()

Fri, 6 Apr 2018 14:06:50 +0100
Author : Robert Osfield
Added osgtext --alignment test to look the effect of calling
Text::setAlignent() before and after the Text::setText().

Thu, 5 Apr 2018 18:00:30 +0100
Author : OpenSceneGraph git repository
Merge pull request #525 from emminizer/fix-windows-exportosgDB: Added missing extern OSGDB_EXPORT.

Thu, 5 Apr 2018 10:51:24 -0400
Author : Daniel Emminizer
osgDB: Added missing extern OSGDB_EXPORT.

Thu, 5 Apr 2018 14:14:49 +0100
Author : Robert Osfield
Quietened down debug message output for osgText shader setup and Drawable::createVertexArrayStateImplementation

Thu, 5 Apr 2018 12:35:36 +0100
Author : Robert Osfield
Changed DisplaySettings::setShaderHint(..) messages to INFO

Thu, 5 Apr 2018 12:19:56 +0100
Author : Robert Osfield
Updated ChangeLOG and news

Thu, 5 Apr 2018 11:21:55 +0200
Author : Philippe Renon
mingw: fix compile error in GraphicsWindowWin32.cppcompilation error was introduced by msvc specific change see https://github.com/openscenegraph/OpenSceneGraph/commit/bb169979a1054e2fa63a7ea82c9c8bec87e90494






------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Daniel Emminizer, Code...
Guest





PostPosted: Fri Apr 06, 2018 7:57 pm    Post subject:
OpenSceneGraph-3.6.0 release candidate 6
Reply with quote

Hi Robert,

Thanks again for the support. I pulled your latest with this fix and it fixes my small demo app and the bigger application I'm building too! I'm sorry to drop bugs on you last minute, I only was able to verify it was an OSG issue finally this morning.

I do not think I have any other bugs on the horizon! Looks good from here. Have a good weekend,

- Dan



-----Original Message-----
From: osg-users [mailto:] On Behalf Of Robert Osfield
Sent: Friday, April 06, 2018 3:15 PM
To: OpenSceneGraph Users
Subject: Re: OpenSceneGraph-3.6.0 release candidate 6

Hi Dan,

I was soooo hoping that all would be OK and I could take the whole evening off... However, It's far better to catch stuff before a release than after though, so I appreciate your efforts on testing.

I have reproduce the ever expanding bounding box thanks to the you test program, and a bit of debugging revealed that it's the increase in _textBB size due to apply margin and the shadow offsets on each
setPosition() call. The only proper fix I could come up with was to introduce a _textBBWithMargin so that the margin+shadows don't affect the main _textBB. This change required far more lines of code to be changed than I'd like to do this close to a release, but I feel it's worth the risk to solve the problem. Fingers crossed I don't introduce any regressions with this change.

I have checked in the changes to OSG master the and the
OpenSceneGraph-3.6 branch.

https://github.com/openscenegraph/OpenSceneGraph/commit/6bfca1582efae9606e18883971c95eb734d70058

If this works OK then I'll tag a rc7.

Cheers,
Robert.



On 6 April 2018 at 17:08, Daniel Emminizer, Code 5773 <> wrote:
Quote:
Hi Robert,

I've been testing the RC5 and I have a problem with text. I saw PR # 523 and thought it might be the same problem. It looks quite similar to the issue I'm seeing. I updated to RC6 (includes PR 523) and things look a lot better, but not completely fixed.

I have finally been able to reproduce this in native OSG without any extra libraries. Attached is a .cpp modification of the osgtext example that demonstrates the problem. This is tested on RC6.


The text "Left" is on the left side, and (correctly) shifts position each frame (up and down). This is important, because the position changes every frame. But the bounding box on the Left text (incorrectly) keeps getting bigger and bigger.

The text "Right" is on the right side, and its position is set to the right side of "Left" text, based on Left's bounding box. You'll see it float to the right as the frames redraw. I would expect "Right" to stay in the same place horizontally, but it does not.


The problem seems to be related to:
1) Changing the position of the text to a new position
2) Having a drop shadow


Unfortunately I do not know how to fix this. I can work on it if you want/need, but perhaps you see the problem right away? Please let me know if the attachment osgtext.cpp doesn't come through for some reason.

- Dan


-----Original Message-----
From: osg-users [mailto:] On
Behalf Of Robert Osfield
Sent: Friday, April 06, 2018 10:02 AM
To: OpenSceneGraph Users
Subject: OpenSceneGraph-3.6.0 release candidate 6

Hi All,

I have just tagged release candidate 6:


https://github.com/openscenegraph/OpenSceneGraph/tree/OpenSceneGraph-3
.6.0-rc6

I'm really hoping this is now and we are good to go. If things are
building and running OK I'll tag 3.6.0 tomorrow. So yet another big
PLEASE test :-)

Let us know about success or failures so we know where we are at for the release.

Thankyou!
Robert.

--Changes since rc5

Fri, 6 Apr 2018 14:47:54 +0100
Author : Robert Osfield
Updated for rc6

Fri, 6 Apr 2018 14:17:35 +0100
Author : Robert Osfield
Fixed warning

Fri, 6 Apr 2018 14:07:58 +0100
Author : Robert Osfield
Changed TextBase::setAlignment() to use computeGlyphRepresentation();
rather than computePositions(); to address issues seen with calling
Text::setAlignment() after calls to Text::setText()

Fri, 6 Apr 2018 14:06:50 +0100
Author : Robert Osfield
Added osgtext --alignment test to look the effect of calling
Text::setAlignent() before and after the Text::setText().

Thu, 5 Apr 2018 18:00:30 +0100
Author : OpenSceneGraph git repository Merge pull request #525 from
emminizer/fix-windows-exportosgDB: Added missing extern OSGDB_EXPORT.

Thu, 5 Apr 2018 10:51:24 -0400
Author : Daniel Emminizer
osgDB: Added missing extern OSGDB_EXPORT.

Thu, 5 Apr 2018 14:14:49 +0100
Author : Robert Osfield
Quietened down debug message output for osgText shader setup and
Drawable::createVertexArrayStateImplementation

Thu, 5 Apr 2018 12:35:36 +0100
Author : Robert Osfield
Changed DisplaySettings::setShaderHint(..) messages to INFO

Thu, 5 Apr 2018 12:19:56 +0100
Author : Robert Osfield
Updated ChangeLOG and news

Thu, 5 Apr 2018 11:21:55 +0200
Author : Philippe Renon
mingw: fix compile error in GraphicsWindowWin32.cppcompilation error
was introduced by msvc specific change see
https://github.com/openscenegraph/OpenSceneGraph/commit/bb169979a1054e
2fa63a7ea82c9c8bec87e90494

org


org




------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11971

PostPosted: Sat Apr 07, 2018 5:32 pm    Post subject:
OpenSceneGraph-3.6.0 release candidate 6
Reply with quote

Hi All,

While updating the OpenSceneGraph/NEWS.txt and associated press
release for the 3.6.0 release I spotted an error in the naming of the
osg::ComputeDispatch class. This class wraps up glDispatchCompute so
to be consistent with the rest of the OSG/GL naming convention this
class should be called osg::DispatchCompute. To avoid confusion in
the future I've decided to rename this class. Those small number of
developers using OSG master/3.5.x dev series and that have used the
osg::ComputeDispatch class they will need to rename it in their
applications to get things to compile. Unfortunately any .osgt/.osgb
files that contain ComputeDispatch entries, you'll need to regenerate
these with the new names as I haven't been able to work out how to
retain backwards compatibility.

I hate doing such changes right before a release but I felt being
consistent is important and better to do the rename before many others
start adopting the incorrectly named class.

Fingers crossed there won't be any breakages in cross platform build
with this change.

The latest changes I've mad to the 3.6 branch are wrapped up in the commit:

https://github.com/openscenegraph/OpenSceneGraph/commit/7ab1208c65b4d7fa67cb6031e905d7d67a3b9389

I still plan to tag 3.6.0 today as I'm off on trip tomorrow and won't
have time to do it once I'm away.

Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11971

PostPosted: Sat Apr 07, 2018 6:30 pm    Post subject:
OpenSceneGraph-3.6.0 release candidate 6
Reply with quote

Hi All,

I'm ready, done all the build testing on the platforms I have, run the
standard tests and all is looking mighty fine, quite a relief to be
finally on the verge of tagging our most solid release so far :-)


Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts OpenSceneGraph-3.6.2 released! robertosfield General 0 Fri Jun 29, 2018 10:28 am View latest post
No new posts OpenSceneGraph-3.6.2 release candidate 3 robertosfield General 1 Thu Jun 28, 2018 6:35 am View latest post
No new posts OpenSceneGraph-3.6.2 release candidat... robertosfield General 0 Wed Jun 27, 2018 8:24 am View latest post
No new posts OpenSceneGraph-3.6.2-rc1 tagged, plea... robertosfield General 4 Wed Jun 20, 2018 1:09 pm View latest post
No new posts Please test OpeSceneGraph-3.6 branch ... robertosfield General 0 Mon Jun 18, 2018 6:43 pm View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP