OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

Please test OpenSceneGraph-3.6 branch in prep for 3.6.1

Goto page Previous  1, 2
 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General
View previous topic :: View next topic  
Author Message
Terry Welsh
Guest





PostPosted: Wed Apr 25, 2018 8:39 pm    Post subject:
Please test OpenSceneGraph-3.6 branch in prep for 3.6.1
Reply with quote

Thank you, Dan. That is *exactly* the problem I have with the Intel
graphics driver. This bug affects a driver from September and the new
one I installed last night. I'll test your workaround when I get home
tonight and report on it.

(My AMD driver, on the other hand, is a complete mess. It crashes on
Furmark and pretty much everything else.)

Robert, here is a related suggestion: how about renaming text.vert and
text.frag to something unique? Maybe osgtext_text.frag? When I first
tried 3.6.0 all my text was very broken because I already had a
text.vert and text.frag in my application. It took a while to figure
out that they were being loaded by osgText::Text even though I had
disabled them in my own code.
- Terry

Quote:

Hi Terry,

Hey I might know this one. Thanks for that additional info about your driver. Do you mind retesting with a change?

See references:

- https://devtalk.nvidia.com/default/topic/971330/opengl/bug-report-crash-in-glcompileshader-if-using-pragma/
- https://software.intel.com/en-us/forums/graphics-driver-bug-reporting/topic/623485
- https://github.com/gwaldron/osgearth/issues/1017
- https://github.com/gwaldron/osgearth/pull/1106
- https://github.com/gwaldron/osgearth/pull/1100

There are some older intel drivers that crash on shaders that include pragmas with too many "arguments". The spec says that pragmas should be ignored. But testing demonstrates severe problems with several intel drivers over a few years' period where lines like:

#pragma import_defines( BACKDROP_COLOR, SHADOW, OUTLINE, SIGNED_DISTANCE_FIELD, TEXTURE_DIMENSION, GLYPH_DIMENSION)

... could cause a failure. Breaking it up into separate lines of no more than 2 arguments each works.

We found that the magic number for drivers is 3 -- once you get over 3 parameters, it starts to break (depending on driver version). Could you try to edit your text.frag file to change:

#pragma import_defines( BACKDROP_COLOR, SHADOW, OUTLINE, SIGNED_DISTANCE_FIELD, TEXTURE_DIMENSION, GLYPH_DIMENSION)

To:

#pragma import_defines( BACKDROP_COLOR, SHADOW, OUTLINE)
#pragma import_defines( SIGNED_DISTANCE_FIELD, TEXTURE_DIMENSION, GLYPH_DIMENSION)

This breaks it into 2 lines of 3 params each. If it's the same bug that we encountered, this might fixyour problem.

Robert, I haven't reported this because we haven't explicitly ran into this same problem with 3.6 and text shaders yet, because we haven't run on those drivers. Newer drivers do fix the issue.

- Dan



------------------
Post generated by Mail2Forum
Back to top
Terry Welsh
Guest





PostPosted: Thu Apr 26, 2018 2:54 am    Post subject:
Please test OpenSceneGraph-3.6 branch in prep for 3.6.1
Reply with quote

Confirmed. Splitting the pragma line in half fixes the problem on
Intel graphics:

#pragma import_defines( BACKDROP_COLOR, SHADOW, OUTLINE)
#pragma import_defines( SIGNED_DISTANCE_FIELD, TEXTURE_DIMENSION,
GLYPH_DIMENSION)

I'm running on Win7 64-bit, Intel HD Graphics 4000, driver version
10.18.10.4885.
- Terry

On Wed, Apr 25, 2018 at 1:38 PM, Terry Welsh <> wrote:
Quote:
Thank you, Dan. That is *exactly* the problem I have with the Intel
graphics driver. This bug affects a driver from September and the new
one I installed last night. I'll test your workaround when I get home
tonight and report on it.

(My AMD driver, on the other hand, is a complete mess. It crashes on
Furmark and pretty much everything else.)

Robert, here is a related suggestion: how about renaming text.vert and
text.frag to something unique? Maybe osgtext_text.frag? When I first
tried 3.6.0 all my text was very broken because I already had a
text.vert and text.frag in my application. It took a while to figure
out that they were being loaded by osgText::Text even though I had
disabled them in my own code.
- Terry

Quote:

Hi Terry,

Hey I might know this one. Thanks for that additional info about your driver. Do you mind retesting with a change?

See references:

- https://devtalk.nvidia.com/default/topic/971330/opengl/bug-report-crash-in-glcompileshader-if-using-pragma/
- https://software.intel.com/en-us/forums/graphics-driver-bug-reporting/topic/623485
- https://github.com/gwaldron/osgearth/issues/1017
- https://github.com/gwaldron/osgearth/pull/1106
- https://github.com/gwaldron/osgearth/pull/1100

There are some older intel drivers that crash on shaders that include pragmas with too many "arguments". The spec says that pragmas should be ignored. But testing demonstrates severe problems with several intel drivers over a few years' period where lines like:

#pragma import_defines( BACKDROP_COLOR, SHADOW, OUTLINE, SIGNED_DISTANCE_FIELD, TEXTURE_DIMENSION, GLYPH_DIMENSION)

... could cause a failure. Breaking it up into separate lines of no more than 2 arguments each works.

We found that the magic number for drivers is 3 -- once you get over 3 parameters, it starts to break (depending on driver version). Could you try to edit your text.frag file to change:

#pragma import_defines( BACKDROP_COLOR, SHADOW, OUTLINE, SIGNED_DISTANCE_FIELD, TEXTURE_DIMENSION, GLYPH_DIMENSION)

To:

#pragma import_defines( BACKDROP_COLOR, SHADOW, OUTLINE)
#pragma import_defines( SIGNED_DISTANCE_FIELD, TEXTURE_DIMENSION, GLYPH_DIMENSION)

This breaks it into 2 lines of 3 params each. If it's the same bug that we encountered, this might fixyour problem.

Robert, I haven't reported this because we haven't explicitly ran into this same problem with 3.6 and text shaders yet, because we haven't run on those drivers. Newer drivers do fix the issue.

- Dan



------------------
Post generated by Mail2Forum
Back to top
Daniel Emminizer, Code...
Guest





PostPosted: Thu Apr 26, 2018 10:11 am    Post subject:
Please test OpenSceneGraph-3.6 branch in prep for 3.6.1
Reply with quote

Hi Robert,

Sorry, was already out for the day yesterday by the time this was sent. It looks like you already took care of it.

I will be rebuilding the 3.6.1 RC then I'll coordinate with my colleague who has the Intel machine when he's in for testing confirmation. Will report back in a few hours when he's in.

- Dan


-----Original Message-----
From: osg-users [mailto:] On Behalf Of Robert Osfield
Sent: Wednesday, April 25, 2018 2:55 PM
To: OpenSceneGraph Users
Subject: Re: Please test OpenSceneGraph-3.6 branch in prep for 3.6.1

Hi Dan,

Could you get teh text.frag working on your machines and then a PR for
OpenSceneGraph-Data for it. I can then run osg2cpp on it to update
the OSG version.

Thanks,
Robert



------------------
Post generated by Mail2Forum
Back to top
Daniel Emminizer, Code...
Guest





PostPosted: Thu Apr 26, 2018 11:35 am    Post subject:
Please test OpenSceneGraph-3.6 branch in prep for 3.6.1
Reply with quote

Hi Robert,

I was able to test on the Intel machine a few minutes ago. It indeed did work with your updated shader. It also crashed as expected when I backed out your pragma change. So your change works. All good from this side.

I'll pass along word if I run into any problems in the new release candidate.

Thanks,

- Dan


-----Original Message-----
From: Daniel Emminizer, Code 5773
Sent: Thursday, April 26, 2018 6:11 AM
To: OpenSceneGraph Users
Subject: RE: Please test OpenSceneGraph-3.6 branch in prep for 3.6.1

Hi Robert,

Sorry, was already out for the day yesterday by the time this was sent. It looks like you already took care of it.

I will be rebuilding the 3.6.1 RC then I'll coordinate with my colleague who has the Intel machine when he's in for testing confirmation. Will report back in a few hours when he's in.

- Dan


-----Original Message-----
From: osg-users [mailto:] On Behalf Of Robert Osfield
Sent: Wednesday, April 25, 2018 2:55 PM
To: OpenSceneGraph Users
Subject: Re: Please test OpenSceneGraph-3.6 branch in prep for 3.6.1

Hi Dan,

Could you get teh text.frag working on your machines and then a PR for
OpenSceneGraph-Data for it. I can then run osg2cpp on it to update
the OSG version.

Thanks,
Robert



------------------
Post generated by Mail2Forum
Back to top
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General All times are GMT
Goto page Previous  1, 2
Page 2 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts OpenSceneGraph-3.6.1 release candidate 7 robertosfield General 30 Fri May 25, 2018 11:30 am View latest post
No new posts OpenSceneGraph-3.6.1 release candidat... robertosfield General 4 Tue May 22, 2018 6:41 am View latest post
No new posts OpenSceneGraph-3.6.1 release candidat... robertosfield General 119 Sun May 20, 2018 12:48 pm View latest post
No new posts Please test OpenSceneGraph-3.6 robertosfield General 6 Fri May 18, 2018 2:49 pm View latest post
No new posts OpenSceneGraph-3.6.1-rc4 tagged robertosfield General 0 Sat May 12, 2018 11:52 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP