OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

OpenSceneGraph-3.6.1 release candidate 3 tagged

Goto page Previous  1, 2
 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General
View previous topic :: View next topic  
Author Message
Alberto Luaces
Guest





PostPosted: Fri May 11, 2018 10:47 am    Post subject:
OpenSceneGraph-3.6.1 release candidate 3 tagged
Reply with quote

Robert Osfield writes:

Quote:
Hi Alberto,

Thanks for the minimal crashing program. The crash wasn't straight
forward to pinpoint the cause but eventually I traced it back to the
the ObjectCache taking a ref_ptr<Options> when search for entries in
the ObjectCache. To avoid this I wrote a ObjectCache::find(..) method
that doesn't create a temporary ref_ptr<> to the Options being passed
in. This fix is checked in the OpenSceneGaprh-3.6 branch and master.

https://github.com/openscenegraph/OpenSceneGraph/commit/fcde92ad89af44a9724a5ebf9fbfdf59b6e41d68


Thank you very much, Robert! I confirm it is also working for here.

Quote:

As a general comment use of C++11's auto is something you should be
careful about using, easy to hide the face that you just have C
pointers and associated memory leaks.

Oh, yes, thanks as well for the advice. Nowadays I even don't trust
myself anymore, so I just rely on what Valgrind is saying to me :-)

--
Alberto



------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12024

PostPosted: Sat May 12, 2018 10:50 am    Post subject:
OpenSceneGraph-3.6.1 release candidate 3 tagged
Reply with quote

Hi Dan,

I have had another look at this bug and using your text example I do
see some odd behaviour so I've rewritten TextBase::computeMatrix() so
use higher level matrix maths that is easier to understand than the
"fast" maths version that unrolled all the the matrix ops but was very
hard to follow. Hard to follow -> Hard to debug...

The new version of the scale maths now works better on your two text
test programs, and osgtext looks to behaving itself too.

https://github.com/openscenegraph/OpenSceneGraph/commit/362e355db28582c839c88ddd6ede1d1ae1d74237

Now that this is fixed I will create another 3.6.1-rc, hopefully this
next one will be the last and we can finally get 3.6.1 out the door.

Robert.


On 10 May 2018 at 17:33, Daniel Emminizer, Code 5773
<> wrote:
Quote:
Hi Robert,

I got my build on Linux done. I test both GLCORE configuration and non-GLCORE configuration on OpenSceneGraph-3.6.

I am seeing the error in all 3 configurations:

1) Linux Ubuntu 14.04; default OSG 3.6 branch build (GL compatibility mode); NVidia Quadro K1000M GL 4.5, 384.11 driver; Ubuntu 14.04

2) Linux Ubuntu 14.04; GLCORE OSG 3.6 branch build; NVidia Quadro K1000M GL 3.3, 384.11 driver

3) Windows 10; GLCORE OSG 3.6 branch build; NVidia NVS 510, 388.19 driver


Can you just please reconfirm that when you run on OSG 3.6 branch build, and run "./osgtext --size2" (or resize the view to be short), that the text is all readable and you can clearly see "330 000 030 060" in the display with no significant overlap?

Thanks,

- Dan


-----Original Message-----
From: Daniel Emminizer, Code 5773
Sent: Thursday, May 10, 2018 11:42 AM
To: 'OpenSceneGraph Users'
Subject: RE: OpenSceneGraph-3.6.1 release candidate 3 tagged

Hi Robert,

Thanks for trying the example. I'm perplexed why it's OK for you but not me. In case you're curious, I'm attaching the screenshots of the output.

I should note again that I am running with OPENGL_PROFILE="GLCORE" / GL3 mode. Would that make a difference?


I will rebuild on Linux and test there; I have not done that yet. This doesn't seem like the kind of thing that would matter Windows vs Linux, but who knows. I will update this thread once I can check Linux.

- Dan


-----Original Message-----
From: osg-users [mailto:] On Behalf Of Robert Osfield
Sent: Thursday, May 10, 2018 11:32 AM
To: OpenSceneGraph Users
Subject: Re: OpenSceneGraph-3.6.1 release candidate 3 tagged

Hi Dan,

I finally had a chance to look at the your example. It works the same under 3.6 branch and 3.4 branch for me, I don't ever see any issues with the texture become skewed regardless of the size of the window.

Robert.




------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Daniel Emminizer, Code...
Guest





PostPosted: Sat May 12, 2018 1:26 pm    Post subject:
OpenSceneGraph-3.6.1 release candidate 3 tagged
Reply with quote

Hi Robert,

Tested out on my apps and everything regarding window resizing and text size is completely fixed now. Thanks a lot.

I spent several hours yesterday going over the code and trying to understand the transforms and shortcuts that were being taken. I was not able to come up with anything concrete. Looking at the new version, the code is a lot easier to understand. I had gotten to a point where I had understood most everything that was going on in the old version, but I still could not spy the problem.

You've got top notch support and I appreciate your time on this and all the other text issues in the last month. I'll be testing the RC next week but looking good so far.

- Dan


============================
  Dan Emminizer
  Code 5773.40
  Naval Research Laboratory
  https://simdis.nrl.navy.mil



Quote:
-----Original Message-----
From: osg-users [mailto:] On
Behalf Of Robert Osfield
Sent: Saturday, May 12, 2018 6:50 AM
To: OpenSceneGraph Users
Subject: Re: OpenSceneGraph-3.6.1 release candidate 3 tagged

Hi Dan,

I have had another look at this bug and using your text example I do
see some odd behaviour so I've rewritten TextBase::computeMatrix() so
use higher level matrix maths that is easier to understand than the
"fast" maths version that unrolled all the the matrix ops but was very
hard to follow. Hard to follow -> Hard to debug...

The new version of the scale maths now works better on your two text
test programs, and osgtext looks to behaving itself too.


https://github.com/openscenegraph/OpenSceneGraph/commit/362e355db
28582c839c88ddd6ede1d1ae1d74237

Now that this is fixed I will create another 3.6.1-rc, hopefully this
next one will be the last and we can finally get 3.6.1 out the door.

Robert.




------------------
Post generated by Mail2Forum
Back to top
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General All times are GMT
Goto page Previous  1, 2
Page 2 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts OpenSceneGraph BOF, Siggraph 2018 is ... robertosfield General 1 Tue Aug 14, 2018 3:00 pm View latest post
No new posts How I build OpenSceneGraph manually f... kornerr General 0 Tue Aug 14, 2018 11:51 am View latest post
No new posts OpenSceneGraph-3.6.2 released! robertosfield General 0 Fri Jun 29, 2018 10:28 am View latest post
No new posts OpenSceneGraph-3.6.2 release candidate 3 robertosfield General 1 Thu Jun 28, 2018 6:35 am View latest post
No new posts OpenSceneGraph-3.6.2 release candidat... robertosfield General 0 Wed Jun 27, 2018 8:24 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP