OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

Please test OpenSceneGraph-3.6


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General
View previous topic :: View next topic  
Author Message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11910

PostPosted: Fri May 18, 2018 2:49 pm    Post subject:
Please test OpenSceneGraph-3.6
Reply with quote

Hi All,

I have checked in a few fixes today, one of them I'm not confident
that it'll work across all platforms so I won't make 3.6.1-rc5 today,
instead I'll wait for feedback from the community.

As usual please let us know via this thread about success or failures.

Thanks for the testing,
Robert.

-- Changes since 3.6.1-rc4:

Fri, 18 May 2018 14:58:53 +0100
Author : Robert Osfield
Moved REGISTER_WINDOWINGSYSTEMINTERFACE from
include/osg/GraphicsContext to include/osgViewer/GraphicsWindow and
added OSGVIEWER_EXPORT

Fri, 18 May 2018 13:53:39 +0100
Author : Robert Osfield
Added GL_RED and GL_RG support to _readColor()/Image::getColor();

Fri, 18 May 2018 12:52:50 +0100
Author : Robert Osfield
Cleaned up the WindowingSystemInterface registration

Fri, 18 May 2018 12:47:34 +0100
Author : Robert Osfield
Fixed create of graphics context by explicting adding
USE_GRAPHICSWINDOW to force the WindowingSystemInterface to initialize

Fri, 18 May 2018 12:42:20 +0100
Author : Robert Osfield
Quitened down unsupport compression output when passing in a file with
a non rgb extension

Fri, 18 May 2018 10:00:10 +0100
Author : Robert Osfield
Introduced a local StateGraph hierarchy into
CullVisitor::apply(osg::Camera&) and RenderBin to fixed RTT Camera bug
where multiple RTT Camera end up with the rendering back end results
assigned to them which occured when RTT Camera's share the same
StateSet or null StateSet.

Mon, 14 May 2018 09:34:04 +0100
Author : Robert Osfield
Fixed support for update and event callbacks on
StateSet/Uniform/StateAttributes on View(er) Cameras.

Mon, 14 May 2018 08:43:08 +0100
Author : Robert Osfield
Renamed the counter used to enable traversal order sorting

Mon, 14 May 2018 08:24:02 +0100
Author : Robert Osfield
Improved the handling of precision

Sun, 13 May 2018 11:52:06 +0100
Author : Robert Osfield
Fixed crash when using ShapeDrawable with a TriangleMesh or ConvexHull
shape due to missing texture coords

Sun, 13 May 2018 09:23:38 +0100
Author : Robert Osfield
Updated for rc

Sun, 13 May 2018 09:18:31 +0100
Author : Robert Osfield
Removed _traverseNumber variable that was duplicating the one in
NodeVisitor base class


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Daniel Emminizer, Code...
Guest





PostPosted: Mon May 21, 2018 10:50 am    Post subject:
Please test OpenSceneGraph-3.6
Reply with quote

Hi Robert,

Getting a Windows build error on osgQt from the change on REGISTER_WINDOWINGSYSTEMINTERFACE() macro from last week. Are you the right person to report the problem to?

osgQt's GraphicsWindowQt.cpp includes the line:

#if 1
REGISTER_WINDOWINGSYSTEMINTERFACE(Qt, QtWindowingSystem)
...

With the change to the macro, it expands to:
extern "C" OSGVIEWER_EXPORT void graphicswindow_qt(void) {} ....

where OSGVIEWER_EXPORT is defined as "__declspec(dllimport)" (because we're now in osgQt and not osgViewer)


One possible fix is to add a parameter to REGISTER_WINDOWINGSYSTEMINTERFACE to specify the export flavor, such as:

#define REGISTER_WINDOWINGSYSTEMINTERFACE(export_type, ext, classname) \
extern "C export_type void ...

REGISTER_WINDOWINGSYSTEMINTERFACE(OSGQT_EXPORT, Qt, QtWindowingSystem)

Of course the down-side is that it would change the interface to the macro; but that seems better than the alternative of breaking on Windows. I'm happy to test if you need.

- Dan


Quote:
-----Original Message-----
From: osg-users [mailto:] On
Behalf Of Robert Osfield
Sent: Friday, May 18, 2018 10:49 AM
To: OpenSceneGraph Users
Subject: Please test OpenSceneGraph-3.6

Hi All,

I have checked in a few fixes today, one of them I'm not confident
that it'll work across all platforms so I won't make 3.6.1-rc5 today,
instead I'll wait for feedback from the community.

As usual please let us know via this thread about success or failures.

Thanks for the testing,
Robert.




------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11910

PostPosted: Mon May 21, 2018 11:28 am    Post subject:
Please test OpenSceneGraph-3.6
Reply with quote

Hi Dan,


Two steps forward, one step back....

For compatibility between various versions of the OSG and osgQt I am
inclined to change the REGISTER_WINDOWINGSYSTEMINTERFACE
implementation back to what it was and either introduce a new macro
that adds the OSGVIEWER_EXPORT or just have the
GraphicsWindowWin32.cpp not use the this help marco at all, and just
have it declare the extern and proxy objects directly in the code.


Robert.


On 21 May 2018 at 11:48, Daniel Emminizer, Code 5773
<> wrote:
Quote:
Hi Robert,

Getting a Windows build error on osgQt from the change on REGISTER_WINDOWINGSYSTEMINTERFACE() macro from last week. Are you the right person to report the problem to?

osgQt's GraphicsWindowQt.cpp includes the line:

#if 1
REGISTER_WINDOWINGSYSTEMINTERFACE(Qt, QtWindowingSystem)
...

With the change to the macro, it expands to:
extern "C" OSGVIEWER_EXPORT void graphicswindow_qt(void) {} ....

where OSGVIEWER_EXPORT is defined as "__declspec(dllimport)" (because we're now in osgQt and not osgViewer)


One possible fix is to add a parameter to REGISTER_WINDOWINGSYSTEMINTERFACE to specify the export flavor, such as:

#define REGISTER_WINDOWINGSYSTEMINTERFACE(export_type, ext, classname) \
extern "C export_type void ...

REGISTER_WINDOWINGSYSTEMINTERFACE(OSGQT_EXPORT, Qt, QtWindowingSystem)

Of course the down-side is that it would change the interface to the macro; but that seems better than the alternative of breaking on Windows. I'm happy to test if you need.

- Dan


Quote:
-----Original Message-----
From: osg-users [mailto:] On
Behalf Of Robert Osfield
Sent: Friday, May 18, 2018 10:49 AM
To: OpenSceneGraph Users
Subject: Please test OpenSceneGraph-3.6

Hi All,

I have checked in a few fixes today, one of them I'm not confident
that it'll work across all platforms so I won't make 3.6.1-rc5 today,
instead I'll wait for feedback from the community.

As usual please let us know via this thread about success or failures.

Thanks for the testing,
Robert.





------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Daniel Emminizer, Code...
Guest





PostPosted: Mon May 21, 2018 11:43 am    Post subject:
Please test OpenSceneGraph-3.6
Reply with quote

Hi Robert,

Seems like a reasonable approach. I'll rebuild on my side when you think you have something good.

- Dan



Quote:
-----Original Message-----
From: osg-users [mailto:] On
Behalf Of Robert Osfield
Sent: Monday, May 21, 2018 7:27 AM
To: OpenSceneGraph Users
Subject: Re: Please test OpenSceneGraph-3.6

Hi Dan,


Two steps forward, one step back....

For compatibility between various versions of the OSG and osgQt I am
inclined to change the REGISTER_WINDOWINGSYSTEMINTERFACE
implementation back to what it was and either introduce a new macro
that adds the OSGVIEWER_EXPORT or just have the
GraphicsWindowWin32.cpp not use the this help marco at all, and just
have it declare the extern and proxy objects directly in the code.


Robert.


On 21 May 2018 at 11:48, Daniel Emminizer, Code 5773
<> wrote:
Quote:
Hi Robert,

Getting a Windows build error on osgQt from the change on
REGISTER_WINDOWINGSYSTEMINTERFACE() macro from last week. Are you
the right person to report the problem to?
Quote:

osgQt's GraphicsWindowQt.cpp includes the line:

#if 1
REGISTER_WINDOWINGSYSTEMINTERFACE(Qt, QtWindowingSystem)
...

With the change to the macro, it expands to:
extern "C" OSGVIEWER_EXPORT void graphicswindow_qt(void) {} ....

where OSGVIEWER_EXPORT is defined as "__declspec(dllimport)"
(because we're now in osgQt and not osgViewer)
Quote:


One possible fix is to add a parameter to
REGISTER_WINDOWINGSYSTEMINTERFACE to specify the export flavor, such
as:
Quote:

#define REGISTER_WINDOWINGSYSTEMINTERFACE(export_type, ext,
classname) \
Quote:
extern "C export_type void ...

REGISTER_WINDOWINGSYSTEMINTERFACE(OSGQT_EXPORT, Qt,
QtWindowingSystem)
Quote:

Of course the down-side is that it would change the interface to the macro;
but that seems better than the alternative of breaking on Windows. I'm
happy to test if you need.
Quote:

- Dan


Quote:
-----Original Message-----
From: osg-users [mailto:]
On
Quote:
Quote:
Behalf Of Robert Osfield
Sent: Friday, May 18, 2018 10:49 AM
To: OpenSceneGraph Users
Subject: Please test OpenSceneGraph-3.6

Hi All,

I have checked in a few fixes today, one of them I'm not confident
that it'll work across all platforms so I won't make 3.6.1-rc5 today,
instead I'll wait for feedback from the community.

As usual please let us know via this thread about success or failures.

Thanks for the testing,
Robert.



openscenegraph.org



------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11910

PostPosted: Mon May 21, 2018 12:15 pm    Post subject:
Please test OpenSceneGraph-3.6
Reply with quote

Hi Dan,

On 21 May 2018 at 12:42, Daniel Emminizer, Code 5773
<> wrote:
Quote:
Seems like a reasonable approach. I'll rebuild on my side when you think you have something good.

I have checked in locally expanded version of the macro for
GraphicsWindowWin32.cpp, and restored the macro to it's original
location in the include/osg/GraphicsContext header:

https://github.com/openscenegraph/OpenSceneGraph/commit/dce6684c59698664771669ab7e21fbe4e26e5f42

I haven't tested under Windows thought so feedback would be very welcome.

Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Daniel Emminizer, Code...
Guest





PostPosted: Mon May 21, 2018 12:25 pm    Post subject:
Please test OpenSceneGraph-3.6
Reply with quote

Hi Robert,

Looks good from my end for compiling on MSVC 2015. Compiles and links without problem, same with osgQt.

- Dan


Quote:
-----Original Message-----
From: osg-users [mailto:] On
Behalf Of Robert Osfield
Sent: Monday, May 21, 2018 8:15 AM
To: OpenSceneGraph Users
Subject: Re: Please test OpenSceneGraph-3.6

Hi Dan,

On 21 May 2018 at 12:42, Daniel Emminizer, Code 5773
<> wrote:
Quote:
Seems like a reasonable approach. I'll rebuild on my side when you think
you have something good.

I have checked in locally expanded version of the macro for
GraphicsWindowWin32.cpp, and restored the macro to it's original
location in the include/osg/GraphicsContext header:


https://github.com/openscenegraph/OpenSceneGraph/commit/dce6684c59
698664771669ab7e21fbe4e26e5f42

I haven't tested under Windows thought so feedback would be very
welcome.

Robert.



------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 11910

PostPosted: Mon May 21, 2018 12:46 pm    Post subject:
Please test OpenSceneGraph-3.6
Reply with quote

On 21 May 2018 at 13:23, Daniel Emminizer, Code 5773
<> wrote:
Quote:
Hi Robert,

Looks good from my end for compiling on MSVC 2015. Compiles and links without problem, same with osgQt.

That's a relief. Thanks for the testing.

Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts OpenSceneGraph-3.6.2-rc1 tagged, plea... robertosfield General 0 Wed Jun 20, 2018 1:09 pm View latest post
No new posts Please test OpeSceneGraph-3.6 branch ... robertosfield General 0 Mon Jun 18, 2018 6:43 pm View latest post
No new posts C++11 for next stable release of Open... robertosfield General 8 Mon Jun 11, 2018 6:58 am View latest post
No new posts OpenSceneGraph-3.6.1 release candidate 7 robertosfield General 37 Fri May 25, 2018 11:30 am View latest post
No new posts OpenSceneGraph-3.6.1 release candidat... robertosfield General 4 Tue May 22, 2018 6:41 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP