OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

Drawable - recent commit causing problems


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General
View previous topic :: View next topic  
Author Message
gwaldron (Glenn Waldron)
Appreciator


Joined: 25 Aug 2011
Posts: 234

PostPosted: Thu Aug 30, 2018 12:19 pm    Post subject:
Drawable - recent commit causing problems
Reply with quote

Hi Robert,I pulled the latest OpenSceneGraph-3.6 branch and this change is causing rendering artifacts in osgEarth:


https://github.com/openscenegraph/OpenSceneGraph/commit/3808b298d1c5076daeb9d7644dc40b5038fb349c


I use Drawables that share the same StateSet. When the Drawable destructor calls releaseGLObjects() directly, that shared StateSet also gets its releaseGLObjects() function called and this causes ill effects on still-active Drawables.


Other Node types don't do this (call releaseGLObjects from the DTOR) so I'm wondering whether this was intentional, or whether this is exposing something I'm doing wrong on my end.
Glenn Waldron / osgEarth

------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12144

PostPosted: Thu Aug 30, 2018 3:38 pm    Post subject:
Drawable - recent commit causing problems
Reply with quote

Hi Glenn,

Ahhhh, Fix one problem create another...

The Drawable::releaseGLObjects() was added to the destrcutor fix a bug
with VertexArrayState not being cleaned up. Calling the
StateSet::releaseGLObjects() should be safe if it's not shared, but it
would be inappropriate to call it when shared, or at least
inappropriate when done in the context of the destrucutor.

Next week I'll return to the OSG for a bit so will have a look at it then.

Cheers,
Robert.

On Thu, 30 Aug 2018 at 13:17, Glenn Waldron <> wrote:
Quote:

Hi Robert,
I pulled the latest OpenSceneGraph-3.6 branch and this change is causing rendering artifacts in osgEarth:

https://github.com/openscenegraph/OpenSceneGraph/commit/3808b298d1c5076daeb9d7644dc40b5038fb349c

I use Drawables that share the same StateSet. When the Drawable destructor calls releaseGLObjects() directly, that shared StateSet also gets its releaseGLObjects() function called and this causes ill effects on still-active Drawables.

Other Node types don't do this (call releaseGLObjects from the DTOR) so I'm wondering whether this was intentional, or whether this is exposing something I'm doing wrong on my end.

Glenn Waldron / osgEarth



------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12144

PostPosted: Mon Sep 03, 2018 9:36 am    Post subject:
Drawable - recent commit causing problems
Reply with quote

H Glenn,

I don't have a test for the issue you've seen so have to implement
what I think could resolve the issue and get this checked into OSG
master, 3.6 and 3.6-TexStorage:

https://github.com/openscenegraph/OpenSceneGraph/commit/bcba3928e6be5d284b1611a0472fe5e24d184f67

I simply added a detach of the StateSet from the Drawable/Geometry in
the destructor prior to the call to releaseGLObjects().

Could you test it out and let me know if it resolves the issue.

Cheers,
Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
gwaldron (Glenn Waldron)
Appreciator


Joined: 25 Aug 2011
Posts: 234

PostPosted: Mon Sep 03, 2018 5:37 pm    Post subject:
Drawable - recent commit causing problems
Reply with quote

Robert,Indeed, that was exactly my workaround while you looked into the issue. So I'd say that will work. Thanks.
Glenn Waldron








On Mon, Sep 3, 2018 at 5:35 AM Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:

Quote:
H Glenn,

I don't have a test for the issue you've seen so have to implement
what I think could resolve the issue and get this checked into OSG
master, 3.6 and 3.6-TexStorage:

    https://github.com/openscenegraph/OpenSceneGraph/commit/bcba3928e6be5d284b1611a0472fe5e24d184f67

I simply added a detach of the StateSet from the Drawable/Geometry in
the destructor prior to the call to releaseGLObjects().

Could you test it out and let me know if it resolves the issue.

Cheers,
Robert.
_______________________________________________
osg-users mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> General All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts Problems with forum. poweruserm@live.com.au General 1 Sun Oct 28, 2018 11:45 pm View latest post
No new posts osg::Drawable vs osg::Geometry NoeMurr General 2 Sun Oct 21, 2018 2:45 pm View latest post
No new posts Problems porting from osg-3.4.0 to os... hvarma General 10 Wed Sep 12, 2018 3:29 pm View latest post
No new posts problems with osg-3.4.0 port to osg-3... Herman Varma General 4 Wed Sep 12, 2018 2:26 pm View latest post
No new posts [Crash issue] How to add&remove d... pwang General 2 Thu Jul 26, 2018 10:10 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP