OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

Fix hardware mipmap generation for cube maps


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12191

PostPosted: Tue Oct 02, 2018 11:38 am    Post subject:
Fix hardware mipmap generation for cube maps
Reply with quote

Hi Farshid,

I'm just reviewing this submission. Which version of the OSG did you
base them on? Texture.cpp has had various changes so it's hard to see
what changes you've made and what are from other changes.

Creating a PR via github is a decent alternative to posting
osg-submissions as it's a bit clearer what the base of the work was.

Cheers,
Robert.
On Wed, 18 Jul 2018 at 16:46, Farshid Lashkari <> wrote:
Quote:

Hi Robert,

I was getting a black image when enabling hardware mipmap generation on cubemaps. I believe the problem is that the base Texture class is hard coding GL_TEXTURE_2D when enabling mipmap generation, instead of using the target type from the derived class. I've attached the small change that fixed the issue for me.

Cheers,
Farshid



------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Farshid Lashkari
Guest





PostPosted: Tue Oct 02, 2018 3:55 pm    Post subject:
Fix hardware mipmap generation for cube maps
Reply with quote

Hi Robert,


My change was based on the latest master version from github at the time of submission. Looks like there have been some changes since then. I can submit a PR through github based on the current version. Do you prefer to have submissions made through github now?


Cheers,
Farshid



On Tue, Oct 2, 2018 at 4:38 AM Robert Osfield < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:

Quote:
Hi Farshid,

I'm just reviewing this submission.  Which version of the OSG did you
base them on?  Texture.cpp has had various changes so it's hard to see
what changes you've made and what are from other changes.

Creating a PR via github is a decent alternative to posting
osg-submissions as it's a bit clearer what the base of the work was.

Cheers,
Robert.
On Wed, 18 Jul 2018 at 16:46, Farshid Lashkari < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:

Hi Robert,

I was getting a black image when enabling hardware mipmap generation on cubemaps. I believe the problem is that the base Texture class is hard coding GL_TEXTURE_2D when enabling mipmap generation, instead of using the target type from the derived class. I've attached the small change that fixed the issue for me.

Cheers,
Farshid
_______________________________________________
osg-submissions mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org


------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12191

PostPosted: Tue Oct 02, 2018 5:25 pm    Post subject:
Fix hardware mipmap generation for cube maps
Reply with quote

Hi Farshid,

On Tue, 2 Oct 2018 at 16:54, Farshid Lashkari <> wrote:
Quote:
My change was based on the latest master version from github at the time of submission. Looks like there have been some changes since then. I can submit a PR through github based on the current version. Do you prefer to have submissions made through github now?

Yes, github PR's on average work best now.

Cheers,
Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12191

PostPosted: Thu Oct 04, 2018 8:05 am    Post subject:
Fix hardware mipmap generation for cube maps
Reply with quote

Thanks, merged from PR. Once tested I'll merge with 3.6 branch.
On Tue, 2 Oct 2018 at 18:24, Robert Osfield <> wrote:
Quote:

Hi Farshid,

On Tue, 2 Oct 2018 at 16:54, Farshid Lashkari <> wrote:
Quote:
My change was based on the latest master version from github at the time of submission. Looks like there have been some changes since then. I can submit a PR through github based on the current version. Do you prefer to have submissions made through github now?

Yes, github PR's on average work best now.

Cheers,
Robert.


------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts Moving from 3.4.1 to 3.5.7 breaks my ... loopy General 4 Mon Oct 01, 2018 4:09 pm View latest post
No new posts Fix hardware mipmap generation for cu... Farshid Lashkari Submission 0 Wed Jul 18, 2018 3:47 pm View latest post
No new posts No specular maps, exporting from blen... Klemen Červ Plugins [osgPlugins] 1 Wed May 16, 2018 1:08 pm View latest post
No new posts obj plugin does not support diffuse ... robertosfield Submission 6 Mon Mar 12, 2018 5:17 pm View latest post
No new posts iOS CMake project generation improvem... a.terenzi Submission 1 Mon Jan 22, 2018 11:58 am View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP