OpenSceneGraph Forum Forum Index OpenSceneGraph Forum
Official forum which mirrors the existent OSG mailing lists. Messages posted here are forwarded to the mailing list and vice versa.
 
   FAQFAQ    SearchSearch    MemberlistMemberlist    RulesRules    UsergroupsUsergroups    RegisterRegister 
 Mail2Forum SettingsMail2Forum Settings  ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
   AlbumAlbum  OpenSceneGraph IRC ChatOpenSceneGraph IRC Chat   SmartFeedSmartFeed 

Minor amendment to ReaderWriterCurl.cpp


 
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission
View previous topic :: View next topic  
Author Message
neil.hughes
Guest





PostPosted: Tue Mar 31, 2009 1:22 pm    Post subject:
Minor amendment to ReaderWriterCurl.cpp
Reply with quote

Hi Robert,

Started to migrate our app to OSG2.8, and I have a few submissions to make in regards to loading 3DS data from a stream. I've split the submission into two, as the changes necessary affect two plugins - 3DS and Curl.

This submission is the first, and is a very minor amendment to the ReaderWriterCurl.cpp file (attached) that adds the requested filename to the local options. The reason for this is that this name is used to name the toplevel node created in the 3DS loader. Ordinarily this is taken from the full file path, however, in a stream context this isn't available, hence the need to pass it through via options. I can't see that it should affect any other plugins.

Second submission to follow in a few minutes.

These submissions are a joint one from myself, and my colleague Chris Denham.

Kind regards

Neil.



------------------
Post generated by Mail2Forum
Back to top
robertosfield
OSG Project Lead


Joined: 18 Mar 2009
Posts: 12269

PostPosted: Thu Apr 09, 2009 2:06 pm    Post subject:
Minor amendment to ReaderWriterCurl.cpp
Reply with quote

Hi Neil,

The local setting of the Options string will hide any original values that the Options string would have, so might break existing usage.

Perhaps the extra string could be appended.  Or perhaps the Options object could be extended a bit to facilitate this type of functionality.

Robert.

On Tue, Mar 31, 2009 at 2:21 PM, < (
Only registered users can see emails on this board!
Get registred or enter the forums!
)> wrote:
Quote:
Hi Robert,

Started to migrate our app to OSG2.8, and I have a few submissions to make in regards to loading 3DS data from a stream. I've split the submission into two, as the changes necessary affect two plugins - 3DS and Curl.

This submission is the first, and is a very minor amendment to the ReaderWriterCurl.cpp file (attached) that adds the requested filename to the local options. The reason for this is that this name is used to name the toplevel node created in the 3DS loader. Ordinarily this is taken from the full file path, however, in a stream context this isn't available, hence the need to pass it through via options. I can't see that it should affect any other plugins.

Second submission to follow in a few minutes.

These submissions are a joint one from myself, and my colleague Chris Denham.

Kind regards

Neil.

_______________________________________________
osg-submissions mailing list
(
Only registered users can see emails on this board!
Get registred or enter the forums!
)
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org



------------------
Post generated by Mail2Forum
Back to top
View user's profile Send private message
neil.hughes
Guest





PostPosted: Thu Apr 09, 2009 4:29 pm    Post subject:
Minor amendment to ReaderWriterCurl.cpp
Reply with quote

Hi Robert,

Sorry, laziness on my part. I didn't check what that function did in too much detail. Shall I resubmit with an append operation, or are you happy doing it yourself ?

Neil.


---- Robert Osfield <> wrote:
Quote:
Hi Neil,

The local setting of the Options string will hide any original values that
the Options string would have, so might break existing usage.

Perhaps the extra string could be appended. Or perhaps the Options object
could be extended a bit to facilitate this type of functionality.

Robert.

On Tue, Mar 31, 2009 at 2:21 PM, <> wrote:

Quote:
Hi Robert,

Started to migrate our app to OSG2.8, and I have a few submissions to make
in regards to loading 3DS data from a stream. I've split the submission into
two, as the changes necessary affect two plugins - 3DS and Curl.

This submission is the first, and is a very minor amendment to the
ReaderWriterCurl.cpp file (attached) that adds the requested filename to the
local options. The reason for this is that this name is used to name the
toplevel node created in the 3DS loader. Ordinarily this is taken from the
full file path, however, in a stream context this isn't available, hence the
need to pass it through via options. I can't see that it should affect any
other plugins.

Second submission to follow in a few minutes.

These submissions are a joint one from myself, and my colleague Chris
Denham.

Kind regards

Neil.







------------------
Post generated by Mail2Forum
Back to top
Display posts from previous:   
Post new topic   Reply to topic    OpenSceneGraph Forum Forum Index -> Submission All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum

Similar Topics
Topic Author Forum Replies Posted
No new posts minor change: move assumeSizedInterna... mp3butcher General 9 Wed Aug 15, 2018 10:07 pm View latest post
No new posts Minor change proposal : Blacklist usa... mp3butcher General 14 Mon Aug 13, 2018 1:42 pm View latest post
No new posts Crash in ReaderWriterCURL::readFile w... hartwigw General 3 Sun Dec 17, 2017 11:46 pm View latest post
No new posts Minor issue with GraphicsWindowWin32.... loopy General 0 Mon Jan 23, 2017 10:18 pm View latest post
No new posts Building OSG 3.4.0 with VS2009, Windo... etienne1984 Build system [build] 0 Mon Feb 08, 2016 1:12 pm View latest post


Board Security Anti Bot Question MOD - phpBB MOD against Spam Bots
Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP